Makes nicer code
Details
Details
Diff Detail
Diff Detail
- Repository
- R351 KSystemLog
- Branch
- for
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25559 Build 25577: arc lint + arc unit
Comment Actions
I guess we're doing it for readability in sacrifice of simplicity or performance which admittedly is probably meaningless here.
If that's what you're after I'll happily accept the patch but I'd first like to know.
| src/loggerDialog.cpp | ||
|---|---|---|
| 64 | You can iterate the priorities then you don't need to create teh QList<QString> at all. | |
| 80 | Here the right thing to do would be to iterate through facilities rather than the facilities keys and you'd save instantiating the list. | |