By setting the new variable to true the service path gets appended
to the list of arguments. Otherwise there is no way
(at least not that I know of, please correct me if I am wrong) of getting the service
file which was used to launch the module.
Accessing the service file is a requirement for T13079: Make runner KCMs easier to extend.
Add m_pluginSelector->setAppendServicePath(true); in the
kcms/runners/kcm.cpp in the repo plasma-desktop. If you print out the arguments of
a runner config module (plasma-workspace contains some) you should see the service file.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 26315 | |
| Build 26333: arc lint + arc unit |
I have the feeling there's a missing piece here.
Would it make sense to always pass it? Would it regress in any way?
At the very least, on the API documentation, explain why one would want that.
Would it make sense to always pass it? Would it regress in any way?
It would make sense, but it would change the existing behavior.
If you use the method setConfigurationArguments then you expect your argument list to be the list of arguments you specified + an entry for the metadata.
So adding an entry by default could break things.
Improve documentation
Is that what you had in mind :-) ?
And should I maybe add a comment to make this the default in KF6?
| src/kpluginselector.cpp | ||
|---|---|---|
| 855 | Adding a fileName field to KCModuleProxy would make more sense to me, and do it by default. | |
| src/kpluginselector.cpp | ||
|---|---|---|
| 855 | You could add a field to the KCModule class (thats where you ultimately want to access the fileName). | |
| src/kpluginselector.cpp | ||
|---|---|---|
| 855 | moduleInfo is part of the ctor here, so the fileName is already available indirectly. | |
| src/kpluginselector.cpp | ||
|---|---|---|
| 855 |
Yes, but the KCModuleProxy is just a wrapper class for the KCModule. PS: The moduleInfo is also available there, but I don't see any elegant way to make it available to the KCModule other than a property or appending it to the list of arguments.
Always open to suggestions 😃 | |
| src/kpluginselector.cpp | ||
|---|---|---|
| 855 | Seems like a property would make sense, after all it is about it, or a ref to the KCModuleInfo | |
| src/kpluginselector.cpp | ||
|---|---|---|
| 855 | I have created a PR on Gitlab for this | |
Abandoning this in favor of https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/1 and a follow up PR.