This effect is buggy and not maintained (we have lack of man power).

In this case we don't directly want to set focus on this Toplevel, but wait until the surface is set.

From my last comment

Yeah, docs explicitly say to use window geometry.

I'm still not quite sure what exactly we have to do when a client is unmapped. Should we send a configure event?

<3

Yes please

There isn't a global animation speed, but using Kirigami.units does indeed make sense.

bump, this is a change I do want to push for.

Can you expand upon why?

Personally I tend to prefer just readable, explicit code for simple cases.

We are really bad at letting reviews get lost and unnoticed. I'm really sorry!

Urgh, that cascade issue is a bit sucky. I assumed all placement operations were deterministic.

Sessionbackend.h is not installed.

That's a good reason to do it at compile time :D

Wrap saveSession

#30 0x00007f525ca47a9c in QFontMetrics::boundingRect(QChar) const () at /usr/lib/libQt5Gui.so.5

What happens if this is not patched out?

No technical complaints from me.

@davidedmundson is /usr/share/kglobalaccel the correct folder?

Can you explain not what the change is doing, but why we're making it?

Dave, are you ok with changing the license from GPL to LGPL?

addressed comments

update

updates

The analysis makes sense, I don't understand why this is the correct fix.

Software rotation still doesn't work correctly on my machine :'(

We have a bug report about infinite loop in the notifications.

Ah, you meant

and fix combobox text being corrupted or invisible

Oh, on a related note, I actually do wonder if we should symlink start-here-kde in breeze to start-here-kde-plasma and use that instead to differentiate? As per the spec on !breeze icon themes start-here-kde-plasma would fall back to start-here-kde if the plasma icon doesn't exist IIRC. So it's just as portable but less ambiguous perhaps.

Hardcoding pixel size won't impact scaling.

It's autogenerated, so non-trivial

These two should make the unit tests windows compatible (untested)

thanks

Awesome progress. Thanks ever so much.

As far as I know, xdg-shell doesn't define maximized vertically or maximized horizontally states.

update docs

It's subtle but I quite like it.
It feels a bit inconsistent given it affects plasmoids on keyshortcut, but not on click.

Thanks.

Careful with konsole, we have to do a migration as AFAIK it's been released with the khotkeys file.