Differential D20199

[Menu] Fix triggered sign
ClosedPublic
Actions

Authored by broulik on Apr 2 2019, 10:13 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:9aa249e86a34: [Menu] Fix triggered signal
Summary

It casted the QAction to a MenuItem which fails because it isn't such.
Instead, manually find the item with the corresponding action.

Test Plan
PlasmaComponents.ContextMenu {
    onTriggered: console.log(item)
}

works now

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 2 2019, 10:13 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 2 2019, 10:13 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 2 2019, 10:13 AM
davidedmundson accepted this revision.Apr 2 2019, 10:22 AM
This revision is now accepted and ready to land.Apr 2 2019, 10:22 AM
Closed by commit R242:9aa249e86a34: [Menu] Fix triggered signal (authored by broulik). · Explain WhyApr 2 2019, 12:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55267

View Options

src/declarativeimports/plasmacomponents/qmenu.cpp

Loading...