Differential D20087

Enable glGetGraphicsResetStatus support by default on Qt >= 5.13
ClosedPublic
Actions

Authored by davidedmundson on Mar 28 2019, 11:22 AM.

Details

Reviewers
apol
Commits
R296:c244729b6771: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13
Summary

I added support in Qt for handling Nvidia's glGetGraphicsResetStatus
flag, which reports when it has lost it's context and the visual state
needs refreshing.

As it required some changes in various other parts of Qt and Plasma this
was opt-in behind a QSurfaceFormat flag which I exposed to Plasma users
via a config option. Since Qt5.12.2 everything seems to work nicely.

This patch enables support on Qt >= 5.13 to play safe.

BUG: 364766

Test Plan

Feedback from wide test audience on the bug report.

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 28 2019, 11:22 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 28 2019, 11:22 AM
apol added a subscriber: apol.Mar 28 2019, 3:40 PM
apol added inline comments.
src/quickaddons/qtquicksettings.cpp
47

Shouldn't this check be in graphicsResetNotifications then?

davidedmundson added a comment.Mar 28 2019, 3:42 PM

It's autogenerated, so non-trivial

apol accepted this revision.Mar 28 2019, 4:05 PM

¯\_(ツ)_/¯

This revision is now accepted and ready to land.Mar 28 2019, 4:05 PM
ngraham added a subscriber: ngraham.Mar 29 2019, 11:32 PM

Given the testing already done by users, yeah, I think this is safe to land. +1

Closed by commit R296:c244729b6771: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13 (authored by davidedmundson). · Explain WhyApr 7 2019, 3:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55682

View Options

src/quickaddons/qtquicksettings.cpp

Loading...