Allow building without UDev on Linux
ClosedPublic

Authored by apol on Apr 3 2019, 3:34 PM.

Details

Summary

Flatpak has been patching this for a while, there doesn't seem to be a way to
use it there, so we better offer the option upstream.

Test Plan

Been building and using solid on flatpak runtimes for a while.

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 3 2019, 3:34 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 3 2019, 3:34 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Apr 3 2019, 3:34 PM

What happens if this is not patched out?

I'm asking because I'm hoping to use bwrap in more places outside of flatpak. In that case I'm going to need runtime detection.

apol added a comment.Apr 3 2019, 8:33 PM

I don't really remember the reason why we can't use udev there, it was more of a "it can be there but it will be useless", then there was a very long discussion with "what if I..." and people saying that udev needed redesigning. It was few years ago.
At the moment if we don't patch it out it just won't build.

davidedmundson accepted this revision.Apr 3 2019, 8:34 PM

That's a good reason to do it at compile time :D

This revision is now accepted and ready to land.Apr 3 2019, 8:34 PM
This revision was automatically updated to reflect the committed changes.