I don't know if it would be best at this stage to create a RFC code review or upload it to a new <user> branch.
Fri, Feb 21
This is a nice simple example of something with a version bump: https://phabricator.kde.org/D27535 for where to change registry.
Getting rid of widgets and QApplication doesn't necessarily mean getting rid of QtGui and QGuiApplication. They are a lot lot lighter.
I stand corrected, my apologies.
PlasmaExtras.Title is deprecated
Thu, Feb 20
I was wrong.
only pass in adjusted env
Cleanup is good.
QQuickImageProvider wants the requestedSize to be accounting for the dpi scaling.
From the mailing list thread:
Good start. The direction makes sense.
Wed, Feb 19
In my opinion the Plasma Controls need fix
we would not need to remove it
Weird. plasma-framework's version of icon (which this is copied from) has had that check for years.
Oh, of course
Tue, Feb 18
Right, but do you agree that it now is supported?
I don't know
That commit has been there since 5.12.5
From a logical viewpoirnt it doesn't make sense. It's a binding loop. Changing the width will re-lay out, which will change the paintedWidth, which will change the width.
Practically QQuickTextItem has a catch against that (see qquicktext.cpp: internalWidthUpdate) and it will stop after the first pass without a warning.
The role names part is nice.
I'm skeptical that kwaylandscanner adds anything, especially when we want to pretty much clone a class, but sure.
Requires D27476 to not crash
rebase and squash changes
Turns out this is fixing up something that changed in the non-merged patch.
Please update tests/components to have it failing before and now passing.
As there's no reason to clear the environment, wouldn't it be more useful if StartServiceJob would only allow adding/overwriting variables?
I don't really understand it, but this does match the original code closer and it does make a difference to what we send out over the wire
I think for 5.18
Fix process env
Correctly wait for kcminit phase 0 to finish
Mon, Feb 17
This raises a question. what do we want to do with KToolInvocation?
Remove extra include