Feed Advanced Search

Yesterday

davidedmundson requested review of D27590: Calculate needsSave on checkbox toggle not on change.
Sat, Feb 22, 10:45 PM · Plasma

Fri, Feb 21

davidedmundson added a comment to T12729: KWinRules KCM Redesign.

I don't know if it would be best at this stage to create a RFC code review or upload it to a new <user> branch.

Fri, Feb 21, 11:01 PM · VDG, Plasma: KCM Redesign
davidedmundson added a comment to D27464: Add application menu dbus paths to org_kde_plasma_window interface.

This is a nice simple example of something with a version bump: https://phabricator.kde.org/D27535 for where to change registry.

Fri, Feb 21, 6:42 PM · Frameworks
davidedmundson added a comment to T12191: KDED: qwidget dependency.

Getting rid of widgets and QApplication doesn't necessarily mean getting rid of QtGui and QGuiApplication. They are a lot lot lighter.

Fri, Feb 21, 5:39 PM · KF6
davidedmundson committed R120:78f60b8d1124: drop kdeinit (authored by davidedmundson).
drop kdeinit
Fri, Feb 21, 4:41 PM
davidedmundson accepted D27350: Port away from Title and towards level 1 Heading.
Fri, Feb 21, 3:30 PM · Frameworks
davidedmundson accepted D27348: Port to use level 1 Heading instead of Title.

I stand corrected, my apologies.

Fri, Feb 21, 3:09 PM · Plasma
davidedmundson added inline comments to D27535: Add XdgOutputV1 version 2.
Fri, Feb 21, 1:43 PM · Frameworks
davidedmundson committed R120:b8fa9be7185c: Temporarily block startplasma to match existing paths (authored by davidedmundson).
Temporarily block startplasma to match existing paths
Fri, Feb 21, 1:38 PM
davidedmundson requested changes to D27348: Port to use level 1 Heading instead of Title.

PlasmaExtras.Title is deprecated

Fri, Feb 21, 1:20 PM · Plasma
davidedmundson committed R116:9a603a90fd5d: Fix build with missing includes (authored by davidedmundson).
Fix build with missing includes
Fri, Feb 21, 12:45 PM
davidedmundson committed R116:762504196246: [kded] Set password dialog boxes to plaintext (authored by davidedmundson).
[kded] Set password dialog boxes to plaintext
Fri, Feb 21, 12:41 PM
davidedmundson closed D27541: [kded] Set password dialog boxes to plaintext.
Fri, Feb 21, 12:41 PM · Plasma
davidedmundson committed R116:abe0ed15ec5a: [kded] Escape notifications (authored by davidedmundson).
[kded] Escape notifications
Fri, Feb 21, 12:41 PM
davidedmundson closed D27542: [kded] Escape notifications.
Fri, Feb 21, 12:41 PM · Plasma
davidedmundson committed R116:28c36476fc3b: [kcm] Escape connection name in close dialog (authored by davidedmundson).
[kcm] Escape connection name in close dialog
Fri, Feb 21, 12:41 PM
davidedmundson closed D27545: Escape connection name in close dialog.
Fri, Feb 21, 12:41 PM · Plasma
davidedmundson committed R97:c34ef123245f: Merge branch 'Plasma/5.18' (authored by davidedmundson).
Merge branch 'Plasma/5.18'
Fri, Feb 21, 12:39 PM
davidedmundson committed R97:a8034c36ea07: Set all labels to plain text (authored by davidedmundson).
Set all labels to plain text
Fri, Feb 21, 12:39 PM
davidedmundson committed R97:f9c59b99074a: Merge branch 'master' of https://anongit.kde.org/bluedevil (authored by davidedmundson).
Merge branch 'master' of https://anongit.kde.org/bluedevil
Fri, Feb 21, 12:39 PM
davidedmundson committed R97:4a6f4b8f8a71: Merge branch 'Plasma/5.12' into Plasma/5.18 (authored by davidedmundson).
Merge branch 'Plasma/5.12' into Plasma/5.18
Fri, Feb 21, 12:39 PM
davidedmundson committed R97:fb1a8474651e: Set all labels to plain text (authored by davidedmundson).
Set all labels to plain text
Fri, Feb 21, 12:38 PM
davidedmundson closed D27543: Set all labels to plain text.
Fri, Feb 21, 12:38 PM · Plasma
davidedmundson requested review of D27545: Escape connection name in close dialog.
Fri, Feb 21, 12:14 PM · Plasma
davidedmundson updated the title for P545 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Fri, Feb 21, 12:09 PM
davidedmundson requested review of D27543: Set all labels to plain text.
Fri, Feb 21, 11:44 AM · Plasma
davidedmundson requested review of D27542: [kded] Escape notifications.
Fri, Feb 21, 11:28 AM · Plasma
davidedmundson requested review of D27541: [kded] Set password dialog boxes to plaintext.
Fri, Feb 21, 11:24 AM · Plasma
davidedmundson accepted D27536: fix(kwayland): remove code with side-effects from Q_ASSERT.
Fri, Feb 21, 10:05 AM · Plasma
davidedmundson updated the diff for D27535: Add XdgOutputV1 version 2.

update

Fri, Feb 21, 1:05 AM · Frameworks
davidedmundson requested review of D27535: Add XdgOutputV1 version 2.
Fri, Feb 21, 1:04 AM · Frameworks

Thu, Feb 20

davidedmundson updated the summary of D27529: [applets/weather] Remove outdated extra configure button.
Thu, Feb 20, 7:45 PM · Plasma
davidedmundson updated the diff for D27529: [applets/weather] Remove outdated extra configure button.

include comics

Thu, Feb 20, 7:37 PM · Plasma
davidedmundson requested review of D27529: [applets/weather] Remove outdated extra configure button.
Thu, Feb 20, 7:00 PM · Plasma
davidedmundson accepted D27516: Schedule a workspace repaint in AbstractClient::minimize().
Thu, Feb 20, 3:04 PM · KWin
davidedmundson accepted D27515: Icon: fix rendering of image: urls on High DPI.

I was wrong.

Thu, Feb 20, 2:50 PM · Kirigami
davidedmundson updated the diff for D27457: Move kcminit_startup and kded to plasma-session.

fixup diff

Thu, Feb 20, 12:45 PM · Plasma
davidedmundson updated the diff for D27457: Move kcminit_startup and kded to plasma-session.

only pass in adjusted env

Thu, Feb 20, 12:37 PM · Plasma
davidedmundson added a comment to D27495: Remove unnecessary code and function calls.

Cleanup is good.

Thu, Feb 20, 11:53 AM · Plasma
davidedmundson added a comment to D27515: Icon: fix rendering of image: urls on High DPI.

QQuickImageProvider wants the requestedSize to be accounting for the dpi scaling.

Thu, Feb 20, 11:06 AM · Kirigami
davidedmundson added inline comments to D27481: Panel spacer that can center things.
Thu, Feb 20, 10:28 AM · Plasma
davidedmundson raised a concern with R169:2cea7b4781c9: fix margins in OverlaySheet.

From the mailing list thread:

Thu, Feb 20, 1:04 AM
davidedmundson added a comment to D27464: Add application menu dbus paths to org_kde_plasma_window interface.

Good start. The direction makes sense.

Thu, Feb 20, 12:28 AM · Frameworks
davidedmundson accepted D27514: Fix incorrect use of case statements in accountmodel.cpp.
Thu, Feb 20, 12:04 AM · Plasma

Wed, Feb 19

davidedmundson accepted D27088: [applets/SystemTray] Implement sorting in the model.
Wed, Feb 19, 9:07 PM · Plasma
davidedmundson added a comment to D27083: [PC2]Give Label integer width..

In my opinion the Plasma Controls need fix

Wed, Feb 19, 6:34 PM · Plasma, Frameworks
davidedmundson requested review of D27509: Introduce ProcessDataModel.
Wed, Feb 19, 5:30 PM · Plasma
davidedmundson added a comment to D27316: [Folder view]Make shadow scale aware.

we would not need to remove it

Wed, Feb 19, 3:06 PM · Plasma
davidedmundson accepted D27505: Do not crash when icon's width or height is 0.

Weird. plasma-framework's version of icon (which this is copied from) has had that check for years.

Wed, Feb 19, 3:00 PM · Kirigami
davidedmundson accepted D27316: [Folder view]Make shadow scale aware.

Oh, of course

Wed, Feb 19, 12:42 PM · Plasma
davidedmundson accepted D27460: fix layout size hints for button labels.
Wed, Feb 19, 11:08 AM · Frameworks
davidedmundson added inline comments to D27460: fix layout size hints for button labels.
Wed, Feb 19, 10:13 AM · Frameworks
davidedmundson closed D27473: [linechart] Guard against divide by 0.
Wed, Feb 19, 10:01 AM
davidedmundson committed R108:39798bffb139: [plastik] Disable problematic text hints (authored by davidedmundson).
[plastik] Disable problematic text hints
Wed, Feb 19, 8:27 AM
davidedmundson closed D27488: [plastik] Disable problematic text hints.
Wed, Feb 19, 8:27 AM · KWin

Tue, Feb 18

davidedmundson requested review of D27488: [plastik] Disable problematic text hints.
Tue, Feb 18, 11:32 PM · KWin
davidedmundson added inline comments to D27422: [KCM]Update Device item layout based on applet.
Tue, Feb 18, 10:45 PM · Plasma
davidedmundson moved T12722: Drop KDBusConnectionPool from Needs Input to Waiting on KF6 Branching on the KF6 board.
Tue, Feb 18, 10:33 PM · KF6
davidedmundson renamed T12722: Drop KDBusConnectionPool from KDBusConnectionPool: is it still needed? to Drop KDBusConnectionPool.
Tue, Feb 18, 10:33 PM · KF6
davidedmundson added a comment to T12722: Drop KDBusConnectionPool.

Right, but do you agree that it now is supported?

Tue, Feb 18, 9:31 PM · KF6
davidedmundson added a comment to D27316: [Folder view]Make shadow scale aware.

I don't know

Tue, Feb 18, 7:41 PM · Plasma
davidedmundson added a comment to D27316: [Folder view]Make shadow scale aware.

That commit has been there since 5.12.5

Tue, Feb 18, 7:16 PM · Plasma
davidedmundson requested changes to D27316: [Folder view]Make shadow scale aware.
Tue, Feb 18, 7:06 PM · Plasma
davidedmundson added a comment to D27316: [Folder view]Make shadow scale aware.

See https://code.qt.io/cgit/qt/qtgraphicaleffects.git/commit/src/effects/private/DropShadowBase.qml?id=f9664053132affe48a069235eb6561a32d38b2a7

Tue, Feb 18, 7:03 PM · Plasma
davidedmundson added a comment to D27083: [PC2]Give Label integer width..

From a logical viewpoirnt it doesn't make sense. It's a binding loop. Changing the width will re-lay out, which will change the paintedWidth, which will change the width.
Practically QQuickTextItem has a catch against that (see qquicktext.cpp: internalWidthUpdate) and it will stop after the first pass without a warning.

Tue, Feb 18, 5:31 PM · Plasma, Frameworks
davidedmundson requested changes to D27088: [applets/SystemTray] Implement sorting in the model.

The role names part is nice.

Tue, Feb 18, 5:26 PM · Plasma
davidedmundson added inline comments to D27460: fix layout size hints for button labels.
Tue, Feb 18, 5:06 PM · Frameworks
davidedmundson accepted D24004: Teach kwaylandscanner about PrimarySelection.

I'm skeptical that kwaylandscanner adds anything, especially when we want to pretty much clone a class, but sure.

Tue, Feb 18, 4:57 PM · Frameworks
davidedmundson added inline comments to D27460: fix layout size hints for button labels.
Tue, Feb 18, 3:56 PM · Frameworks
davidedmundson updated the diff for D27475: Make kwapper/kshell spawn klauncher5 if needed.

update

Tue, Feb 18, 3:18 PM · Frameworks
davidedmundson created T12722: Drop KDBusConnectionPool.
Tue, Feb 18, 2:23 PM · KF6
davidedmundson added a comment to D27475: Make kwapper/kshell spawn klauncher5 if needed.

Requires D27476 to not crash

Tue, Feb 18, 2:05 PM · Frameworks
davidedmundson requested review of D27476: [KDBusConnectionPool] Handle the case of no qApp.
Tue, Feb 18, 2:04 PM · Frameworks
davidedmundson requested review of D27475: Make kwapper/kshell spawn klauncher5 if needed.
Tue, Feb 18, 2:00 PM · Frameworks
davidedmundson added inline comments to D27473: [linechart] Guard against divide by 0.
Tue, Feb 18, 1:45 PM
davidedmundson updated the diff for D27457: Move kcminit_startup and kded to plasma-session.

rebase and squash changes

Tue, Feb 18, 12:53 PM · Plasma
davidedmundson abandoned D27472: [plasma-session] Cleanup StartServiceJob.

Turns out this is fixing up something that changed in the non-merged patch.

Tue, Feb 18, 12:50 PM · Plasma
davidedmundson added inline comments to D27471: [plasma-session] Avoid potential race condition starting a service.
Tue, Feb 18, 12:47 PM · Plasma
davidedmundson committed R120:aa3319e2a97b: Merge branch 'Plasma/5.18' (authored by davidedmundson).
Merge branch 'Plasma/5.18'
Tue, Feb 18, 12:41 PM
davidedmundson committed R120:854b64fc130b: [plasma-session] Avoid hypothetical race condition starting a service (authored by davidedmundson).
[plasma-session] Avoid hypothetical race condition starting a service
Tue, Feb 18, 12:40 PM
davidedmundson closed D27471: [plasma-session] Avoid potential race condition starting a service.
Tue, Feb 18, 12:40 PM · Plasma
davidedmundson added inline comments to D27472: [plasma-session] Cleanup StartServiceJob.
Tue, Feb 18, 12:21 PM · Plasma
davidedmundson accepted D27367: fix activity runner.
Tue, Feb 18, 12:05 PM · Plasma
davidedmundson added a reviewer for D27473: [linechart] Guard against divide by 0: ahiemstra.
Tue, Feb 18, 12:00 PM
davidedmundson requested changes to D27460: fix layout size hints for button labels.

Please update tests/components to have it failing before and now passing.

Tue, Feb 18, 11:52 AM · Frameworks
davidedmundson requested review of D27473: [linechart] Guard against divide by 0.
Tue, Feb 18, 10:49 AM
davidedmundson accepted D27470: Set good default value for cursor theme and size in KRDB.
Tue, Feb 18, 10:37 AM · Plasma
davidedmundson added a comment to D27457: Move kcminit_startup and kded to plasma-session.

As there's no reason to clear the environment, wouldn't it be more useful if StartServiceJob would only allow adding/overwriting variables?

Tue, Feb 18, 10:27 AM · Plasma
davidedmundson added a comment to D27456: Fix misplaced client windows.

I don't really understand it, but this does match the original code closer and it does make a difference to what we send out over the wire

Tue, Feb 18, 10:25 AM · KWin
davidedmundson requested review of D27472: [plasma-session] Cleanup StartServiceJob.
Tue, Feb 18, 10:18 AM · Plasma
davidedmundson added a comment to D27471: [plasma-session] Avoid potential race condition starting a service.

I think for 5.18

Tue, Feb 18, 10:06 AM · Plasma
davidedmundson requested review of D27471: [plasma-session] Avoid potential race condition starting a service.
Tue, Feb 18, 10:06 AM · Plasma
davidedmundson updated the diff for D27457: Move kcminit_startup and kded to plasma-session.

Fix process env
Correctly wait for kcminit phase 0 to finish

Tue, Feb 18, 10:03 AM · Plasma
davidedmundson added inline comments to D27457: Move kcminit_startup and kded to plasma-session.
Tue, Feb 18, 8:49 AM · Plasma
davidedmundson committed R304:5c7ee50bf900: Don't double delete CommentsModel (authored by davidedmundson).
Don't double delete CommentsModel
Tue, Feb 18, 8:43 AM
davidedmundson closed D27468: Don't double delete CommentsModel.
Tue, Feb 18, 8:43 AM · Frameworks
davidedmundson committed R120:f19f6e52dc77: Change killmode (authored by davidedmundson).
Change killmode
Tue, Feb 18, 12:52 AM

Mon, Feb 17

davidedmundson added a comment to T12140: Killing KInit With Fire.

This raises a question. what do we want to do with KToolInvocation?

Mon, Feb 17, 11:56 PM · Frameworks, KF6
davidedmundson updated the diff for D27451: Drop KToolInvocation support from KRun::runService.

Remove extra include

Mon, Feb 17, 11:40 PM · Frameworks
davidedmundson requested review of D27468: Don't double delete CommentsModel.
Mon, Feb 17, 11:31 PM · Frameworks