Feed Advanced Search

Today

davidedmundson added a comment to D17217: Implement free memory notifier.

It would just be nice not to have to think about this stuff

Fri, Feb 15, 5:44 PM · Plasma
davidedmundson added a comment to T10481: Improve scaled buffer rendering.

Yeah, that's crazy, I'm not trying to go into that.

Fri, Feb 15, 4:13 PM · KWin
davidedmundson committed R243:3d5713ba3760: Guard KCompressionDevice::open being called with no backend available (authored by davidedmundson).
Guard KCompressionDevice::open being called with no backend available
Fri, Feb 15, 3:10 PM
davidedmundson closed D18965: Guard KCompressionDevice::open being called with no backend available.
Fri, Feb 15, 3:10 PM · Frameworks
davidedmundson accepted D19034: [effects] Make sure that all effects reset the streaming buffer.
Fri, Feb 15, 1:29 PM · KWin
davidedmundson committed R122:e360098da5c5: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Fri, Feb 15, 1:15 PM
davidedmundson committed R122:b8a44a4cc87a: Exclude powerdevil from session management (authored by davidedmundson).
Exclude powerdevil from session management
Fri, Feb 15, 1:15 PM
davidedmundson closed D19024: Exclude powerdevil from session management.
Fri, Feb 15, 1:15 PM · Plasma
davidedmundson committed R110:42a100ad3e9d: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Fri, Feb 15, 1:14 PM
davidedmundson committed R110:ee3f33ba4925: Exclude kscreen backend launcher from session management (authored by davidedmundson).
Exclude kscreen backend launcher from session management
Fri, Feb 15, 1:14 PM
davidedmundson closed D19025: Exclude kscreen backend launcher from session management.
Fri, Feb 15, 1:14 PM · Plasma
davidedmundson committed R120:91f0593be865: Merge branch 'Plasma/5.15' (authored by davidedmundson).
Merge branch 'Plasma/5.15'
Fri, Feb 15, 1:09 PM
davidedmundson committed R120:b4ddae947936: [ksmserver] Restore legacy sessions (authored by davidedmundson).
[ksmserver] Restore legacy sessions
Fri, Feb 15, 1:02 PM
davidedmundson committed R120:9d7d80134ea6: Exclude kuiserver from session management (authored by davidedmundson).
Exclude kuiserver from session management
Fri, Feb 15, 1:02 PM
davidedmundson closed D19028: [ksmserver] Restore legacy sessions.
Fri, Feb 15, 1:02 PM · Plasma
davidedmundson closed D19026: Exclude kuiserver from session management.
Fri, Feb 15, 1:02 PM · Plasma
davidedmundson added a comment to D19034: [effects] Make sure that all effects reset the streaming buffer.

It seems effects/blur needs the same fix.

Fri, Feb 15, 12:53 PM · KWin
davidedmundson added a comment to D19029: Guard virtualDesktopManagement being accessed before fetched.

The other option is:

Fri, Feb 15, 2:43 AM · Plasma
davidedmundson requested review of D19029: Guard virtualDesktopManagement being accessed before fetched.
Fri, Feb 15, 2:35 AM · Plasma
davidedmundson requested review of D19028: [ksmserver] Restore legacy sessions.
Fri, Feb 15, 2:29 AM · Plasma
davidedmundson added inline comments to D19007: Wait for DBus Reply Before Performing Computations.
Fri, Feb 15, 2:07 AM · Baloo, Frameworks
davidedmundson added a comment to T9779: Split KSMServer to be just an XSessionManager.

libkworkspace plans:

Fri, Feb 15, 1:14 AM · Plasma
davidedmundson requested review of D19026: Exclude kuiserver from session management.
Fri, Feb 15, 12:59 AM · Plasma
davidedmundson requested review of D19025: Exclude kscreen backend launcher from session management.
Fri, Feb 15, 12:56 AM · Plasma
davidedmundson requested review of D19024: Exclude powerdevil from session management.
Fri, Feb 15, 12:52 AM · Plasma

Yesterday

davidedmundson added a comment to D19019: Verify that model.AppPid is defined.

In what situation is it undefined?

Thu, Feb 14, 9:45 PM · Plasma
davidedmundson added a comment to D19012: [qpa] Drop PlatformContextWayland which uses wayland egl for OpenGL.

or we have the QPainter compositor which also turns QtQuick to use software renderer.

Thu, Feb 14, 5:26 PM · KWin
davidedmundson added a comment to T10481: Improve scaled buffer rendering.

I used a super super lazy bodge to enable lanczos on random windows:

Thu, Feb 14, 4:27 PM · KWin
davidedmundson updated the title for P319 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Thu, Feb 14, 4:19 PM
davidedmundson created T10481: Improve scaled buffer rendering.
Thu, Feb 14, 2:46 PM · KWin
davidedmundson requested review of D19004: Remove extra nested dbus session.
Thu, Feb 14, 1:46 PM · Plasma
davidedmundson accepted D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative.
Thu, Feb 14, 12:54 PM · Plasma
davidedmundson accepted D18115: Add support for fake pointer move with absolute coordinates.
Thu, Feb 14, 12:43 PM · KWin
davidedmundson accepted D18114: FakeInput: add support for pointer move with absolute coordinates.

Given we have absolute events for other input, this makes sense.

Thu, Feb 14, 12:41 PM · Frameworks
davidedmundson accepted D18210: Add addToplevel and removeToplevel to Scene.
Thu, Feb 14, 12:07 PM · KWin
davidedmundson added a comment to D18933: Send optional events from wl_pointer v5.

so we could send a diagonal scroll motion in one frame?

Thu, Feb 14, 11:18 AM · Frameworks

Wed, Feb 13

davidedmundson accepted D18892: Move Look and Feel KCM to top level.
Wed, Feb 13, 8:34 PM · Plasma
davidedmundson accepted D18987: Add missing dependency on KAuth.
Wed, Feb 13, 8:02 PM · Frameworks
davidedmundson added a comment to D18903: Make Appearance KCMs' labels consistent.

+1 from my side.

Wed, Feb 13, 7:57 PM · Plasma
davidedmundson added a comment to D18892: Move Look and Feel KCM to top level.

Go for it

Wed, Feb 13, 7:53 PM · Plasma
davidedmundson updated the diff for D18583: [WIP] Init ShellClient only when commited to the buffer.

With the other related patches, popups work, all unit tests pass \o/
Been using it on my machine for a day without issue.

Wed, Feb 13, 4:25 PM · KWin
davidedmundson added a comment to D18583: [WIP] Init ShellClient only when commited to the buffer.

I don't want to use AbstractClient::blockGeometryUpdates as it doesn't just call configure when it's done, it goes into setGeometry which is subtly different, especially for the code path where toplevels should choose their own size.

Wed, Feb 13, 3:17 PM · KWin
davidedmundson added a comment to D18956: [wayland] Handle sizes in ShellClient::transientPlacement.

Ready for a review I think.

Wed, Feb 13, 1:31 PM · KWin
davidedmundson updated the diff for D18956: [wayland] Handle sizes in ShellClient::transientPlacement.

remove an irrelevant change

Wed, Feb 13, 1:30 PM · KWin
davidedmundson added a reviewer for D18956: [wayland] Handle sizes in ShellClient::transientPlacement: KWin.
Wed, Feb 13, 1:28 PM · KWin
davidedmundson updated the diff for D18956: [wayland] Handle sizes in ShellClient::transientPlacement.

update

Wed, Feb 13, 12:28 PM · KWin
davidedmundson accepted D18978: [kcmkwin/kwindesktop] show only on desktop.
Wed, Feb 13, 11:40 AM · KWin
davidedmundson committed R120:9518b779ba38: libkworkspace2 (authored by davidedmundson).
libkworkspace2
Wed, Feb 13, 11:15 AM

Tue, Feb 12

davidedmundson requested review of D18965: Guard KCompressionDevice::open being called with no backend available.
Tue, Feb 12, 5:34 PM · Frameworks
davidedmundson updated the diff for D18955: [autotests] Check the configure request sent to popups.

update

Tue, Feb 12, 5:30 PM · KWin
davidedmundson added a comment to D18810: [platforms/hwcomposer] Add scaling support.

I don't want to see a config and kscreen used concurrently. We'll end up making a complex synchronization framework with a tonne of code duplication which isn't needed to solve the fairly simple issues. (ksplash should be rendering identical content on all monitors, and kwin should wait for kscreen on hotplug)

Tue, Feb 12, 4:50 PM · KWin
davidedmundson accepted D18683: Overhaul doxygen comments.
Tue, Feb 12, 4:38 PM · KWin
davidedmundson updated the title for P318 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Feb 12, 3:14 PM
davidedmundson added a dependency for D18955: [autotests] Check the configure request sent to popups: D18583: [WIP] Init ShellClient only when commited to the buffer.
Tue, Feb 12, 2:18 PM · KWin
davidedmundson added a dependent revision for D18583: [WIP] Init ShellClient only when commited to the buffer: D18955: [autotests] Check the configure request sent to popups.
Tue, Feb 12, 2:18 PM · KWin
davidedmundson committed R127:b2f67e1db7ea: Add explicit SurfaceInterface::commited signal (authored by davidedmundson).
Add explicit SurfaceInterface::commited signal
Tue, Feb 12, 2:14 PM
davidedmundson closed D18582: Add explicit SurfaceInterface::commited signal.
Tue, Feb 12, 2:14 PM · Frameworks
davidedmundson committed R127:9c95e203eae7: Add missing XdgShellPopup::ackConfigure (authored by davidedmundson).
Add missing XdgShellPopup::ackConfigure
Tue, Feb 12, 2:04 PM
davidedmundson closed D18954: Add missing XdgShellPopup::ackConfigure.
Tue, Feb 12, 2:04 PM · Frameworks
davidedmundson committed R127:6ddb12dc7304: Update copy paste error in XdgShellPopupStable member vars (authored by davidedmundson).
Update copy paste error in XdgShellPopupStable member vars
Tue, Feb 12, 2:04 PM
davidedmundson closed D18953: Update copy paste error in XdgShellPopupStable member vars.
Tue, Feb 12, 2:04 PM · Frameworks
davidedmundson committed R127:254d15fa912f: Add missing XdgShellPopup::ackConfigure (authored by davidedmundson).
Add missing XdgShellPopup::ackConfigure
Tue, Feb 12, 1:53 PM
davidedmundson committed R127:700f968b8b0e: Update copy paste error in XdgShellPopupStable member vars (authored by davidedmundson).
Update copy paste error in XdgShellPopupStable member vars
Tue, Feb 12, 1:53 PM
davidedmundson committed R127:4d16f2bf3662: Implement wl_eglstream_controller Server Interface (authored by davidedmundson).
Implement wl_eglstream_controller Server Interface
Tue, Feb 12, 1:53 PM
davidedmundson committed R127:e340aee429cf: Add explicit SurfaceInterface::commited signal (authored by davidedmundson).
Add explicit SurfaceInterface::commited signal
Tue, Feb 12, 1:53 PM
davidedmundson added a comment to D18896: [plasma-nm] Refresh wifi networks as fast as possible.

Other thing I would change is to try to repeat the scan if it fails only for the first time
then I don't think it's necessary to keep spamming NetworkManager with our requests.

Tue, Feb 12, 1:43 PM · Plasma
davidedmundson accepted D18935: [kcmkwin/kwindecoration] Fix Get Hot New Stuff.
Tue, Feb 12, 1:15 PM · KWin
davidedmundson requested review of D18957: Use natural sorting in ActivityModel.
Tue, Feb 12, 12:55 PM · Frameworks
davidedmundson committed R108:5fa18646b6b9: [autotests] Fix typo in autotest name (authored by davidedmundson).
[autotests] Fix typo in autotest name
Tue, Feb 12, 12:39 PM
davidedmundson retitled D18956: [wayland] Handle sizes in ShellClient::transientPlacement from Handle sizes in ShellClient::transientPlacement to [wayland] Handle sizes in ShellClient::transientPlacement.
Tue, Feb 12, 12:23 PM · KWin
davidedmundson requested review of D18956: [wayland] Handle sizes in ShellClient::transientPlacement.
Tue, Feb 12, 12:21 PM · KWin
davidedmundson requested review of D18955: [autotests] Check the configure request sent to popups.
Tue, Feb 12, 12:09 PM · KWin
davidedmundson requested review of D18954: Add missing XdgShellPopup::ackConfigure.
Tue, Feb 12, 12:07 PM · Frameworks
davidedmundson requested review of D18953: Update copy paste error in XdgShellPopupStable member vars.
Tue, Feb 12, 12:03 PM · Frameworks

Mon, Feb 11

davidedmundson added a comment to D18570: EGLStream DRM Backend Initial Implementation.

That was it, thank you!

Mon, Feb 11, 11:48 PM · KWin
davidedmundson created P313 (An Untitled Masterwork) in the S1 KDE Community space.
Mon, Feb 11, 11:40 PM
davidedmundson added a comment to D18890: Add button to reset index database and repair Baloo crashing.

If we know the DB is corrupted, and it's just a cache, why do we need a user facing button?

Mon, Feb 11, 7:35 PM · Baloo, Plasma
davidedmundson added inline comments to D18570: EGLStream DRM Backend Initial Implementation.
Mon, Feb 11, 6:12 PM · KWin
davidedmundson accepted D18931: Make the new Window Decoration KCM translatable (patch by Victor Ryzhykh).

The KCM only changed in master.

Mon, Feb 11, 5:41 PM · KWin
davidedmundson committed R120:66b734dfc611: Drop pre Qt5.12 workarounds (authored by davidedmundson).
Drop pre Qt5.12 workarounds
Mon, Feb 11, 3:02 PM
davidedmundson closed D18514: Drop pre Qt5.12 workarounds.
Mon, Feb 11, 3:02 PM · Plasma
davidedmundson added a comment to D18893: [sddm-theme] Add buttons to username prompt to make it a full-fledged login screen alternative.

From my POV, +1 too.

Mon, Feb 11, 2:40 PM · Plasma
davidedmundson updated the diff for D18810: [platforms/hwcomposer] Add scaling support.

Set scale based on --scale argument

Mon, Feb 11, 1:50 PM · KWin
davidedmundson committed R135:6d6cb17351d1: Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface (authored by davidedmundson).
Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface
Mon, Feb 11, 12:30 PM
davidedmundson closed D18515: Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface.
Mon, Feb 11, 12:30 PM · Plasma
davidedmundson requested review of D18922: [shell] Show kactivies warning only on error.
Mon, Feb 11, 10:38 AM · Plasma
davidedmundson committed R40:25cb77bb7618: Remove unhelpful debug in applet (authored by davidedmundson).
Remove unhelpful debug in applet
Mon, Feb 11, 10:20 AM
davidedmundson added inline comments to D18809: Image Wallpaper Slideshow - display the list of images that will be shown.
Mon, Feb 11, 10:06 AM · Plasma

Sun, Feb 10

davidedmundson accepted D18458: [kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModule.
Sun, Feb 10, 11:58 AM · KWin
davidedmundson accepted D18886: Remove unused dependencies.
Sun, Feb 10, 12:13 AM · Plasma

Sat, Feb 9

davidedmundson added a comment to D18802: Fix pragma once problem with process class.

But if this works...meh, go for it.

Sat, Feb 9, 6:12 PM · Plasma
davidedmundson added a comment to D18802: Fix pragma once problem with process class.

Your comment doesn't match what the internet says about "#pragma once" (though it is a non-standard and some compilers are weird)
Two files with the same filename should be included twice.

Sat, Feb 9, 6:12 PM · Plasma
davidedmundson added a comment to D18802: Fix pragma once problem with process class.

@mart commit message updated, @alexeymin I believe that you'll find the answer for this question in my new commit message :)

Sat, Feb 9, 3:46 PM · Plasma
davidedmundson accepted D18861: Improve the look of the Fonts KCM UI.

Perhaps "Modernize" would be a more specific word than "Improve"?

Not really. There's nothing "modern" about putting an icon on a button.

Sat, Feb 9, 2:27 PM · Plasma
davidedmundson updated the diff for D18583: [WIP] Init ShellClient only when commited to the buffer.

Rebase and cleanup

Sat, Feb 9, 12:26 PM · KWin
davidedmundson updated the diff for D18583: [WIP] Init ShellClient only when commited to the buffer.

New simpler approach.

Sat, Feb 9, 12:20 PM · KWin
davidedmundson added a comment to D18861: Improve the look of the Fonts KCM UI.

Please use more descriptive messages than "Improve the blahblah".
Practically every single commit aims to improve the product.

Sat, Feb 9, 11:21 AM · Plasma

Fri, Feb 8

davidedmundson added a comment to T10462: Defining output-input usage patterns.

Change window placement strategy, decoration visibility and other properties accordingly

Fri, Feb 8, 5:44 PM · KWin
davidedmundson requested changes to D18836: Make the button tooltips on the "Configure Virtual Desktops" page translatable.

, but it seems harmless enough to add the domain.

Fri, Feb 8, 4:32 PM · KWin
davidedmundson added a comment to D18810: [platforms/hwcomposer] Add scaling support.

Reading out the env variable in startplasmamobile sounds fine

Fri, Feb 8, 3:45 PM · KWin