Feed Advanced Search

Today

davidedmundson added inline comments to D20806: Add HiDPI support.
Thu, Apr 25, 1:36 PM
davidedmundson accepted D20805: [Window Thumbnail] Also monitor scene visibility and clean up.
Thu, Apr 25, 12:24 PM · Frameworks
davidedmundson added a comment to D20804: RFC: Try getting the X keyboard grab multiple times.

Shouldn't this and the above function name start with small letter?

Thu, Apr 25, 11:53 AM · Plasma
davidedmundson requested review of D20804: RFC: Try getting the X keyboard grab multiple times.
Thu, Apr 25, 10:29 AM · Plasma
davidedmundson committed R108:aa11e4f77726: Avoid duplicating screensaver interface definition file (authored by davidedmundson).
Avoid duplicating screensaver interface definition file
Thu, Apr 25, 12:07 AM
davidedmundson closed D20764: Avoid duplicating screensaver interface definition file.
Thu, Apr 25, 12:07 AM · KWin
davidedmundson committed R108:d3275784a85d: Don't rescale every output every time outputs change (authored by apol).
Don't rescale every output every time outputs change
Thu, Apr 25, 12:07 AM
davidedmundson committed R108:c4ab88561684: Initialise XdgOutput properties on creation (authored by davidedmundson).
Initialise XdgOutput properties on creation
Thu, Apr 25, 12:07 AM
davidedmundson closed D20521: Don't rescale every output every time outputs change.
Thu, Apr 25, 12:07 AM · KWin
davidedmundson closed D20800: Initialise XdgOutput properties on creation.
Thu, Apr 25, 12:07 AM · KWin

Yesterday

davidedmundson accepted D20588: Refactor getters in OutputScreens.
Wed, Apr 24, 11:52 PM · KWin
davidedmundson accepted D20777: Delete noop code.
Wed, Apr 24, 11:50 PM · KWin
davidedmundson updated the diff for D20521: Don't rescale every output every time outputs change.

Simplify

Wed, Apr 24, 11:37 PM · KWin
davidedmundson commandeered D20521: Don't rescale every output every time outputs change.
Wed, Apr 24, 11:32 PM · KWin
davidedmundson requested review of D20800: Initialise XdgOutput properties on creation.
Wed, Apr 24, 11:31 PM · KWin
davidedmundson accepted D18496: [wayland] Make clients with forced minimize state unminimizeable.
Wed, Apr 24, 11:08 PM · KWin
davidedmundson accepted D19000: Send axis_source, axis_discrete, and axis_stop.
Wed, Apr 24, 11:07 PM · KWin
davidedmundson committed R858:06ea48cd5d4a: Avoid nesting Controls in TextField (authored by davidedmundson).
Avoid nesting Controls in TextField
Wed, Apr 24, 8:47 PM
davidedmundson closed D20792: Avoid nesting Controls in TextField.
Wed, Apr 24, 8:47 PM · Plasma
davidedmundson requested review of D20792: Avoid nesting Controls in TextField.
Wed, Apr 24, 5:16 PM · Plasma
davidedmundson accepted D20787: process: add support for cgroups.
Wed, Apr 24, 4:50 PM · Plasma
davidedmundson accepted D20255: Improve behavior of rotated displays.
Wed, Apr 24, 4:48 PM · KWin
davidedmundson added a comment to D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer.

I proposed to swap Notifications and Active layers, and let plasmashell be in charge what notifications have to be displayed and when, i.e.

Wed, Apr 24, 3:27 PM · KWin
davidedmundson added a comment to D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer.

I'm going to act as translator as you two are going in circles.

Wed, Apr 24, 3:13 PM · KWin
davidedmundson added a comment to D20645: process: add NoNewPrivileges.

Do you have KDE commit access?

Wed, Apr 24, 2:04 PM · Plasma
davidedmundson added a comment to D20787: process: add support for cgroups.

Thanks

Wed, Apr 24, 2:03 PM · Plasma
davidedmundson accepted D20645: process: add NoNewPrivileges.
Wed, Apr 24, 8:37 AM · Plasma

Tue, Apr 23

davidedmundson accepted D20778: Use AbstractClient::Position instead of Client::Position.
Tue, Apr 23, 11:03 PM · KWin
davidedmundson accepted D19879: Make Compositor::finish more generic.
Tue, Apr 23, 7:47 PM · KWin
davidedmundson updated subscribers of D20746: Remove disable for showing only minimized tasks on Icons only task manager.

The original code is pretty clear, this isn't just a bugfix over what the author originally intended, so we need to understand that first.

Tue, Apr 23, 4:38 PM · Plasma
davidedmundson added a comment to D20640: WIP: [scripting] Port to QJSEngine.
Tue, Apr 23, 4:17 PM · KWin
davidedmundson accepted D20707: Fix corner screen glows that suddenly pop up.
Tue, Apr 23, 4:04 PM · KWin
davidedmundson accepted D20196: Add Notify capability to KConfigXT.
Tue, Apr 23, 11:10 AM · Frameworks
davidedmundson committed R107:373560712f1a: add test (authored by davidedmundson).
add test
Tue, Apr 23, 10:43 AM
davidedmundson committed R107:1de41d3fbcca: Add readme explaining how kwallet-pam works (authored by davidedmundson).
Add readme explaining how kwallet-pam works
Tue, Apr 23, 10:43 AM
davidedmundson requested review of D20764: Avoid duplicating screensaver interface definition file.
Tue, Apr 23, 8:24 AM · KWin

Mon, Apr 22

davidedmundson added a comment to D20640: WIP: [scripting] Port to QJSEngine.

In all three cases I'm worried about reply arguments, e.g. if there is any QDBusVariant reply argument, we have to unwrap it.

Mon, Apr 22, 3:25 PM · KWin
davidedmundson added a comment to D18624: [rfc] [wayland] Send a configure event when the resize is complete.

I had a comment left that I hadn't submitted :/

Mon, Apr 22, 11:43 AM · KWin
davidedmundson added a comment to D20730: Change default window actions modifier key to Meta.

See also 399375

Mon, Apr 22, 10:43 AM · KWin
davidedmundson requested changes to D20730: Change default window actions modifier key to Meta.

You can't break the behaviour for every KDE user.

Mon, Apr 22, 10:40 AM · KWin
davidedmundson accepted D20723: [scenes/opengl] Ensure there is current OpenGL context when destroying EffectFrame unstyled texture.
Mon, Apr 22, 9:09 AM · KWin

Sun, Apr 21

davidedmundson accepted D20622: Initialise the orientation sensor at start.
Sun, Apr 21, 10:09 PM · KWin
davidedmundson accepted D20564: Rename colorful user gallery avatar.

So this isn't trying to have any behavioural changes?

Sun, Apr 21, 7:09 PM · Plasma
davidedmundson added a comment to D20709: [kcmkwin/kwindecoration] Use correct defaults and reset button icons in window decorations configuration window.

My fix is only in Qt 5.13. Plasma won't depend on that for at least 6 months.

Sun, Apr 21, 4:18 PM · KWin

Sat, Apr 20

davidedmundson requested changes to D20564: Rename colorful user gallery avatar.

For future, the commit message is important.

Sat, Apr 20, 11:21 PM · Plasma

Thu, Apr 18

davidedmundson added a comment to D20656: Plotter: Scope GL Program to lifespan of scenegraph node.

Thanks, this fixes the plasma crash on resume.

Thu, Apr 18, 4:22 PM · Frameworks
davidedmundson committed R296:0aab7d23a2ce: Plotter: Scope GL Program to lifespan of scenegraph node (authored by davidedmundson).
Plotter: Scope GL Program to lifespan of scenegraph node
Thu, Apr 18, 4:14 PM
davidedmundson closed D20656: Plotter: Scope GL Program to lifespan of scenegraph node.
Thu, Apr 18, 4:14 PM · Frameworks
davidedmundson accepted D20659: Copy container in Component::cleanUp before interating.
Thu, Apr 18, 1:14 PM · Frameworks
davidedmundson accepted D20661: [MPRIS Data Engine] Avoid blocking calls when changing volume.
Thu, Apr 18, 1:01 PM · Plasma
davidedmundson accepted D20652: [libkwineffects] Bump api version.
Thu, Apr 18, 10:20 AM · KWin
davidedmundson added a reviewer for D20656: Plotter: Scope GL Program to lifespan of scenegraph node: dfaure.
Thu, Apr 18, 10:18 AM · Frameworks
davidedmundson requested review of D20656: Plotter: Scope GL Program to lifespan of scenegraph node.
Thu, Apr 18, 10:17 AM · Frameworks
davidedmundson added a comment to D20645: process: add NoNewPrivileges.

FYI, you can update an old phabricator request with new changes. Arc should should do it automatically if the phabricator line is in the commit message.

Thu, Apr 18, 9:02 AM · Plasma

Wed, Apr 17

davidedmundson added a comment to D20583: process: add NoNewPrivileges.

Is NoNewPriveleges static for the lifespan of the process?

Wed, Apr 17, 5:50 PM · Plasma
davidedmundson accepted D20631: Support CriticalNotification window type.
Wed, Apr 17, 5:37 PM · Plasma
davidedmundson added a comment to D20628: Add CriticalNotification window type to PlasmaShellSurface protocol.

if (wl_proxy_get_version(d->surface) < ORG_KDE_PLASMA_SURFACE_ROLE_CRITICALNOTIFICATION_SINCE_VERSION) {
//handle error code
}

Wed, Apr 17, 11:30 AM · Frameworks
davidedmundson accepted D20621: [effects/screenedge] Support "hint-stretch-borders".

At some point it would be good to use the Plasma FrameSVG import. That does tiling and stretching all on the GPU in the render instead of creating giant pixmaps.
There's another hint "hint-compose-over-border" which I don't want duplicating, because it's mental.

Wed, Apr 17, 10:52 AM · KWin

Tue, Apr 16

davidedmundson updated the diff for D20595: Implement set_window_geometry.

update

Tue, Apr 16, 9:09 AM · Frameworks
davidedmundson added a comment to D20595: Implement set_window_geometry.

What about xdg_shell_unstable_v6?

Tue, Apr 16, 9:09 AM · Frameworks
davidedmundson requested review of D20595: Implement set_window_geometry.
Tue, Apr 16, 7:58 AM · Frameworks
davidedmundson accepted D20592: Set correct kwalletd_bin_path.
Tue, Apr 16, 7:32 AM · Frameworks
davidedmundson added a comment to D20283: [RFC] [SimpleKCM] Fix height calculation.
Tue, Apr 16, 1:02 AM · Frameworks

Mon, Apr 15

davidedmundson added a comment to D20445: signalplotter: Add highdpi support.

To avoid artifacts when painting beams.

Mon, Apr 15, 11:58 PM · Plasma
davidedmundson accepted D20590: Move Unmanaged-specific hack away from Toplevel::setupCompositing.
Mon, Apr 15, 11:51 PM · KWin
davidedmundson accepted D20587: Remove redundant AbstractOutput::internal() method.
Mon, Apr 15, 11:50 PM · KWin
davidedmundson added a comment to D16648: Open externally called files/directories in new tabs.

activateWindow works if and only if your X startup info is correct.

Mon, Apr 15, 2:02 PM · Dolphin
davidedmundson added a comment to D20572: RFC: Add .clang-format.

Reviewing such changes gets a bit tedious for both code reviewer and patch author.

Mon, Apr 15, 1:44 PM · KWin
davidedmundson updated the title for P371 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Mon, Apr 15, 1:40 PM
davidedmundson added a comment to D20569: RFC: Use more compact OSD.

Umm, just took that from the old code. What's the alternative? I guess I can just do width then without taking into acount panels

Mon, Apr 15, 1:11 PM · Plasma
davidedmundson accepted D15423: System settings: make date/time format preview consistent.
Mon, Apr 15, 10:11 AM · Plasma
davidedmundson added a comment to D20569: RFC: Use more compact OSD.

I'd like us to get in the habbit of putting new designs of theme changes on the store before we change defaults.

Mon, Apr 15, 9:12 AM · Plasma
davidedmundson added inline comments to D20521: Don't rescale every output every time outputs change.
Mon, Apr 15, 8:34 AM · KWin
davidedmundson accepted D20562: Use (better) path to libICE when doing check_library_exists..
Mon, Apr 15, 8:21 AM · Plasma
davidedmundson accepted D20568: [effects/fallapart] Don't animate popups.
Mon, Apr 15, 8:09 AM · KWin

Sun, Apr 14

davidedmundson accepted D20561: [analog-clock] Render hand also smooth during animation.
Sun, Apr 14, 10:32 PM · Plasma
davidedmundson added a comment to D20521: Don't rescale every output every time outputs change.

concept makes sense ++
One question below.

Sun, Apr 14, 9:53 PM · KWin
davidedmundson accepted D20510: SvgItem, IconItem: drop "smooth" property override, update node on change.
Sun, Apr 14, 5:38 PM · Frameworks

Fri, Apr 12

davidedmundson added a comment to D17410: Add alternatives button to applet configuration in panel edit mode.

Toolbutton should be able to take a qicon as a source

Fri, Apr 12, 5:23 PM · VDG, Plasma
davidedmundson committed R242:83d85dc2288c: Add invokable public API for emitting contextualActionsAboutToShow (authored by davidedmundson).
Add invokable public API for emitting contextualActionsAboutToShow
Fri, Apr 12, 2:47 PM
davidedmundson closed D20417: Add invokable public API for emitting contextualActionsAboutToShow.
Fri, Apr 12, 2:47 PM · Frameworks
davidedmundson added a comment to D17410: Add alternatives button to applet configuration in panel edit mode.

It currently returns a QIcon, but I want the name/source of it from QML.

Fri, Apr 12, 2:46 PM · VDG, Plasma
davidedmundson added a comment to D18824: Implement wl_eglstream_controller Server Interface.

Now it just fails silently on bind. Why is it ok to fail silently on bind?

Fri, Apr 12, 2:40 PM · Frameworks
davidedmundson accepted D18824: Implement wl_eglstream_controller Server Interface.
Fri, Apr 12, 2:16 PM · Frameworks

Thu, Apr 11

davidedmundson added a comment to D19714: Fixes crash when closing with Detailed Memory Information open.

I don't have webkit built, so can't test this, but I have one concern:

Thu, Apr 11, 6:10 PM · Plasma
davidedmundson added a comment to D20007: Add GetProcessList for retrieving the list of currently active processes.

Looks good to me. \o/
Hopefully a windows person can test soon.

Thu, Apr 11, 5:52 PM · Frameworks
davidedmundson added a comment to T10783: Right-click on touch.

Writing out GB_2's "do it like windows" in words:

Thu, Apr 11, 2:20 PM · Plasma, VDG
davidedmundson added a comment to T10783: Right-click on touch.

two-finger tap?

Thu, Apr 11, 2:09 PM · Plasma, VDG

Wed, Apr 10

davidedmundson abandoned D13266: Set RTL supported by default on QtQuick KCMs.
Wed, Apr 10, 11:38 PM · Frameworks
davidedmundson abandoned D18344: Make use of doxygen markers consistent in AbstractClient.
Wed, Apr 10, 11:36 PM · KWin
davidedmundson accepted D18570: EGLStream DRM Backend Initial Implementation.

There might be some more issues to fix as we go along, but from a technical POV this is fine - lets get this in and we can iterate in-tree.

Wed, Apr 10, 11:15 PM · KWin
davidedmundson accepted D20455: [qpa] Don't specify EGL_SURFACE_TYPE when choosing EGLConfig.

Thanks

Wed, Apr 10, 11:14 PM · KWin
davidedmundson added a comment to D17410: Add alternatives button to applet configuration in panel edit mode.

GB2 do you want to commandeer it back and make those changes?

Wed, Apr 10, 10:48 PM · VDG, Plasma
davidedmundson accepted D20213: [kcolorschemeeditor] Use config path instead of searching again.
Wed, Apr 10, 8:11 PM · Plasma
davidedmundson accepted D20436: No need to set height to implicitHeight.
Wed, Apr 10, 7:48 PM · Plasma

Tue, Apr 9

davidedmundson added a comment to D20265: Introduce libnotificationmanager.

Then we can't use it.

Tue, Apr 9, 11:14 PM · Plasma
davidedmundson added a comment to D20265: Introduce libnotificationmanager.

It's a big review :/

Tue, Apr 9, 10:34 PM · Plasma
davidedmundson updated the summary of D17410: Add alternatives button to applet configuration in panel edit mode.
Tue, Apr 9, 9:21 PM · VDG, Plasma
davidedmundson requested review of D20417: Add invokable public API for emitting contextualActionsAboutToShow.
Tue, Apr 9, 9:16 PM · Frameworks
davidedmundson updated the diff for D17410: Add alternatives button to applet configuration in panel edit mode.

fix TODO

Tue, Apr 9, 9:13 PM · VDG, Plasma