Install .desktop file for kded5
ClosedPublic

Authored by davidedmundson on Mar 22 2019, 11:00 PM.

Details

Summary

This is useful as on wayland setting a path to a desktop file is
mandatory for icons on any windows. Qt sets the app_id to org.kde.kde5
but this desktop file doesn't exist.

We do a similar fix in plasmashell and other services that don't really
map to the traditional application pattern.

I set the type to something other than Application so we don't have to
put an Exec line though it wouldn't really matter as it's hidden anway.

BUG: 387556

Test Plan

Opened a vault
Got an icon

Diff Detail

Repository
R297 KDED
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 22 2019, 11:00 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 22 2019, 11:00 PM
ivan accepted this revision.Mar 22 2019, 11:03 PM
This revision is now accepted and ready to land.Mar 22 2019, 11:03 PM
This revision was automatically updated to reflect the committed changes.
dfaure added a subscriber: dfaure.May 18 2019, 9:09 PM
dfaure added inline comments.
org.kde.kded5.desktop
4

What does SystemService mean?

I'm seeing a warning from the kservice framework:
The desktop entry file "<prefix>/share/applications/org.kde.kded5.desktop" has Type= "SystemService" instead of "Application" or "Service".

Would it be ok to use Service instead, or does SystemService have a special meaning on wayland?