I think we should be using a monochrome icon here. An equivalent monochrome icon would be favorite, but I don't think "favorite" is a good symbol for "alternatives". Maybe preferences-other or application-menu (same icon) would be good? It might be outside the scope of this patch anyway since this means the alternatives icon needs to be changed outside the edit mode as well.

In D17410#373011, @ndavis wrote:

I think we should be using a monochrome icon here.

I agree.

In D17410#373011, @ndavis wrote:

It might be outside the scope of this patch anyway since this means the alternatives icon needs to be changed outside the edit mode as well.

Exactly. For now, let's follow the existing pattern, and make that change in another patch.

Neat, it seems to generally work well. I notice that when I click the new menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we could make it not do that, so it would stay in panel edit mode if invoked while in panel edit mode.

In D17410#373036, @ngraham wrote:

Neat, it seems to generally work well. I notice that when I click the new menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we could make it not do that, so it would stay in panel edit mode if invoked while in panel edit mode.

I can't find where that is implemented and I think it shouldn't be included here, because it exits the panel edit mode when it looses its focus.

In general +++

We need to fix that TODO. I added some rough notes, give that a go, it'll involve reading the C++ and seeing how that all ties together with the QML.

If you get stuck, comment here.

I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work...

I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work...

Use console.log to check your code is being called at the right time.
Also search for contextualActionsAboutToShow in other code and then you'll have a reference you can copy.

In D17410#374062, @davidedmundson wrote:

I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work...

Use console.log to check your code is being called at the right time.
Also search for contextualActionsAboutToShow in other code and then you'll have a reference you can copy.

It is being called at the right time (I can see the output):

onVisualParentChanged: {
    if (visualParent) {
        ...
        console.log("Call contextualActionsAboutToShow");
        currentApplet.applet.contextualActionsAboutToShow();
    }
}

And it should only show the button if there are specific alternatives:

PlasmaComponents.ToolButton {
    id: alternativesButton
    ...
    visible: currentApplet.applet.action("alternatives").visible
    ...
}

But it doesn't work, it prints out Cannot read property 'applet' of null and currentApplet.applet.action("alternatives").visible is always false.

Cannot read property 'applet' of null

Which means currentApplet is null.

When is that set? Were you checking if it was visible afterwards?

It seems like this is quite difficult, me and @broulik couldn't figure it out. If someone wants to take over this revision then please do it.

Ping, would be great if we could have this for 5.16.

This icon have a lot of details for this small size we need more clear one I guess

In D17410#446874, @Codezela wrote:

This icon have a lot of details for this small size we need more clear one I guess

The icon was added here: D20367
I think it's still ok, but we can discuss how it can be changed in that revision or the KDE VDG chat channel.

Nice, it works great!

Nice, thank you so much!

And actually maybe we could programmatically get the name and icon from the action itself, like the Task Manager does:

property QtObject alternativesAction: null

enabled: alternativesAction && alternativesAction.enabled
visible: alternativesAction && alternativesAction.visible

text: alternativesAction ? alternativesAction.text : ""
icon: alternativesAction ? alternativesAction.icon : ""

GB2 do you want to commandeer it back and make those changes?

BTW, @davidedmundson or someone else:
How do I get the icon name/source here: iconSource: plasmoid.action("alternatives").icon?
It currently returns a QIcon, but I want the name/source of it from QML.

It currently returns a QIcon, but I want the name/source of it from QML.

What for?

In D17410#448756, @davidedmundson wrote:

It currently returns a QIcon, but I want the name/source of it from QML.

What for?

So I can use the same icon that is in the context menu

in the toolbutton icon source/name property.

Toolbutton should be able to take a qicon as a source

In D17410#448842, @davidedmundson wrote:

Toolbutton should be able to take a qicon as a source

Nope, when I use iconSource: plasmoid.action("alternatives").icon this happens:
ConfigOverlay.qml:392:21: Unable to assign QIcon to QString

It seems like Elisa has a function to do this: https://lxr.kde.org/source/extragear/multimedia/elisa/src/elisaapplication.h#0083
Maybe something like this could be added to KDE/Plasma Frameworks?

Or we could just leave it how it is now.

Ping