use plasma icon as icon for plasma notification category
ClosedPublic

Authored by sitter on Apr 1 2019, 3:36 PM.

Details

Summary

kde is the kde logo, start-here-kde is our app menu icon which is the
plasma icon

Test Plan

icon lovely now

Diff Detail

Repository
R252 Framework Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Apr 1 2019, 3:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 1 2019, 3:36 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Apr 1 2019, 3:36 PM
sitter added a comment.Apr 1 2019, 3:36 PM

before

after

sitter retitled this revision from use the plasma icon as plasma icon to use plasma icon as icon for plasma notification category.Apr 1 2019, 3:36 PM
sitter added a comment.Apr 1 2019, 3:49 PM

Oh, on a related note, I actually do wonder if we should symlink start-here-kde in breeze to start-here-kde-plasma and use that instead to differentiate? As per the spec on !breeze icon themes start-here-kde-plasma would fall back to start-here-kde if the plasma icon doesn't exist IIRC. So it's just as portable but less ambiguous perhaps.

davidedmundson accepted this revision.Apr 1 2019, 3:53 PM
davidedmundson added a subscriber: davidedmundson.

Oh, on a related note, I actually do wonder if we should symlink start-here-kde in breeze to start-here-kde-plasma and use that instead to differentiate? As per the spec on !breeze icon themes start-here-kde-plasma would fall back to start-here-kde if the plasma icon doesn't exist IIRC. So it's just as portable but less ambiguous perhaps.

We should.

This revision is now accepted and ready to land.Apr 1 2019, 3:53 PM
This revision was automatically updated to reflect the committed changes.