Make disk monitor widget only show real devices by default
Needs ReviewPublic

Authored by pavelmos on Apr 3 2019, 8:23 AM.

Details

Reviewers
broulik
davidre
ngraham
mart
Group Reviewers
Plasma
Summary

Now, when the widget is first loaded, only checkboxes related to real devices in the system are enabled.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
pavelmos created this revision.Apr 3 2019, 8:23 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 3 2019, 8:23 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
pavelmos requested review of this revision.Apr 3 2019, 8:23 AM

Can you explain not what the change is doing, but why we're making it?

What happens if I'm trying to monitor a removable USB disk?

Can you explain not what the change is doing, but why we're making it?

What happens if I'm trying to monitor a removable USB disk?

Thanks for your responce!

At the moment when the widget is first loaded after installation, all the checkboxes are selected in the settings (checked = true).
Before using the diskactivity widget, the User must turn off all unnecessary settings. But such unnecessary settings may be too much. This will be inconvenient for the user.
It is necessary to make the widget display only real disk devices (not virtual, not loop or ram) by default.

The change only applies to HDD and SSD.

I hope I answered your question?

ngraham retitled this revision from Plasma-Workspace. Filtering the diskactivity widget settings upon first launch. to Make disk monitor widget only show real devices by default.Apr 3 2019, 3:06 PM
ngraham edited the summary of this revision. (Show Details)
ngraham added a subscriber: ngraham.

I've edited the title and summary to be a bit more clear. Does that help and is it accurate?

I've edited the title and summary to be a bit more clear. Does that help and is it accurate?

Yes that's right. Thanks!

Please skip this.

Oops, sorry for losing track of this. Is it replaced by something else? If you don't think it's needed anymore you can Abandon it from the Add Action... menu.

applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
43

This needs nvme and mmcblk in the list

sitter added a subscriber: sitter.Jun 11 2019, 1:05 PM