This patch adds a global shortcut (Meta+E) to launch Dolphin, just like Konsole has.
FEATURE: 405302
FIXED-IN: 19.04.0
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin VDG - Commits
- R318:58084cf7da36: Create a global launch shortcut (Meta+E)
- Apply patch and reboot, or create and log into a new user
- Hit Meta+E
- Dolphin opens!
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
+1 otherwise :)
| CMakeLists.txt | ||
|---|---|---|
| 145 | DATA_INSTALL_DIR is deprecated, please use KDE_INSTALL_DATADIR instead. | |
Comment Actions
Nice stuff :) What about adding Meta+D for showing the desktop? This is a standard shortcut for all the Windows folks out there.
Comment Actions
We don't want more stuff using khotkeys, you've seen the spectacle discussion and the move to the new kglobalaccel code.
I want this reverted.
Comment Actions
Here's the patch in spectacle: D19310
A bit of background, Plasma wants to kill khotkeys since forevers. It splits the shortcuts UI, the UI is backwards, and the extra parts that aren't shortcuts simply don't work.
Obviously we want to do that without regressions, and therefore I don't want to introduce more things that need porting.
The shortcuts UI was changed to add app launching. Systemsettings -> global shortcuts -> + -> select dolphin.
(runtime kglobalaccel part: https://phabricator.kde.org/D2103)
Apps should be able to set a default via the X-KDE-Shortcuts keyword and co-installing the .desktop file into another path.
It definitely definitely needs some docs, and maybe some code fixes, but it's got all the code.
Whilst we're at it. Konsole was patched control+alt+t https://phabricator.kde.org/D13708 this is meta + e . I don't have an opinion on which is better, but having a random mix of styles definitely isn't right.
Comment Actions
FWIW, I've no idea against the principle, just please copy the .desktop approach from that spectacle patch.
If that doesn't work on it's own, let me know and lets fix it.
Comment Actions
Sorry, I'll redo this to use KGlobalAccel, and then do Konsole too.
FWIW I would be comfortable standardizing on the convention that global shortcuts always use the Meta key.
Comment Actions
Careful with konsole, we have to do a migration as AFAIK it's been released with the khotkeys file.
KGlobalAccel is very ungraceful when it finds a conflict.