[platforms/drm] Rework ScopedDrmPointer
ClosedPublic

Authored by zzag on Mar 20 2019, 9:41 AM.

Details

Summary

Currently there is no any good reason for keeping ScopedDrmPointer;
providing our own deleter for QScopedPointer would make more sense.

Given that we already have type that acts as a scoped pointer for drm
objects we can improve it a bit and make simpler, e.g.

DrmScopedPointer<drmModeConnector> connector;

is much simpler than

ScopedDrmPointer<_drmModeConnector, &drmModeFreeConnector> connector;

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Mar 20 2019, 9:41 AM
Restricted Application added a project: KWin. · View Herald TranscriptMar 20 2019, 9:41 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Mar 20 2019, 9:41 AM
apol added a subscriber: apol.Mar 20 2019, 9:58 AM

+1 looks less error prone

zzag added a comment.Tue, Apr 9, 10:21 AM

If there are no objections, I'm going to push this.

davidedmundson accepted this revision.Tue, Apr 9, 10:36 AM
This revision is now accepted and ready to land.Tue, Apr 9, 10:36 AM
This revision was automatically updated to reflect the committed changes.