[effects] Drop Thumbnail Aside effect
AbandonedPublic

Authored by zzag on Mar 13 2019, 11:03 AM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

This effect is buggy and not maintained (we have lack of man power).

Diff Detail

Repository
R108 KWin
Branch
drop-thumbnail-aside-effect
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9521
Build 9539: arc lint + arc unit
zzag created this revision.Mar 13 2019, 11:03 AM
Restricted Application added a project: KWin. · View Herald TranscriptMar 13 2019, 11:03 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Mar 13 2019, 11:03 AM

You know this will yield negative PR, right? There will be complaints that we're becoming "GNOME-like".

zzag added a comment.Mar 13 2019, 2:44 PM

You know this will yield negative PR, right? There will be complaints that we're becoming "GNOME-like".

Well, some people say that plasma is bloated..... There is no winning side.

I suggest to think rationally instead of being strongly bipolar (e.g. if GNOME folks do that, then it's evil no matter what, etc). Yeah, dropping functionality isn't the greatest thing, but you should put yourself in developer's shoes before complaining about something.

Given that this effect is very buggy and not so many people are using it(according to support information in bug reports), I don't think that this change will cause big backlash.

+1 There's no point in keeping knowingly broken stuff around.
If we really wanted to have a feature like this we should have a proper configuration UI for it and do it properly with QtQuick similar to tabbox (window switchers).

zzag added a comment.Apr 9 2019, 10:24 AM

Are there any other objections?

This effect is buggy and not maintained (we have lack of man power).

Don't write that.

Finding something has been broken for years and no-one uses it enough to fix it or file many reports is a reasonable argument.

Saying it can be done better with a plasmoid and WindowThumbnail is also a good argument that I would support.
Though at that point we should probably do it and put it on the store first.

Saying it's laziness is not an argument.

zzag abandoned this revision.Apr 22 2019, 8:21 AM