I'm using it from 5.1 and it's great because it's not so dark, -1 from me.

In D23918#530952, @zzag wrote:

Um, I would say that's really bad code unless you use private inheritance.

You don't need virtual destructor when you don't have at least one virtual method, since you don't have at least one that method you don't want to delete object by its pointer to base. You use it to extend its functionality since that you declare objects by derived type, also you can add virtual destructor to derived class then extend with virtual methods and keep pointer to middle one. There is nothing wrong with stl containers or any other class without virtual destructor without at a virtual method.
https://onlinegdb.com/Bk9IKrc8S

In D23918#530932, @zzag wrote:

Sorry to disappoint you but that's an unwritten rule in C++ community. The main reason why one should avoid inheriting qvector or std::vector has something to do with destructors. More specifically, neither one of those container types has virtual destructor. However, you could fix that with private inheritance, which will look very ugly!

I think QTextBrowser fits better than WebEngine.

Let's commit this, it's fair small patch but it covers some unwanted crashes.

I can't test, but it should be fine.

Test plan:

That makes sense but none handle that schemes or should be responsible for that?

Fix a bunch of crashes :)

-1 to disable something without knowing the reason to not work.

It's added in D8738. Looks like a use after free issue https://phabricator.kde.org/source/kwin/browse/master/orientation_sensor.cpp$140 can be deleteLater, i think. Also DBus adaptors shouldn't be deleted, they should persist in app lifetime.

In D23389#518211, @ngraham wrote:

I can add a note for translators that this string should be kept as short as possible.

My big concern is that translated text is mainly not too big in English but in other lang. Even we change it to "Default Out" (since it has a label "Outputs").

But in settings is radio button

Why not it's a checkbox ? Make default looks big.

In D23350#516765, @ngraham wrote:

So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to fit in panel", "static icon size", and "n columns".

updateTimer uses slider value and it takes 200 ms to react, so you can sync the timer with keyboard one by increase the interval https://phabricator.kde.org/source/plasma-pa/browse/master/applet/contents/ui/ListItemBase.qml$198

Since we have 4 values on right / left, 0 should be the default one, no?

Did you commit in 19.04 branch, i still get hangs in KMail on logout in QtWebEngineCore::ProfileAdapter::~ProfileAdapter then in QtWebEngineCore::WebContentsAdapter::~WebContentsAdapter.

Use spaces instead of tabs.

It does not look correct either, the problem is that the focus on location bar is delayed and setActive(false) isn't applied, this is workaround. But we have problems on that before, exactly that part with focusIn on location bar. You should correct there but it can break something other.

https://phabricator.kde.org/source/solid/browse/master/src/solid/devices/frontend/devicemanager.cpp$301
@bruns, It's backend per thread

In D22155#488593, @ngraham wrote:

In D22155#488485, @anthonyfieroni wrote:

Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new features + bugs fix and Plasma offers LTS.

Do you have any examples of distros that do this? To my knowledge, all "LTS" style distros freeze all versions of KDE software, not just Plasma and apps.

In D22155#488497, @GB_2 wrote:

We can backport the changes in Plasma to the LTS branch though.

Renaming the icon is not quite good, if someone use newer framework and old applications / Plasma will not see an icon. That's pretty happen since framework incorporate new features + bugs fix and Plasma offers LTS.

Alternatively you can add message widget that explore double click functionality, when double click is applied it can change its message that save is applied. But rater OK/Apply became a bit pointless.

QList<KNSCore::Comment*> should be QList<shared_ptr<KNSCore::Comment>>, don't leave ownership to consumers.

it's removed in D20157

I saw filters does not compile when it compiles Karbon only, i should correct that, but i have much time now.
Edit: I investigate and it works correctly, i mislead APP_KARBON and KARBON.

In D20400#475648, @danders wrote:

In D20400#475477, @anthonyfieroni wrote:

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

If you mean export to svg here, afaics there are no page element in svg. Have I missed it?

Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.

Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right?
Full cmake command

cmake .. -DCMAKE_INSTALL_PREFIX=/usr  -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR=/usr/lib/qt5/plugins -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DBUILD_TESTING=FALSE -DPACKAGERS_BUILD=true -DBUILD_UNMAINTAINED=TRUE -DPRODUCTSET=APP_KARBON

Someone test it, code wise looks good, i plan to test it soon.

In flavor of D20400

In flavor of D20400

The change is correct to me.

In D16648#473249, @thomasp wrote:

I failed to request changes for D16648#inline-121014.
This is bound to randomly exhibit strange behaviour.

Activity id can be appended to dbus name, so it will be trivial to check.

Can we make readyItems unique_ptr?

That's not the right place do it, it should be done in ItemRetrievalManager.

dymanic_cast is expensive, prefer qobject_cast if you want to check result against nullptr, if you don't want - static_cast.

That's maybe KAuth bug or KCoreAddons one, when job fails it should have errorString. Also check jobs does not delete itself.