WIP: Load animation speed from new global animation speed controller
Needs ReviewPublic

Authored by davidedmundson on Thu, Aug 1, 10:45 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

It doesn't belong with advanced compositing settings as it's quite user
friendly, and we also want to adjust other animation speeds. May as well
do it together.

Migration is still TODO

For the compositing KCM, I was going to port it to use the new location and then
hide the slider if we're on a different desktop to Plasma.

See D22885

In the current form all compositing is still completely reinitiliased
like with the previous slider. Change notifications come in the form of
KConfigWatcher rather than our own bespoke update interface.

Test Plan

Moved new slider, minimised a window.
It still behaved as expected.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14667
Build 14685: arc lint + arc unit
davidedmundson created this revision.Thu, Aug 1, 10:45 PM
Restricted Application added a project: KWin. · View Herald TranscriptThu, Aug 1, 10:45 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Thu, Aug 1, 10:45 PM
anthonyfieroni added inline comments.
options.cpp
1105

Where this come from?

broulik added inline comments.
options.cpp
1108

Shouldn't this be 1?

zzag added a subscriber: zzag.Fri, Aug 2, 1:20 PM
zzag added inline comments.
options.cpp
1105

Window Rules KCM(kcmkwin/kwinrules) includes portions of KWin core.

1108

It shouldn't matter, but I wonder whether #endif above can be advanced a bit further.