Add global animation speed slider to workspace options KCM
Needs ReviewPublic

Authored by davidedmundson on Thu, Aug 1, 10:39 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Introduce a new config entry into kdeglobals AnimationSpeed that will
control /all/ animation speeds in kwin and plasma themes and Qt styles
and kirigami.

The value stored is a multiplier.
i.e 1 == normal speed, 0.5 = twice as fast, 2 = twice as slow.
0 is a special value meaning "disable animations"

The QML is a bit complex to represent a logarithmic slider that goes
4x, 2x, 1x, 0.5x, 0.25x, 0.125x

but still allowing a user to type arbitrary values into their config


Note @kbroulik This is reversed it from what we coded together, because
I decided it was confusing.

Needs relevant patches through the rest of the stack before merging.
Also kwin has some asserts on 0 speed animations that need addressing.

You also need an up-to-date kconfig and qqc2-desktop-style for bugfixes

Test Plan

Looked at config

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15167
Build 15185: arc lint + arc unit
davidedmundson created this revision.Thu, Aug 1, 10:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Aug 1, 10:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Thu, Aug 1, 10:39 PM
davidedmundson updated this revision to Diff 62956.EditedThu, Aug 1, 11:42 PM

update

Since we have 4 values on right / left, 0 should be the default one, no?

davidedmundson retitled this revision from Add global animation speed slider to workspace options KCM GNU nano 4.3 /tmp/edit.fd801hu0c34so8k8/new-commit Modified Add global animation speed slider to workspace options KCM to Add global animation speed slider to workspace options KCM.Fri, Aug 2, 8:15 AM
broulik added a subscriber: broulik.EditedFri, Aug 2, 10:47 AM

Why is it confusing? I find it more confusing if AnimationSpeed=0.5 means *faster* instead of "half the speed" as reading that line would suggest.
However, KWin seems to do it the same way round...

GB_2 added a subscriber: GB_2.Wed, Aug 14, 1:15 PM

Why is it confusing? I find it more confusing if AnimationSpeed=0.5 means *faster* instead of "half the speed" as reading that line would suggest.
However, KWin seems to do it the same way round...

I agree.

We agreed that code-wise a multiplier is easier but then the name of the group should be adjusted to reflect that.

rename config option and variable and property names