When you open Gemini in desktop and close the document view became empty (maybe noCleanUp should protected against) however you have no options except to close the window which crash since root document is dangling pointer (crash in isLoading() with invalid this pointer). I try to reload a document but instead touch view should be activated?
boemann danders leinir
- Group Reviewers
- R8:7743486fd5b6: [gemini] Clarify touch <-> desktop view switch
- Open a document in Gemini (another issue is templates has a protocol templates:// which is not handled any, i guess it was in framework)
- Switch to desktop view
- File -> close
Another issue is when you try to switch on desktop mode but there is no document loaded.
Well spotted. Yes, this is frankly from before i quite understood how smart pointer types worked, so... yeah, my bad, and thanks for sorting this :) As you say, there's plenty of more stuff to do, including some semi-basic interaction issues...
Fix a bunch of crashes :)
- Open calligra gemini
- Open word file
3.1 File menu -> Quit (if you make changes it ask you to save or not)
3.2 Click close button -> Quit (same behavior as 3.1)
3.3 Click X in widow border (same as 3.1)
- Switch to touch close
- Switch to desktop without view should not crash