[Gemini] Clarify deletion of document

Authored by anthonyfieroni on Aug 21 2019, 6:41 PM.



When you open Gemini in desktop and close the document view became empty (maybe noCleanUp should protected against) however you have no options except to close the window which crash since root document is dangling pointer (crash in isLoading() with invalid this pointer). I try to reload a document but instead touch view should be activated?

Test Plan
  1. Open a document in Gemini (another issue is templates has a protocol templates:// which is not handled any, i guess it was in framework)
  2. Switch to desktop view
  3. File -> close

Another issue is when you try to switch on desktop mode but there is no document loaded.

Diff Detail

R8 Calligra
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
anthonyfieroni created this revision.Aug 21 2019, 6:41 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptAug 21 2019, 6:41 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
anthonyfieroni requested review of this revision.Aug 21 2019, 6:41 PM
leinir accepted this revision.Aug 21 2019, 7:15 PM
leinir added a subscriber: leinir.

Well spotted. Yes, this is frankly from before i quite understood how smart pointer types worked, so... yeah, my bad, and thanks for sorting this :) As you say, there's plenty of more stuff to do, including some semi-basic interaction issues...

This revision is now accepted and ready to land.Aug 21 2019, 7:15 PM
anthonyfieroni updated this revision to Diff 65066.EditedAug 31 2019, 7:32 PM

Fix a bunch of crashes :)

Test plan:

  1. Open calligra gemini
  2. Open word file

3.1 File menu -> Quit (if you make changes it ask you to save or not)
3.2 Click close button -> Quit (same behavior as 3.1)
3.3 Click X in widow border (same as 3.1)

  1. Switch to touch close
  2. Switch to desktop without view should not crash
This revision was automatically updated to reflect the committed changes.