| GB_2 | |
| ngraham |
| VDG |
Hello guys,
the intro page of the system settings bothered me because it looks kind of outdated.
So I've desided to redesign it. Because this is my first contribution containing a little bit more than just "adding icons", there will be probably some issues with my code / design
Old:
New:
Dark Theme:
Other Language:
Update "less rounded corners":
Update "with plasma logo and without light rectangle":
Open systemsettings and see
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
What about removing the big settings icon
And make 2 row of recently used
center them vertically and horizontally
Or put some tooltips or shortcuts guided instead
| sidebar/package/contents/ui/introPage.qml | ||
|---|---|---|
| 98 | add in a comment a link to https://en.wikipedia.org/wiki/Relative_luminance to explain the numbers | |
| sidebar/package/contents/ui/introPage.qml | ||
|---|---|---|
| 65 | Hardcoding sizes is generally frowned upon. Partly because things are user-configurable, partly because if every dev hardcodes their own sizes we'll have an inconsistent mess everywhere. This patch has quite a few. Try and see what you can get rid of | |
| 98 | ||
| 103 | It's best to infer this from the child. | |
| sidebar/package/contents/ui/introPage.qml | ||
|---|---|---|
| 60 | Use i18n also only Plasma about me. | |
| 61 | Don't hardcode font sizes use level instead | |
overall to me looks a bit less balanced, but if VDG as a whole says it's ok, i'm fine with it. however there are some small things in the code to fix
| sidebar/package/contents/ui/introPage.qml | ||
|---|---|---|
| 65 | if it's a kirigami.heading, it should use the automatic sizes from there. | |
| 98 | right, since you are using brightness only to have a darker color, you should use Qt.darker() | |
Thanks for your feedback. I was actually lighten the background instead of darken it :)
But still, Qt.darker/Qt.lighter is much simpler!
+1 for redesigning the page a bit. What I really dislike about it right now is that there is no hover effect for the icons.
Regarding the changes here, I'm unsure about the rounded rectangle. Doesn't seem like it fits with design everywhere else.
Will comment more extensively once I test the patch though.
And yeah hardcoding should be avoided, check out the HIG pages on units.smallSpacing/units.largeSpacing and units.gridUnit.
Okay. I am using more Kirigami units now. About "KDE Plasma" vs "Plasma" I am not sure because Plasma is less known than KDE.
Regarding the round corners, I have decreased the radius a little bit. Hope it is better now? :)
+1, nice visual improvement. Needs a bit of code polishing first before it can land though. See inline comments:
| sidebar/package/contents/ui/introPage.qml | ||
|---|---|---|
| 29 | Don't hardcode values here; instead use multiples of Kirigami.Units.gridUnit (or some other defined unit) | |
| 55 | Comment not really necessary; it's obvious that this is a spacer | |
| 61 | Just use level 1, it's big enough IMO (or make the icon next to the text smaller to compensate for the smaller text size) | |
As you can see in my design, I'd not add a rectangle in the backround, it looks weird to me and less clean than before.
| sidebar/package/contents/ui/introPage.qml | ||
|---|---|---|
| 77–78 | Why move this heading out of the ColumnLayout? | |
What about a design like this?
I actually like the light rectangle more because it increase the connection between the icons. However if you think so ^^
What I don't like about your version is that there is so much empty space around the content...
The Plasma logo is a good idea tho!
Here is my new version, what do you think?
What do other people think about the light rectangle around the "frequently used" icons?
Because I am in favor of this :)
| sidebar/package/contents/ui/introPage.qml | ||
|---|---|---|
| 92 | Maybe change to "Frequently Used", so it's a header? | |
| sidebar/package/contents/ui/introPage.qml | ||
|---|---|---|
| 28 | How about Kirigami.Units.gridUnit * 3 instead? | |
