Hi everyone, really excited to see attention to the subject!

+1

+1

I've been running the version you gave me that keeps the notification on all the time. I see 2 problems:

• The notification is annoying. It's more Android saying KDE Connect is doing dark stuff than KDE Connect stating it's alive.
• I'm pretty sure the phone doesn't do power management properly when it's on (I can't confirm because I had FireChat installed and it's craziness)

Thanks!
I'm not an expert in this codebase but the change looks sound to me.

Thanks!
Can you submit the fix or should we do it for you?

Can you confirm that it still compiles properly in the cases where the class generates signals/slots/properties?

LGTM

In D9207#176322, @graesslin wrote:

I'm against a risky change here. Especially as this becomes irrelevant with Wayland.

What's the plan here?

In D9203#176293, @mwolff wrote:

Aleix, it might be a good idea to verify that this does not happen in the future again somehow.

Use the right path

Use the right variable and place

QScopedPointer won't be checking if the object has been destroyed. Are you sure it will never happen?
If so, +1.

Wow that's a lot of code gone!

Otherwise LGTM.

Cool stuff, but who will run this tool and when?

¯\_(ツ)_/¯

Remove crazy check

It's interesting how the code ends up simpler. :)

Wouldn't it be easier to have this job in Dolphin? Or it needs to be in kio to access private API?

Fix david's comment

Meh

Move to tracking parents instead of doing a look-up on every color get

I don't see where the issue in libraw is, can you see if the patching actually happened on your build?

Add again workarounds on cfitsio

In D9059#173767, @mtijink wrote:

It does not depend on the neighbourhood: iIt only works if there is exactly one paired device (even if it's not reachable). So if there are unpaired devices, it ignores them (unless you actually pass their id).

Using the name is indeed handier than the id, but I keep running the command and forget that I need to specify the id/name.

I'd like to know @albertvaka's opinion on it, I'm not that confident on the Android codebase just yet.

^^'

Mh, I'm not convinced. Doesn't buy much and requires different instantiations depending on who is in the neighbourhood.
I added the -n so you could just type the device name and it would be reasonably straightforward (in contrast to the device id).

Thanks!

Do we really need all these templates? Maybe we can make sure the file creator has a good insight of the class we are extending...

Please next time use a more descriptive commit message. ;)

Looking good! :) thanks