Details

Reviewers

Group Reviewers

Commits

R242:c318fde313fe: make packageurlinterceptor as noop as possible
R242:d0cbef14cbdd: make packageurlinterceptor as noop as possible

Summary

minimize file access during url rewrite

we still need it for accessing stuff under code/

Test Plan

plasma still loads, seems to save ~2%

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mart created this revision.Dec 3 2017, 12:29 PM

Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptDec 3 2017, 12:29 PM

Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

mart requested review of this revision.Dec 3 2017, 12:29 PM

Wow that's a lot of code gone!

src/plasmaquick/packageurlinterceptor.cpp
111–112	Only call `toString()` once, also put in a variable. Also we can use the information from the first match to do the replace so we don't have to execute the regex twice, if it's a hot path.

only toString once

mart mentioned this in D9169: port to Package::fileUrl.Dec 4 2017, 2:54 PM

ngraham added a subscriber: ngraham.Dec 4 2017, 5:07 PM

Closed by commit R242:d0cbef14cbdd: make packageurlinterceptor as noop as possible (authored by mart). · Explain WhyDec 4 2017, 7:13 PM

This revision was automatically updated to reflect the committed changes.

mart mentioned this in R242:84104aa463b1: port to Package::fileUrl.

Was pushed in a branch, not master. Reopening on phab

use kpackage_install_bundled_package

manage all cases for packages and check for file existence beforehand

make rewriting of both files and qrc work

extra warning

davidedmundson accepted this revision.Dec 18 2017, 11:51 AM

This revision is now accepted and ready to land.Dec 18 2017, 11:51 AM

Closed by commit R242:c318fde313fe: make packageurlinterceptor as noop as possible (authored by mart). · Explain WhyDec 18 2017, 12:00 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/configmodeltest.cpp (2 lines)
M			examples/shell/customcorona.cpp (2 lines)
M			src/plasmaquick/appletquickitem.cpp (16 lines)
M			src/plasmaquick/configmodel.cpp (2 lines)
M			src/plasmaquick/configview.cpp (4 lines)
M			src/plasmaquick/packageurlinterceptor.h (6 lines)
M			src/plasmaquick/packageurlinterceptor.cpp (93 lines)
M			src/scriptengines/qml/plasmoid/containmentinterface.cpp (2 lines)
M			src/scriptengines/qml/plasmoid/wallpaperinterface.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23328	ab8915b		Dec 3 2017, 12:29 PM	★	★
Diff 2	23397	ab8915b	only toString once	Dec 3 2017, 7:58 PM	★	★
Diff 3	23463	ab8915b	R242:d0cbef14cbdd9a63face2e3329dc52f5f53ccf16	Dec 4 2017, 2:07 PM	★	★
Diff 4	23490	ab8915b	- use kpackage_install_bundled_package	Dec 5 2017, 11:57 AM	★	★
Diff 5	23899	ab8915b	- manage all cases for packages and check for file existence beforehand	Dec 14 2017, 11:40 AM	★	★
Diff 6	23905	ab8915b	- make rewriting of both files and qrc work	Dec 14 2017, 12:53 PM	★	★
Diff 7	23906	ab8915b	- extra warning	Dec 14 2017, 12:59 PM	★	★
Diff 8	24065	2956419	R242:c318fde313fe14b577240479f2b34c7238d1e955	Dec 18 2017, 12:00 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d7ef445e8e04	a833703e4986	dc9cd543d4ce	Marco Martin	extra warning	Dec 14 2017, 12:59 PM
dc9cd543d4ce	9285882f44c5	58bdac9df91d	Marco Martin	make rewriting of both files and qrc work	Dec 14 2017, 12:48 PM
58bdac9df91d	dbfb7323b779	587c18e0da62	Marco Martin	manage all cases for packages and check for file existence beforehand	Dec 14 2017, 11:38 AM
587c18e0da62	fbc15610da70	ab8915bc12b4	Marco Martin	make packageurlinterceptor as noop as possible (Show More…)	Dec 14 2017, 10:16 AM

make packageurlinterceptor as noop as possible
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 24065

autotests/configmodeltest.cpp

examples/shell/customcorona.cpp

src/plasmaquick/appletquickitem.cpp

src/plasmaquick/configmodel.cpp

src/plasmaquick/configview.cpp

src/plasmaquick/packageurlinterceptor.h

src/plasmaquick/packageurlinterceptor.cpp

src/scriptengines/qml/plasmoid/containmentinterface.cpp

src/scriptengines/qml/plasmoid/wallpaperinterface.cpp

make packageurlinterceptor as noop as possibleClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 24065

autotests/configmodeltest.cpp

examples/shell/customcorona.cpp

src/plasmaquick/appletquickitem.cpp

src/plasmaquick/configmodel.cpp

src/plasmaquick/configview.cpp

src/plasmaquick/packageurlinterceptor.h

src/plasmaquick/packageurlinterceptor.cpp

src/scriptengines/qml/plasmoid/containmentinterface.cpp

src/scriptengines/qml/plasmoid/wallpaperinterface.cpp

make packageurlinterceptor as noop as possible
ClosedPublic
Actions

Revision Contents
Changeset List