Reduce the amount of spurious property changes on ColorScope

Authored by apol on Nov 20 2017, 3:39 PM.

Description

Reduce the amount of spurious property changes on ColorScope

Summary:
At the moment whenever something changed we were emitting colorGroupChanged
and then every color would recompute. This would end up being emitted
over 10 times at plasma startup so far.
This patch makes sure that the property will only be emitted if the color
group actually changes.

Test Plan:
Ran plasma, didn't notice issues.
I don't see all of the changes on the property anymore

Reviewers: Plasma, mart, davidedmundson

Reviewed By: Plasma, mart

Subscribers: davidedmundson, plasma-devel, Frameworks

Tags: Plasma, Frameworks

Differential Revision: https://phabricator.kde.org/D8917

Details

Committed
apolDec 2 2017, 11:45 AM
Reviewer
Plasma
Differential Revision
D8917: Reduce the amount of spurious property changes on ColorScope
Parents
R242:9066c232b403: [Icon Item] Emit validChanged only if it actually changed
Branches
Unknown
Tags
Unknown