Differential D9058

Fix "error activiting kdeconnectd" for kdeconnect-cli
ClosedPublic
Actions

Authored by mtijink on Nov 29 2017, 8:02 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:227e264042f9: Fix "error activiting kdeconnectd" for kdeconnect-cli
Summary

Kdeconnect-cli always displayed one or more "error activating kdeconnectd: QDBusError("", "")" messages.

This diff uses the reply of starting the kdeconnect daemon correctly, so this does not happen anymore.

Test Plan

Kdeconnect-cli and the daemon still work, but kdeconnect-cli does not show the error message anymore. I verified that if, for some reason, the daemon could not start, it does display an error.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink requested review of this revision.Nov 29 2017, 8:02 PM
mtijink created this revision.
mtijink edited the summary of this revision. (Show Details)Nov 29 2017, 8:05 PM
mtijink edited the test plan for this revision. (Show Details)
mtijink added a reviewer: KDE Connect.
apol accepted this revision.Nov 30 2017, 2:42 PM
apol added a subscriber: apol.

Thanks!

This revision is now accepted and ready to land.Nov 30 2017, 2:42 PM
Closed by commit R224:227e264042f9: Fix "error activiting kdeconnectd" for kdeconnect-cli (authored by mtijink, committed by nicolasfella). · Explain WhyDec 3 2017, 6:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Minterfaces/dbusinterfaces.cpp (4 lines)

Diff 23392

View Options

interfaces/dbusinterfaces.cpp

Loading...