mtijink (Matthijs Tijink)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 22 2017, 12:31 PM (91 w, 4 d)
Availability
Available

Recent Activity

Wed, Mar 13

mtijink committed R224:f5724f7e7cea: Add zsh device autocompletion helper (authored by mtijink).
Add zsh device autocompletion helper
Wed, Mar 13, 7:59 PM

Sun, Mar 10

mtijink requested changes to D19653: Smart keyboards support on remote input plugin.

I tried it, and although it does solve some problems with swype input, it also introduces new problems. An example is using backspace, which doesn't work anymore with your changes.

Sun, Mar 10, 12:39 PM · KDE Connect

Sat, Mar 9

mtijink committed R225:3e85dd616055: Add all missing MPRIS properties in the media session control (authored by mtijink).
Add all missing MPRIS properties in the media session control
Sat, Mar 9, 8:06 PM
mtijink committed R224:97705c3c7623: Retry the network packet if it failed to unserialize (authored by mtijink).
Retry the network packet if it failed to unserialize
Sat, Mar 9, 5:31 PM

Fri, Mar 8

mtijink abandoned D17841: Workaround for bluetooth payload transfer bugs.

Superseded by connection multiplexer work (see KDE Invent).

Fri, Mar 8, 9:29 PM · KDE Connect

Jan 19 2019

mtijink committed R224:e77c1c87ac9d: Add description of bluetooth multiplexing protocol (authored by mtijink).
Add description of bluetooth multiplexing protocol
Jan 19 2019, 1:06 PM
mtijink closed D17987: Add description of bluetooth multiplexing protocol.
Jan 19 2019, 1:06 PM · KDE Connect

Jan 10 2019

mtijink updated the diff for D17987: Add description of bluetooth multiplexing protocol.

Update to require sending of protocol version message, this makes future extensions easier to handle.

Jan 10 2019, 4:43 PM · KDE Connect

Jan 6 2019

mtijink committed R224:82cd180055f4: Bluetooth multiplexing preview code (authored by mtijink).
Bluetooth multiplexing preview code
Jan 6 2019, 7:30 PM

Jan 5 2019

mtijink requested review of D17987: Add description of bluetooth multiplexing protocol.
Jan 5 2019, 12:24 PM · KDE Connect

Dec 31 2018

mtijink committed R224:97551d09ffbb: Add handling for the identity packet to be split across two messages. (authored by mtijink).
Add handling for the identity packet to be split across two messages.
Dec 31 2018, 12:26 PM
mtijink closed D17789: Add handling for the identity packet to be split across two messages..
Dec 31 2018, 12:26 PM · KDE Connect

Dec 30 2018

mtijink added a comment to D17841: Workaround for bluetooth payload transfer bugs.

Just so you know, I initially had the payload transfer going over the existing bluetooth connection (by sending the payload transfer info followed by the payload itself), but if the payload had newline characters, then the processing got messed up (because newlines got stripped off as part of regular message processing). Also, with payloads of unknown lengths, it wouldn't be easily possible to determine the end of the payload. Therefore, I split it out to a separate connection.

Dec 30 2018, 7:00 PM · KDE Connect

Dec 28 2018

mtijink added a comment to D17841: Workaround for bluetooth payload transfer bugs.

Actually, wait a bit before reviewing this. It turns out that not all (Android) devices support multiple Rfcomm servers (currently used for transmitting payloads), so we'll need something for that too.

Dec 28 2018, 9:48 PM · KDE Connect
mtijink requested review of D17841: Workaround for bluetooth payload transfer bugs.
Dec 28 2018, 6:47 PM · KDE Connect
mtijink accepted D17789: Add handling for the identity packet to be split across two messages..

Works for me, thanks!

Dec 28 2018, 5:10 PM · KDE Connect

May 30 2018

mtijink added a comment to T7447: KDE Connect Bluetooth.

Hmm, possibly. I couldn't find out how to do this from the Android side though, do you have an idea how to do that?

May 30 2018, 5:16 PM · Kubuntu

May 29 2018

mtijink added a comment to T7447: KDE Connect Bluetooth.

Qt doesn't support receiving stuff via OBEX, so that wouldn't work for us :-( Also, I'm not sure that you can initiate transfers to a specific application.

May 29 2018, 7:03 PM · Kubuntu

May 11 2018

mtijink added a comment to D12812: Enable desktop2desktop keyboard input.

Looks sensible, but I can't test this. Consider it accepted if nobody else reviews in the coming days.

May 11 2018, 1:11 PM · KDE Connect

May 9 2018

mtijink accepted D12552: Use title, album and artist in UI.
May 9 2018, 1:27 PM · KDE Connect
mtijink accepted D12559: [WIP] Add MprisReceiverPlugin (Android).

Okay, looks good!

May 9 2018, 1:23 PM · KDE Connect

May 6 2018

mtijink added a comment to D12670: Share RemoteKeyboard implementation.

By removing this code you change behaviour: The initial idea was to not make the TextField echo immediately what has been typed, but visualize on desktop what the remote device acked via a network package. This allows for a kind of realtime confirmation of what the remote device *really* processed. Therefore the original event was not accepted and injected artificially onAckPackageReceived. This has some shortcomings, as the echoing in the TextField is incomplete with respect to the handled special keys etc.

A more complete discussion can be found in the original RR: https://git.reviewboard.kde.org/r/129727/

If one wants to keep this behaviour, IMHO the optimal solution would be to inject a real QKeyEvent to the TextField on reception of the ack-package. I played around with a thin native wrapper around QCoreApplication::postEvent() but did not succeed.

It is a design decision whether you want to stick to this echo-behaviour or simply echo immediately what was typed (what you propose here). Personally I would not have a problem with changing it, as in my everyday usage I noted that I always look on my phone when typing remotely via remotekeyboard.

May 6 2018, 12:49 PM · KDE Connect

May 1 2018

mtijink committed R225:d6c3803ea259: Add assertions and checks to album art fetch code (authored by mtijink).
Add assertions and checks to album art fetch code
May 1 2018, 5:27 PM
mtijink closed D12618: Add assertions and checks to album art fetch code.
May 1 2018, 5:27 PM · KDE Connect
mtijink added inline comments to D12618: Add assertions and checks to album art fetch code.
May 1 2018, 5:26 PM · KDE Connect
mtijink updated the test plan for D12618: Add assertions and checks to album art fetch code.
May 1 2018, 5:01 PM · KDE Connect

Apr 30 2018

mtijink added a comment to D12559: [WIP] Add MprisReceiverPlugin (Android).

I tested it, and there's still an issue: updates (e.g. after next/previous) aren't displayed in KCApp. I don't know on which side the issue is.

Did you apply D12528?

Apr 30 2018, 7:18 PM · KDE Connect
mtijink requested changes to D12559: [WIP] Add MprisReceiverPlugin (Android).

Sorry, thought of a couple of new things.

Apr 30 2018, 7:07 PM · KDE Connect
mtijink added inline comments to D7993: System volume plugin Android.
Apr 30 2018, 6:43 PM · KDE Connect
mtijink added a comment to D12552: Use title, album and artist in UI.

Turns out there are more cases to handle:

  • No title available -> show nowplaying
  • Title availabe, no artist/album available -> show title
  • title and either album or artist -> show title and either album or artist
  • title, album and artist available -> show title and artist - album

    Any hints on simplifying that logic is welcome
Apr 30 2018, 6:36 PM · KDE Connect
mtijink added a comment to D12618: Add assertions and checks to album art fetch code.

APK:

Apr 30 2018, 6:08 PM · KDE Connect
mtijink requested review of D12618: Add assertions and checks to album art fetch code.
Apr 30 2018, 6:07 PM · KDE Connect

Apr 27 2018

mtijink requested changes to D12559: [WIP] Add MprisReceiverPlugin (Android).

Generally looks quite good, but didn't test it yet.

Apr 27 2018, 12:42 PM · KDE Connect
mtijink added a comment to D12552: Use title, album and artist in UI.

What if the remote doesn't send title, artist, etc. but only nowPlaying?

Apr 27 2018, 12:08 PM · KDE Connect

Apr 26 2018

mtijink accepted D12543: Support title, artist and album in MprisRemote.
Apr 26 2018, 6:47 PM · KDE Connect

Apr 24 2018

mtijink committed R224:1b570d4719e4: Make bluetooth payload upload work & asynchronous (authored by mtijink).
Make bluetooth payload upload work & asynchronous
Apr 24 2018, 6:34 PM
mtijink closed D12264: Make bluetooth payload upload work & asynchronous.
Apr 24 2018, 6:33 PM · KDE Connect
mtijink added a comment to D7993: System volume plugin Android.

I get a delay before the UI stuff appears, probably because it's still waiting for the information to display. Would it be possible to load this in advance, like is done in the MPRIS plugin?

Apr 24 2018, 6:13 PM · KDE Connect
mtijink accepted D12345: Add marginEnd for RTL layouts.

Ah okay, makes sense!

Apr 24 2018, 5:36 PM · KDE Connect

Apr 21 2018

mtijink accepted D11694: Add a dark theme.

Looks good to me!

Apr 21 2018, 6:06 PM · KDE Connect
mtijink added a comment to D12345: Add marginEnd for RTL layouts.

Shouldn't this replace the layout_marginRight? Now we get margins on both sides?

Apr 21 2018, 6:05 PM · KDE Connect
mtijink added inline comments to D12281: Enable (de)selecting all apps in notification filter.
Apr 21 2018, 6:00 PM · KDE Connect
mtijink added a comment to D12294: Send notification actions.

I think we should also send the action icon. That might be hard at the moment though, because we can only send one payload.

For what would you use it?

Apr 21 2018, 5:52 PM · KDE Connect

Apr 17 2018

mtijink added a comment to D12294: Send notification actions.

I think we should also send the action icon. That might be hard at the moment though, because we can only send one payload.

Apr 17 2018, 6:58 PM · KDE Connect
mtijink added inline comments to D12293: Add actions to notifications.
Apr 17 2018, 6:50 PM · KDE Connect
mtijink accepted D12212: Hide Available devices section if no devices are available.

Looks good to me!

Apr 17 2018, 6:42 PM · KDE Connect
mtijink accepted D12289: Rename list layout.

Didn't test, so only consider it accepted if this is an automatic refactor.

Apr 17 2018, 6:36 PM · KDE Connect
mtijink added a comment to D12264: Make bluetooth payload upload work & asynchronous.

I'll do some more testing with the current changes, to make sure edge cases are handled correctly.

Apr 17 2018, 5:01 PM · KDE Connect
mtijink updated the diff for D12264: Make bluetooth payload upload work & asynchronous.

Make some requested changes, and better error handling

Apr 17 2018, 4:58 PM · KDE Connect
mtijink added a comment to D12285: [RFC] Change drawer header image.

Maybe the images can be combined? Or a background color? It looks a bit empty with this change.

Apr 17 2018, 4:46 PM · KDE Connect
mtijink added inline comments to D12232: Simplify failed plugin list creation.
Apr 17 2018, 4:45 PM · KDE Connect
mtijink added inline comments to D12281: Enable (de)selecting all apps in notification filter.
Apr 17 2018, 4:43 PM · KDE Connect
mtijink added a comment to D12153: Fix receiving payloads using a bluetooth connection.

Did you file a Qt bug?

Apr 17 2018, 4:41 PM · KDE Connect

Apr 16 2018

mtijink requested review of D12264: Make bluetooth payload upload work & asynchronous.
Apr 16 2018, 8:18 PM · KDE Connect
mtijink added inline comments to D12232: Simplify failed plugin list creation.
Apr 16 2018, 3:11 PM · KDE Connect
mtijink committed R225:d4d9e8ba6df5: Update DeviceHelper.java (authored by Karl Heinz <karl-heinz-1950@web.de>).
Update DeviceHelper.java
Apr 16 2018, 2:55 PM
mtijink triaged T8539: [Junior Job] Limit KDE Connect to certain (wifi) networks as Wishlist priority.
Apr 16 2018, 2:46 PM · Junior Jobs, KDE Connect

Apr 15 2018

mtijink added a comment to D12212: Hide Available devices section if no devices are available.

An empty "available devices" section does make it clear that none of the devices are available at the moment (which might be unclear with only "remembered devices"). I'd suggest only hiding it there's at least one connected device.

Apr 15 2018, 12:12 PM · KDE Connect
mtijink added a comment to D11694: Add a dark theme.

I don't like some of the new changes. I understand this is all opinions, so we can't have everything, but I think that the following things are especially bad changes:

  • The sidebar navigation should be visually distinct from the main view. In the light view, the main view is shaded and the sidebar has a drop shadow, we could do that here too. Or, if not possible, we should change the sidebar color.
  • The dark-orange toolbar doesn't match the other places where the orange color is used. I'd say they should be different hues or be exactly the same color. So either bright orange or black-ish, as @nicolasfella suggested.
Apr 15 2018, 12:10 PM · KDE Connect

Apr 12 2018

mtijink abandoned D12073: Fix crash on remote keyboard initialisation.

Doesn't solve the issue.

Apr 12 2018, 5:23 PM · KDE Connect
mtijink requested review of D12153: Fix receiving payloads using a bluetooth connection.
Apr 12 2018, 5:06 PM · KDE Connect

Apr 9 2018

mtijink added a comment to T8374: USB Backend.

It would be even better if we could prompt the user to pair from the device plugin, when the user plugs the usb in for the first time.

Apr 9 2018, 7:14 PM · KDE Connect
mtijink committed R225:2cd7d4b7a99a: Fix default Find My Phone ringtone (authored by mtijink).
Fix default Find My Phone ringtone
Apr 9 2018, 5:02 PM
mtijink closed D12070: Fix default Find My Phone ringtone.
Apr 9 2018, 5:02 PM · KDE Connect
mtijink added a comment to D12070: Fix default Find My Phone ringtone.

Thanks, sadly it's too late for 1.3 :(
IMHO this should be part of a 1.3.1 release because it breaks the feature by default

Apr 9 2018, 5:00 PM · KDE Connect
mtijink added a comment to D12073: Fix crash on remote keyboard initialisation.

APK for testing this diff:

Apr 9 2018, 4:54 PM · KDE Connect
mtijink requested review of D12073: Fix crash on remote keyboard initialisation.
Apr 9 2018, 4:52 PM · KDE Connect
mtijink added a comment to D11694: Add a dark theme.

I think it's fine either way, so whatever @nicolasfella thinks 😃

Apr 9 2018, 4:15 PM · KDE Connect
mtijink requested review of D12070: Fix default Find My Phone ringtone.
Apr 9 2018, 4:06 PM · KDE Connect

Apr 7 2018

mtijink added inline comments to D11698: (WIP) Upgrade Telephony plugin to read SMS history (Android side).
Apr 7 2018, 8:16 AM · KDE Connect
mtijink added a comment to D11773: New plugin: Find this device.

I can't test it, but it looks good.

Apr 7 2018, 8:10 AM · KDE Connect

Mar 30 2018

mtijink added a comment to D11773: New plugin: Find this device.

Wouldn't it make more sense to integrate this into the existing "Find my phone" plugin?

Perhaps. Depends if people think there are devices which would just be searched *for* or devices which are just searched *from*. In that case one might prefer to have the plugins separated, as proposed initially here.

For one, any mobile device is candidate both for being searched for and searched from, given their mobile nature :)
On the other hand, not any connected device and its users should be able to trigger the Find feature for any other connected device (think device for visitors/kids which should not be able to locate host's/mum's phone, but the other way around you want to be able).

That's why I proposed this as separate plugin, to allow separate enabling in which direction the Find feature works.

Mar 30 2018, 4:06 PM · KDE Connect

Mar 29 2018

mtijink accepted D11694: Add a dark theme.

Works nicely, thanks!

Mar 29 2018, 8:35 PM · KDE Connect
mtijink requested changes to D9690: Add contacts-reading plugin (Android side).

The code generally looks good to me! I added a few comments.

Mar 29 2018, 8:01 PM · KDE Connect
mtijink added inline comments to D9691: Add contacts-reading plugin (KDE side).
Mar 29 2018, 7:45 PM · KDE Connect
mtijink added a comment to D11773: New plugin: Find this device.

Wouldn't it make more sense to integrate this into the existing "Find my phone" plugin?

Mar 29 2018, 7:20 PM · KDE Connect
mtijink added a comment to D11694: Add a dark theme.

I can't apply the patch cleanly, and it seems as if you removed all previous changes, only adding the newest update.

Mar 29 2018, 7:18 PM · KDE Connect

Mar 28 2018

mtijink committed R225:94ef1294c572: Add share action button to received file notification (authored by mtijink).
Add share action button to received file notification
Mar 28 2018, 8:58 PM
mtijink closed D11680: Add share action button to received file notification.
Mar 28 2018, 8:58 PM · KDE Connect

Mar 27 2018

mtijink updated the diff for D11680: Add share action button to received file notification.

Move code in both if/else branch outside if

Mar 27 2018, 7:24 PM · KDE Connect
mtijink committed R225:7c8301a7ccd8: Disables album art download on metered connections (e.g. 4G) (authored by mtijink).
Disables album art download on metered connections (e.g. 4G)
Mar 27 2018, 7:23 PM
mtijink closed D11682: Disables album art download on metered connections (e.g. 4G).
Mar 27 2018, 7:23 PM · KDE Connect
mtijink added a comment to D11694: Add a dark theme.

Some icons not yet themed correctly:

  • The exclamation icon when you select a paired, but unconnected device
  • The volume icon in the MPRIS activity
Mar 27 2018, 7:20 PM · KDE Connect
mtijink added inline comments to D11698: (WIP) Upgrade Telephony plugin to read SMS history (Android side).
Mar 27 2018, 7:06 PM · KDE Connect
mtijink added a comment to D9691: Add contacts-reading plugin (KDE side).

Same here.

Mar 27 2018, 7:00 PM · KDE Connect
mtijink added a comment to D9690: Add contacts-reading plugin (Android side).

The diff doesn't appear correctly either, right? Maybe it's because the code already is in a branch?

Mar 27 2018, 6:59 PM · KDE Connect
mtijink added a comment to D7992: Add systemvolume plugin.

The code looks good. I'll test once the Android side is done.

Mar 27 2018, 6:51 PM · KDE Connect

Mar 25 2018

mtijink requested review of D11682: Disables album art download on metered connections (e.g. 4G).
Mar 25 2018, 1:48 PM · KDE Connect
mtijink committed R225:00b6677aa406: When receiving a file Android, show the image in the notification (authored by mtijink).
When receiving a file Android, show the image in the notification
Mar 25 2018, 12:51 PM
mtijink closed D11679: When receiving a file Android, show the image in the notification.
Mar 25 2018, 12:51 PM
mtijink added inline comments to D7993: System volume plugin Android.
Mar 25 2018, 12:50 PM · KDE Connect
mtijink requested review of D11680: Add share action button to received file notification.
Mar 25 2018, 12:44 PM · KDE Connect
mtijink requested review of D11679: When receiving a file Android, show the image in the notification.
Mar 25 2018, 12:33 PM
mtijink committed R224:33c2a100b1cc: Support file url album art - Desktop (authored by mtijink).
Support file url album art - Desktop
Mar 25 2018, 11:45 AM
mtijink closed D11017: Support file url album art - Desktop.
Mar 25 2018, 11:45 AM
mtijink committed R225:bf0cab9ef296: Support file url album art - Android (authored by mtijink).
Support file url album art - Android
Mar 25 2018, 11:41 AM
mtijink closed D11018: Support file url album art - Android.
Mar 25 2018, 11:41 AM · KDE Connect
mtijink committed R225:1c3e6f84a75e: Add album art to media notification and lock screen (authored by mtijink).
Add album art to media notification and lock screen
Mar 25 2018, 11:39 AM
mtijink closed D10798: Add album art to media notification and lock screen.
Mar 25 2018, 11:39 AM
mtijink claimed T8287: Add share button to filereceive notification.
Mar 25 2018, 11:28 AM · KDE Connect