- User Since
- Jun 22 2017, 12:31 PM (82 w, 5 d)
Sat, Jan 19
Thu, Jan 10
Update to require sending of protocol version message, this makes future extensions easier to handle.
Sun, Jan 6
Sat, Jan 5
Mon, Dec 31
Sun, Dec 30
Fri, Dec 28
Actually, wait a bit before reviewing this. It turns out that not all (Android) devices support multiple Rfcomm servers (currently used for transmitting payloads), so we'll need something for that too.
Works for me, thanks!
May 30 2018
Hmm, possibly. I couldn't find out how to do this from the Android side though, do you have an idea how to do that?
May 29 2018
Qt doesn't support receiving stuff via OBEX, so that wouldn't work for us :-( Also, I'm not sure that you can initiate transfers to a specific application.
May 11 2018
Looks sensible, but I can't test this. Consider it accepted if nobody else reviews in the coming days.
May 9 2018
Okay, looks good!
May 6 2018
May 1 2018
Apr 30 2018
Sorry, thought of a couple of new things.
Apr 27 2018
Generally looks quite good, but didn't test it yet.
What if the remote doesn't send title, artist, etc. but only nowPlaying?
Apr 26 2018
Apr 24 2018
I get a delay before the UI stuff appears, probably because it's still waiting for the information to display. Would it be possible to load this in advance, like is done in the MPRIS plugin?
Ah okay, makes sense!
Apr 21 2018
Shouldn't this replace the layout_marginRight? Now we get margins on both sides?
Apr 17 2018
I think we should also send the action icon. That might be hard at the moment though, because we can only send one payload.
Looks good to me!
Didn't test, so only consider it accepted if this is an automatic refactor.
I'll do some more testing with the current changes, to make sure edge cases are handled correctly.
Make some requested changes, and better error handling
Maybe the images can be combined? Or a background color? It looks a bit empty with this change.
Apr 16 2018
Apr 15 2018
An empty "available devices" section does make it clear that none of the devices are available at the moment (which might be unclear with only "remembered devices"). I'd suggest only hiding it there's at least one connected device.
I don't like some of the new changes. I understand this is all opinions, so we can't have everything, but I think that the following things are especially bad changes:
- The sidebar navigation should be visually distinct from the main view. In the light view, the main view is shaded and the sidebar has a drop shadow, we could do that here too. Or, if not possible, we should change the sidebar color.
- The dark-orange toolbar doesn't match the other places where the orange color is used. I'd say they should be different hues or be exactly the same color. So either bright orange or black-ish, as @nicolasfella suggested.
Apr 12 2018
Doesn't solve the issue.
Apr 9 2018
It would be even better if we could prompt the user to pair from the device plugin, when the user plugs the usb in for the first time.
APK for testing this diff:
I think it's fine either way, so whatever @nicolasfella thinks 😃
Apr 7 2018
I can't test it, but it looks good.
Mar 30 2018
Mar 29 2018
The code generally looks good to me! I added a few comments.
Wouldn't it make more sense to integrate this into the existing "Find my phone" plugin?
I can't apply the patch cleanly, and it seems as if you removed all previous changes, only adding the newest update.
Mar 28 2018
Mar 27 2018
Move code in both if/else branch outside if
Some icons not yet themed correctly:
- The exclamation icon when you select a paired, but unconnected device
- The volume icon in the MPRIS activity
The diff doesn't appear correctly either, right? Maybe it's because the code already is in a branch?
The code looks good. I'll test once the Android side is done.