This code had a QHash and a separate ordered list of names in order
to use plugins in the right order. It's much simpler to just have a
vector of plugins instead. Also, this fixes a memory leak when multiple
plugins are found with the same name (e.g. one from /usr and one from
my custom prefix, although the right fix for this particular
issue is to load only one of them).
Details
Details
kurifilter tests still pass
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/widgets/kurifilter.cpp | ||
---|---|---|
665 | Interesting, to review my own commit from a month ago, after I forgot its details... Dude, this code crashes, reserve+transform needs back_inserter, otherwise use resize! |
src/widgets/kurifilter.cpp | ||
---|---|---|
597 | Perhaps this can be merged with the if statement above. |
src/widgets/kurifilter.cpp | ||
---|---|---|
597 | It can, but I would certainly find it much less readable. |