Migrate powerdevil keyboard shortcuts
ClosedPublic

Authored by davidedmundson on Nov 29 2017, 2:16 PM.

Details

Summary

Powerdevil "faked" that it's name was "kded5" presumably as a way to
keep user's keyboard shortcuts without having to write a kconf_update
script.

It then tried setting the component name to "power management".
This fails because immediately after it does so, kscreen (which has the component name kded5
because it is in kded5) automatically changes the name back to "KDE Daemon".

This means two things:

  • the shortcuts don't end up under their own "power management" section

in system settings properly.

  • kglobalaccel5 on every startup thinks that the locale is changed (as

a component has changed name) and does some complex heavy writing which we don't want.

This patch moves everything to their own component, and provides a
kconf_update script to move shortcuts.

Test Plan

Confirmed shortcuts moved
Confirmed we have our own "Power Management" section in systemsettings global shortcuts
No more writing on starting kglobalaccel5

I'd be grateful if someone else could confirm that migration works correctly. Migration is hard to re-test.

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 29 2017, 2:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 29 2017, 2:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 29 2017, 2:16 PM
apol accepted this revision.Nov 29 2017, 7:35 PM
apol added a subscriber: apol.

Looking good! :) thanks

This revision is now accepted and ready to land.Nov 29 2017, 7:35 PM
This revision was automatically updated to reflect the committed changes.