When DownloadDialog is not destroyed KNS3 engine not store registry of installed/upgradable stuff.
Details
Details
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
QScopedPointer won't be checking if the object has been destroyed. Are you sure it will never happen?
If so, +1.
Comment Actions
Personally I'd have just set a parent when creating the new KNS3::DownloadDialog.
If someone ever did change this code so it deletes on close, the old code would have handled it, this won't.
But this is also fine.