Differential D9149

Allow running the tool without a display
AbandonedPublic
Actions

Authored by adridg on Dec 3 2017, 4:59 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary
  • Switch to QCoreApplication
  • Check for availability of a primary screen before querying pixmap depth; if there is no screen, leave it alone.

Diff Detail

Repository
R119 Plasma Desktop
Branch
mart/lookandfeeltool
Lint
No Linters Available
Unit
No Unit Test Coverage
adridg created this revision.Dec 3 2017, 4:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 3 2017, 4:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
adridg requested review of this revision.Dec 3 2017, 4:59 PM
adridg added a reviewer: mart.Dec 3 2017, 5:03 PM
apol added a subscriber: apol.Dec 3 2017, 5:06 PM
apol added inline comments.
kcms/krdb/krdb.cpp
141

Are you sure this builds? primaryScreen isn't static.

I'd use qGuiApp->primaryScreen().

kcms/lookandfeel/lnftool.cpp
37

Is this the same binary as above? If so, it should be QGuiApplication at least.

mart added a comment.Dec 3 2017, 5:18 PM

nitpick but should be fine

kcms/krdb/krdb.cpp
141

is indeeed a static: QGuiApplication::primaryScreen() should be fine

adridg abandoned this revision.Dec 3 2017, 5:20 PM

Careful use of -platform minimal allows running the tool with no changes to the code or kcm.

Revision Contents
Changeset List

PathPackages
Mkcms/krdb/krdb.cpp (9 lines)
Mkcms/lookandfeel/lnftool.cpp (2 lines)

Diff 23375

View Options

kcms/krdb/krdb.cpp

Loading...
View Options

kcms/lookandfeel/lnftool.cpp

Loading...