- only one kpackage per applet, minimizes the metadata() cache misses (and access to json)
- make packageurlinterceptor stupid: just replace /ui/ with /code/ on js files for retrocompatibility) should decrease disk access a lot
Details
Details
- Reviewers
- None
- Group Reviewers
Plasma
needs benchmarking and regression testing
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- phab/minimizekpackage
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Otherwise LGTM.
| src/plasmaquick/packageurlinterceptor.cpp | ||
|---|---|---|
| 99 | Move the QRegularExpression into a variable and reuse. | |
Comment Actions
Please push as two separate things.
The applet part looks fine aside from docs.
UrlInterceptor.
IMHO it might be worth a release that continues onwards after the reg exp (so less performance benefits) and prints a warning if we end up in the relativePath code?
| src/plasma/applet.h | ||
|---|---|---|
| 109 | docs especially as we have N almost identical ones. | |
| src/plasmaquick/packageurlinterceptor.cpp | ||
| 99 | QRegularExpression(QStringLiteral as QRegularExpression is going to construct a QString | |
| 100 | Does use of the "data" folder go through the URL interceptor | |
| 103 | I know you uploaded this so I could profile it, | |