[Parley] Bugfix: StatisticsView doesn't display correct values
ClosedPublic

Authored by hriesenbeck on Dec 4 2017, 9:23 PM.

Details

Summary

The color bars in LessonStatisticsView show only the correct values
when the widget was just created. Changing practice language, mode or
direction doesn't change the displayed values.

Added missing method calls in StatisticsMainWindow slot methods.
Implemented improved word counting for gender, conjugation and
comparison practice, to provide correct statistics values for this
practice modes.

Removed wrongly displayed horizontal scroll bar in LessonStatisticsView.
Modified column width calculation, not to use a hard coded magic number,
which does not fit to plasma anymore. Use instead the viewport width of
the LessonStatisticsView widget.

BUG: 387602

Diff Detail

Repository
R340 Parley
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hriesenbeck created this revision.Dec 4 2017, 9:23 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 4 2017, 9:23 PM
hriesenbeck requested review of this revision.Dec 4 2017, 9:23 PM

For convenience, here is the link to the bug report:
Bug 387602 - StatisticsView doesn't display correct values

I just start to work with phabricator - hope this work as expected :-)

apol added a subscriber: apol.Dec 11 2017, 12:00 AM

Thanks!
I'm not an expert in this codebase but the change looks sound to me.

src/statistics/statisticsmainwindow.h
43

Why did you change this?
Please only change what's necessary for easier reviews.

src/utils.cpp
295

Unrelated change

  • Reverted unrelated changes

Tested this revision now for about two weeks in daily practice with no problems.

apol accepted this revision.Dec 11 2017, 10:52 PM
This revision is now accepted and ready to land.Dec 11 2017, 10:52 PM
This revision was automatically updated to reflect the committed changes.