Properly do strings in the kpackage framework
ClosedPublic
Actions

Authored by apol on Dec 2 2017, 11:28 AM.

Details

Reviewers

Group Reviewers

Frameworks
Plasma

Commits

Summary

Instead of using implicit casts, use the ones we need as suggested for KF5.

Test Plan

tests pass, plasma shell starts

Repository

R290 KPackage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested review of this revision.Dec 2 2017, 11:28 AM

This revision is now accepted and ready to land.Dec 2 2017, 11:41 AM

This revision was automatically updated to reflect the committed changes.

There are a few unrelated changes, but otherwise looks good.

src/kpackage/package.cpp
360	?
594	Just curious: what does the modulo operator on a string?
946	This looks like a unrelated move of the line.
src/kpackagetool/kpackagetool.cpp
437	unrelated?

broulik added inline comments.

src/kpackage/package.cpp
594	It explicitly uses `QStringBuilder` for concatenation which `operator+` only does if you define `QT_USE_QSTRINGBUILDER`

			Path	Packages
M			CMakeLists.txt (2 lines)
M			autotests/CMakeLists.txt (2 lines)
M			src/kpackage/package.cpp (62 lines)
M			src/kpackage/packagestructure.cpp (2 lines)
M			src/kpackage/private/packagejobthread.cpp (24 lines)
M			src/kpackage/private/versionparser.cpp (4 lines)
M			src/kpackagetool/kpackagetool.cpp (49 lines)
M			src/kpackagetool/main.cpp (2 lines)