Differential D9203

Add Id to Twitter plugin metadata
ClosedPublic
Actions

Authored by dvratil on Dec 5 2017, 2:38 PM.

Details

Reviewers
apol
mwolff
Commits
R495:0cf9f87a0ab5: Add Id to Twitter plugin
Summary

KPluginMetaData infers plugin Id from the plugin file name, which works for
binary (.so) plugins, but does not work for JS-only plugins like the Twitter
plugin where the plugin file is called main.js. In order to be able to
blacklist the Twitter plugin we need to give it a proper Id.

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil requested review of this revision.Dec 5 2017, 2:38 PM
dvratil created this revision.
mwolff accepted this revision.Dec 5 2017, 3:09 PM
mwolff added a subscriber: mwolff.

Aleix, it might be a good idea to verify that this does not happen in the future again somehow.

This revision is now accepted and ready to land.Dec 5 2017, 3:09 PM
apol accepted this revision.Dec 5 2017, 10:59 PM
In D9203#176293, @mwolff wrote:

Aleix, it might be a good idea to verify that this does not happen in the future again somehow.

Agreed

Closed by commit R495:0cf9f87a0ab5: Add Id to Twitter plugin (authored by dvratil). · Explain WhyDec 6 2017, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plugins/twitter/metadata.json (1 line)

Diff 23559

View Options

src/plugins/twitter/metadata.json

Loading...