Remove implicit string casting
ClosedPublic
Actions

Authored by apol on Dec 2 2017, 2:20 PM.

Details

Reviewers

Group Reviewers

Plasma
Frameworks

Commits

R242:b8b8a69fd1a3: Remove implicit string casting

Summary

Follow the KF5 guidelines

Test Plan

Plasma shell starts

Diff Detail

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol created this revision.Dec 2 2017, 2:20 PM

Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptDec 2 2017, 2:20 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested review of this revision.Dec 2 2017, 2:20 PM

sebas accepted this revision.Dec 2 2017, 2:41 PM

This revision is now accepted and ready to land.Dec 2 2017, 2:41 PM

Closed by commit R242:b8b8a69fd1a3: Remove implicit string casting (authored by apol). · Explain WhyDec 2 2017, 2:47 PM

This revision was automatically updated to reflect the committed changes.

bcooksley mentioned this in R242:df09180d3172: The #warning directive is not universal and in particular is NOT supported by….Dec 2 2017, 6:03 PM

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			autotests/CMakeLists.txt (1 line)
M			src/declarativeimports/calendar/calendarplugin.cpp (2 lines)
M			src/declarativeimports/calendar/eventpluginsmanager.cpp (4 lines)
M			src/declarativeimports/core/corebindingsplugin.cpp (6 lines)
M			src/declarativeimports/core/datamodel.h (1 line)
M			src/declarativeimports/core/datamodel.cpp (10 lines)
M			src/declarativeimports/core/datasource.cpp (2 lines)
M			src/declarativeimports/core/iconitem.cpp (2 lines)
M			src/declarativeimports/core/tooltip.cpp (2 lines)
M			src/declarativeimports/core/tooltipdialog.cpp (4 lines)
M			src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp (8 lines)
M			src/declarativeimports/plasmacomponents/qmenu.cpp (2 lines)
M			src/declarativeimports/plasmaextracomponents/appbackgroundprovider.cpp (2 lines)
M			src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp (2 lines)
M			src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp (4 lines)
M			src/plasma/applet.cpp (2 lines)
M			src/plasma/containment.cpp (4 lines)
M			src/plasma/containmentactions.cpp (9 lines)
M			src/plasma/corona.cpp (6 lines)
M			src/plasma/dataengine.cpp (2 lines)
M			src/plasma/framesvg.cpp (2 lines)
M			src/plasma/packagestructure.cpp (10 lines)
M			src/plasma/packagestructure/packages.cpp (4 lines)
M			src/plasma/pluginloader.cpp (10 lines)
M			src/plasma/private/applet_p.cpp (4 lines)
M			src/plasma/private/componentinstaller.cpp (2 lines)
M			src/plasma/private/containment_p.cpp (2 lines)
M			src/plasma/private/dataenginemanager.cpp (4 lines)
M			src/plasma/private/storagethread.cpp (26 lines)
M			src/plasma/private/theme_p.cpp (20 lines)
M			src/plasma/private/timetracker.cpp (8 lines)
M			src/plasma/service.cpp (2 lines)
M			src/plasma/svg.cpp (8 lines)
M			src/plasma/theme.cpp (6 lines)
M			src/plasmapkg/main.cpp (2 lines)
M			src/plasmaquick/appletquickitem.cpp (4 lines)
M			src/plasmaquick/configmodel.cpp (2 lines)
M			src/plasmaquick/configview.cpp (4 lines)
M			src/plasmaquick/containmentview.cpp (2 lines)
M			src/plasmaquick/packageurlinterceptor.cpp (7 lines)
M			src/plasmaquick/private/packages.cpp (2 lines)
M			src/plasmaquick/view.cpp (2 lines)
M			src/scriptengines/qml/plasmoid/appletinterface.cpp (13 lines)
M			src/scriptengines/qml/plasmoid/containmentinterface.cpp (22 lines)
M			src/scriptengines/qml/plasmoid/wallpaperinterface.cpp (7 lines)
M			tests/dpi/main.cpp (2 lines)
M			tests/kplugins/main.cpp (2 lines)
M			tests/testengine/testengine.cpp (2 lines)