summary

simplify condition, whitespace

Nice work.

Thanks for the explanation.

For the remaining time to be really updated once per second (not only once per batch=40), this also needs D28258, D28267

whitespace

In D28260#633929, @ngraham wrote:

Much nicer! Should the timer be destroyed when indexing is finished, though?

Much nicer! Should the timer be destroyed when indexing is finished, though?

Nice catch.

Due to the recent circumstances I will probably not implement the support in Elisa, so I won't land this unless @bruns explicitly is okay with it (I still think this is an improvement over the status quo).

Seems sane.

• adapt to changes
• use QMimeDatabase

• adapt to changes

Since I got one accept and no other response, I will merge on the weekend

• fix label comment
• tweaks
• rename flag to ImageData
• adress review comments
• udpate since tag
• update since tag

In D27855#629330, @kossebau wrote:

For Qt <5.14 Qt::hex needs to be instead unnamespaced hex, same with Qt::dec -> dec.
Fixed with 28a534ccee9ffa22b2abb7188ab8abb98a099f99

For Qt <5.14 Qt::hex needs to be instead unnamespaced hex, same with Qt::dec -> dec.
Fixed with 28a534ccee9ffa22b2abb7188ab8abb98a099f99

One of the changes in this string of 4 revisions has unfortunately broken the build of Baloo on the CI system.
Please see https://build.kde.org/view/Failing/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/90/console

ping @bruns
this has now been open and unanswered for month!
Same for the dependent patches

I agree, let's get this in now and refactor it later.

Oh jeez.

In D27923#627611, @bruns wrote:

In D27923#627606, @ngraham wrote:

Maybe next we should make baloo_file get killed automatically when indexing is disabled. ;)

baloo_file is stopped when you disable indexing, so I don't know what you are referring to ...

In D27923#627606, @ngraham wrote:

Maybe next we should make baloo_file get killed automatically when indexing is disabled. ;)

Good stuff.

open questions unanswered, does not look right/useful

open questions unanswered ...

In D25743#619435, @davidedmundson wrote:

Ping.

Will do on Sunday (after tagging)

fix deprecation

Done independently

Mark as @deprecated since 5.69
whitespace

Oh so it does!

Hmm, changing the loop to while (true) would seem to reduce some safety if none of the break conditions are reached.

I would like to request a clear answer for https://phabricator.kde.org/D25517 once again