Extract front cover in the taglib extractor
AcceptedPublic

Authored by astippich on Mon, Nov 25, 11:03 AM.

Details

Reviewers
bruns
mgallien
ngraham
Group Reviewers
Baloo
Summary

Add the possibility to extract the front cover
image as binary data when the corresponding flag
is set.

Diff Detail

Repository
R286 KFileMetaData
Branch
taglibBinaryExtraction
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19377
Build 19395: arc lint + arc unit
astippich created this revision.Mon, Nov 25, 11:03 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMon, Nov 25, 11:03 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Mon, Nov 25, 11:03 AM

This is probably how it should have been implemented from the beginning, and not how I did it in the embeddedimagedata class, which duplicates a lot of code and requires additional file operations.
Baloo can continue to work as is due to the new flags.
Taglib writer will follow if this is accepted. Afterwards, I will deprecate embeddedimagedata

ngraham accepted this revision.Mon, Nov 25, 11:13 PM
This revision is now accepted and ready to land.Mon, Nov 25, 11:13 PM