[UnindexedFileIndexer] Only mark file for content indexing when needed
ClosedPublic

Authored by bruns on Mar 26 2020, 11:46 PM.

Details

Summary

In case the index level is set to "non content indexing", the file was
still flagged when it had changed. As the content indexer checks for
the level itself (the config may have changed in the meantime), the
effect is limited, but the code is still wrong.

In case the level is set to "content indexing", the flag would be set
twice. As it is a flag the effect is limited, but it blows up the
transaction unnecessarily.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Mar 26 2020, 11:46 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 26 2020, 11:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 26 2020, 11:47 PM
davidedmundson accepted this revision.Mar 27 2020, 9:05 AM
This revision is now accepted and ready to land.Mar 27 2020, 9:05 AM
ngraham accepted this revision.Mar 27 2020, 2:10 PM
This revision was automatically updated to reflect the committed changes.