Add an option to extract binary data and add front cover property
Needs ReviewPublic

Authored by astippich on Mon, Nov 25, 11:01 AM.

Details

Reviewers
bruns
mgallien
ngraham
Group Reviewers
Baloo
Summary

prepare for the following patch to taglibextractor

Diff Detail

Repository
R286 KFileMetaData
Branch
binaryData
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19376
Build 19394: arc lint + arc unit
astippich created this revision.Mon, Nov 25, 11:01 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMon, Nov 25, 11:01 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Mon, Nov 25, 11:01 AM
ngraham accepted this revision.Mon, Nov 25, 3:21 PM
This revision is now accepted and ready to land.Mon, Nov 25, 3:21 PM
astippich updated this revision to Diff 70303.Mon, Nov 25, 3:55 PM
  • fix label comment
bruns requested changes to this revision.Tue, Nov 26, 11:23 PM
bruns added inline comments.
src/extractionresult.h
61

Binary is how, not what.

This revision now requires changes to proceed.Tue, Nov 26, 11:23 PM
astippich added inline comments.Wed, Nov 27, 8:09 AM
src/extractionresult.h
61

Do you have a suggestion for a better name? I tried to be as generic as possible. It could be named more specifically ExtractImages, since this is what it will be primarily used for

astippich updated this revision to Diff 70723.Mon, Dec 2, 8:29 AM
  • fix label comment
  • tweaks