Differential D27771

[WriteTransaction] Avoid growing m_pendingOperations twice on replace
ClosedPublic
Actions

Authored by bruns on Mar 1 2020, 11:34 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Commits
R293:b0b32093524f: [WriteTransaction] Avoid growing m_pendingOperations twice on replace
Summary

As the following addTerms() does another reserve() with growing by
terms.size() sum up both sizes. The reserve() in addTerms() is a
noop then.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Mar 1 2020, 11:34 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 1 2020, 11:34 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 1 2020, 11:34 PM
ngraham accepted this revision.Mar 16 2020, 3:08 AM
This revision is now accepted and ready to land.Mar 16 2020, 3:08 AM
Closed by commit R293:b0b32093524f: [WriteTransaction] Avoid growing m_pendingOperations twice on replace (authored by bruns). · Explain WhyMar 16 2020, 4:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/writetransaction.cpp (2 lines)

Diff 77747

View Options

src/engine/writetransaction.cpp

Loading...