Feed Advanced Search

Apr 14 2021

ngraham abandoned D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Moved over to https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/427.

Apr 14 2021, 10:02 PM · Baloo, Plasma

Dec 21 2020

justinzobel added a comment to D25743: Expose IndexerState enum to QML.

Can we please continue this over on Gitlab?

Dec 21 2020, 10:37 PM · Baloo, Frameworks
justinzobel added a comment to D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing.

Can we please continue this over on Gitlab?

Dec 21 2020, 10:37 PM · Baloo, Plasma

Jun 20 2020

hurikhan77 updated the task description for T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions.
Jun 20 2020, 1:52 AM · Frameworks, Baloo
hurikhan77 updated the task description for T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions.
Jun 20 2020, 1:51 AM · Frameworks, Baloo

Jun 19 2020

ngraham closed T13298: Ballo issue: RAM and processor are too busy as Invalid.

Phabricator is not used for bug reports but rather for developer task tracking, which is already being discussed at T11859. Please file bug reports at https://bugs.kde.org.

Jun 19 2020, 3:55 PM · Baloo
pavol added a comment to T13298: Ballo issue: RAM and processor are too busy.

hurikhan77 : thank you very much for post.
Yes, I use dual boot with Windows 10.

Jun 19 2020, 9:18 AM · Baloo

Jun 18 2020

hurikhan77 updated subscribers of T13298: Ballo issue: RAM and processor are too busy.

To be honest, this is something I wanted to contribute. I've had moments as I'd code that my computer would lock up and it was because baloo was indexing pictures (not even the source code). I'm not sure but it's not explicit that Baloo runs only when the computer is idle. I'd want to extend this to communicate:

  • How much time / progress is made for a full index
Jun 18 2020, 11:10 PM · Baloo
pavol updated subscribers of T13298: Ballo issue: RAM and processor are too busy.

jackyalcine: thank you very much for answer.
I am sorry, I am not programmer, I am not understand of all your questions.
I send you any screenshots. In Stacer app monitor application you can see up applications who use most processor.
Baloo file extractor use sometimes 1 GB RAM

Jun 18 2020, 8:22 PM · Baloo
pavol updated the task description for T13298: Ballo issue: RAM and processor are too busy.
Jun 18 2020, 7:42 PM · Baloo
jackyalcine added a comment to T13298: Ballo issue: RAM and processor are too busy.

To be honest, this is something I wanted to contribute. I've had moments as I'd code that my computer would lock up and it was because baloo was indexing pictures (not even the source code). I'm not sure but it's not explicit that Baloo runs only when the computer is idle. I'd want to extend this to communicate:

Jun 18 2020, 7:39 PM · Baloo
pavol triaged T13298: Ballo issue: RAM and processor are too busy as Normal priority.
Jun 18 2020, 7:31 PM · Baloo

Jun 13 2020

astippich removed a watcher for Baloo: astippich.
Jun 13 2020, 2:26 PM

Jun 10 2020

bruns closed D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions.
Jun 10 2020, 11:16 PM · Baloo, Frameworks
ngraham accepted D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions.

Shipit!

Jun 10 2020, 10:33 PM · Baloo, Frameworks
bruns updated the summary of D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions.
Jun 10 2020, 10:15 PM · Baloo, Frameworks

Jun 1 2020

adridg added a comment to D10829: [WIP] Use DocumentId class.

This looks abandoned or stalled. @michaelh do you have any plans on this front?

Jun 1 2020, 9:07 PM · Frameworks, Baloo

May 30 2020

adridg added a comment to D10825: [WIP] Introduce aliases DocId, DeviceId and Inode.

This looks abandoned with 2 years of no movement. @michaelh do you still feel this is a WIP?

May 30 2020, 3:53 PM · Baloo, Frameworks
adridg added a comment to D10826: [WIP] Introduce DocumentId class.

This looks abandoned with 2 years of no movement. @michaelh do you still feel this is a WIP?

May 30 2020, 3:53 PM · Frameworks, Baloo
adridg added a comment to D10856: [WIP] Make tests compile, except one.

This looks abandoned, no movement in over two years. @michaelh did you still want to introduce docId instead of quint64? This diff was supposed to supplant D10851 but seems to have fallen asleep as well. (In retrospect, perhaps I would have suggested first introducing just using docId = quint64; somewhere, to get the more-expressive-type-name part out of the way before real changes)

May 30 2020, 3:50 PM · Baloo, Frameworks
adridg added a comment to D10851: autotests: Introduce alias DocId.

This looks abandoned, no movement in over two years. @michaelh do you want to explicitly abandon this one, so we have a clean slate for invent? None of the docId type changes seem to have made it to master (see also D10856)

May 30 2020, 3:47 PM · Baloo, Frameworks

May 10 2020

eszlari added a comment to D29597: file extractor: fix linking.

Strange. It worked with gmake locally, but failed on the Flathub buildbot again (https://flathub.org/builds/#/builders/32/builds/19809, only x86_64 failed, not arm or aarch64).

May 10 2020, 7:18 PM · Baloo, Frameworks
eszlari abandoned D29597: file extractor: fix linking.
May 10 2020, 6:25 PM · Baloo, Frameworks
eszlari added a comment to D29597: file extractor: fix linking.

Indeed. It failed with cmake 3.15.2 + ninja 1.9.0 and worked with make (4.2.1).

May 10 2020, 6:24 PM · Baloo, Frameworks
bruns requested changes to D29597: file extractor: fix linking.

Your build system seems to be broken. The "missing" methods are statically linked, see src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o

May 10 2020, 4:19 PM · Baloo, Frameworks
eszlari requested review of D29597: file extractor: fix linking.
May 10 2020, 1:07 PM · Baloo, Frameworks

May 6 2020

bruns closed D29454: [TaglibExtractor] Add support for Audible "Enhanced Audio" audio books.
May 6 2020, 1:22 AM · Baloo, Frameworks

May 5 2020

bruns added a comment to D29454: [TaglibExtractor] Add support for Audible "Enhanced Audio" audio books.

Nice!

May 5 2020, 9:26 PM · Baloo, Frameworks
ngraham accepted D29454: [TaglibExtractor] Add support for Audible "Enhanced Audio" audio books.

Nice!

May 5 2020, 8:08 PM · Baloo, Frameworks
bruns requested review of D29454: [TaglibExtractor] Add support for Audible "Enhanced Audio" audio books.
May 5 2020, 7:14 PM · Baloo, Frameworks

May 4 2020

bruns closed D28932: Store filename terms just once.
May 4 2020, 7:48 PM · Baloo, Frameworks
ngraham accepted D28932: Store filename terms just once.

Sorry for the delay. Makes sense.

May 4 2020, 7:03 PM · Baloo, Frameworks
astippich closed D29200: test the extractNothing flag.
May 4 2020, 5:40 PM · Baloo, Frameworks
astippich closed D29199: honor the extractMetaData flag.
May 4 2020, 5:36 PM · Baloo, Frameworks
bruns added a comment to D28932: Store filename terms just once.

This has been pending for more than two weeks now, without any sort of review ...

May 4 2020, 4:28 PM · Baloo, Frameworks

May 2 2020

bruns updated the summary of D28932: Store filename terms just once.
May 2 2020, 12:55 PM · Baloo, Frameworks
bruns added a comment to D28932: Store filename terms just once.

Ping!

May 2 2020, 12:52 PM · Baloo, Frameworks

Apr 27 2020

bruns closed D29188: [FileWatch] Remove redundant watchIndexedFolders() slot.
Apr 27 2020, 2:55 PM · Baloo, Frameworks
ngraham accepted D29188: [FileWatch] Remove redundant watchIndexedFolders() slot.
Apr 27 2020, 2:50 PM · Baloo, Frameworks
ngraham accepted D29200: test the extractNothing flag.
Apr 27 2020, 2:23 PM · Baloo, Frameworks
ngraham accepted D29199: honor the extractMetaData flag.
Apr 27 2020, 2:23 PM · Baloo, Frameworks

Apr 26 2020

bruns accepted D29199: honor the extractMetaData flag.
Apr 26 2020, 5:04 PM · Baloo, Frameworks
astippich updated the diff for D29199: honor the extractMetaData flag.
  • use continue
Apr 26 2020, 4:55 PM · Baloo, Frameworks
astippich updated the diff for D29199: honor the extractMetaData flag.
  • fix another stupid mistake
Apr 26 2020, 4:50 PM · Baloo, Frameworks
astippich added inline comments to D29199: honor the extractMetaData flag.
Apr 26 2020, 3:11 PM · Baloo, Frameworks
astippich updated the diff for D29199: honor the extractMetaData flag.
  • more fixes
Apr 26 2020, 3:10 PM · Baloo, Frameworks
bruns requested review of D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions.
Apr 26 2020, 3:08 PM · Baloo, Frameworks
bruns added a dependent revision for D28932: Store filename terms just once: D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions.
Apr 26 2020, 3:08 PM · Baloo, Frameworks
bruns added inline comments to D29199: honor the extractMetaData flag.
Apr 26 2020, 3:00 PM · Baloo, Frameworks
astippich added inline comments to D29199: honor the extractMetaData flag.
Apr 26 2020, 2:47 PM · Baloo, Frameworks
astippich updated the diff for D29199: honor the extractMetaData flag.
  • implement review
Apr 26 2020, 2:47 PM · Baloo, Frameworks
bruns closed D29191: [FileWatch] Fix watch updates on config changes.
Apr 26 2020, 2:26 PM · Baloo, Frameworks
bruns closed D29189: [KInotify] Fix path matching when removing watches.
Apr 26 2020, 2:25 PM · Baloo, Frameworks
bruns requested changes to D29199: honor the extractMetaData flag.
Apr 26 2020, 1:39 PM · Baloo, Frameworks
bruns added inline comments to D29199: honor the extractMetaData flag.
Apr 26 2020, 1:38 PM · Baloo, Frameworks
meven accepted D29189: [KInotify] Fix path matching when removing watches.
Apr 26 2020, 1:20 PM · Baloo, Frameworks
astippich added a dependent revision for D29199: honor the extractMetaData flag: D29200: test the extractNothing flag.
Apr 26 2020, 1:18 PM · Baloo, Frameworks
astippich requested review of D29200: test the extractNothing flag.
Apr 26 2020, 1:18 PM · Baloo, Frameworks
astippich requested review of D29199: honor the extractMetaData flag.
Apr 26 2020, 1:16 PM · Baloo, Frameworks
bruns updated the summary of D29189: [KInotify] Fix path matching when removing watches.
Apr 26 2020, 12:52 PM · Baloo, Frameworks
bruns added a dependency for D29191: [FileWatch] Fix watch updates on config changes: D29189: [KInotify] Fix path matching when removing watches.
Apr 26 2020, 12:45 PM · Baloo, Frameworks
bruns added a dependent revision for D29189: [KInotify] Fix path matching when removing watches: D29191: [FileWatch] Fix watch updates on config changes.
Apr 26 2020, 12:45 PM · Baloo, Frameworks
bruns closed D29190: [FileWatchTest] Extend coverage to config updates.
Apr 26 2020, 12:35 PM · Baloo, Frameworks
bruns added inline comments to D29190: [FileWatchTest] Extend coverage to config updates.
Apr 26 2020, 12:31 PM · Baloo, Frameworks
meven accepted D29191: [FileWatch] Fix watch updates on config changes.

Good to me

Apr 26 2020, 11:43 AM · Baloo, Frameworks
meven accepted D29190: [FileWatchTest] Extend coverage to config updates.
Apr 26 2020, 11:40 AM · Baloo, Frameworks
meven added inline comments to D29190: [FileWatchTest] Extend coverage to config updates.
Apr 26 2020, 11:39 AM · Baloo, Frameworks

Apr 25 2020

bruns updated the diff for D29190: [FileWatchTest] Extend coverage to config updates.

whitespace

Apr 25 2020, 9:16 PM · Baloo, Frameworks
bruns requested review of D29191: [FileWatch] Fix watch updates on config changes.
Apr 25 2020, 9:14 PM · Baloo, Frameworks
bruns added a dependent revision for D29190: [FileWatchTest] Extend coverage to config updates: D29191: [FileWatch] Fix watch updates on config changes.
Apr 25 2020, 9:14 PM · Baloo, Frameworks
bruns added a dependent revision for D29190: [FileWatchTest] Extend coverage to config updates: D29189: [KInotify] Fix path matching when removing watches.
Apr 25 2020, 9:13 PM · Baloo, Frameworks
bruns added a dependency for D29189: [KInotify] Fix path matching when removing watches: D29190: [FileWatchTest] Extend coverage to config updates.
Apr 25 2020, 9:13 PM · Baloo, Frameworks
bruns requested review of D29190: [FileWatchTest] Extend coverage to config updates.
Apr 25 2020, 9:12 PM · Baloo, Frameworks
bruns requested review of D29189: [KInotify] Fix path matching when removing watches.
Apr 25 2020, 9:06 PM · Baloo, Frameworks
bruns requested review of D29188: [FileWatch] Remove redundant watchIndexedFolders() slot.
Apr 25 2020, 8:32 PM · Baloo, Frameworks
meven closed D28972: FileMetaDataWidget: Avoid showing fields when they have no value.
Apr 25 2020, 8:15 PM · Baloo
meven updated the summary of D28972: FileMetaDataWidget: Avoid showing fields when they have no value.
Apr 25 2020, 8:13 PM · Baloo
meven retitled D28972: FileMetaDataWidget: Avoid showing fields when they have no value from FileMetaDataWidget: Avoid fields when they have no value to FileMetaDataWidget: Avoid showing fields when they have no value.
Apr 25 2020, 8:12 PM · Baloo
meven retitled D28972: FileMetaDataWidget: Avoid showing fields when they have no value from FileMetaDataWidget: Avoid displaying size and dates fields when they have no value to FileMetaDataWidget: Avoid fields when they have no value.
Apr 25 2020, 8:11 PM · Baloo
bruns accepted D28972: FileMetaDataWidget: Avoid showing fields when they have no value.
Apr 25 2020, 8:11 PM · Baloo
bruns added a comment to D28972: FileMetaDataWidget: Avoid showing fields when they have no value.

Wrap at ~80 characters, please.

Apr 25 2020, 8:11 PM · Baloo
meven updated the summary of D28972: FileMetaDataWidget: Avoid showing fields when they have no value.
Apr 25 2020, 8:10 PM · Baloo
meven added a comment to D28972: FileMetaDataWidget: Avoid showing fields when they have no value.

@bruns does this sounds good to you ?

The code looks fine. Can you extend the summary so it is immediately visible where this is needed/useful, without having to folllow the bug link?

Apr 25 2020, 8:09 PM · Baloo
bruns added a comment to D28972: FileMetaDataWidget: Avoid showing fields when they have no value.

@bruns does this sounds good to you ?

Apr 25 2020, 8:04 PM · Baloo
meven added a comment to D28972: FileMetaDataWidget: Avoid showing fields when they have no value.

@bruns does this sounds good to you ?

Apr 25 2020, 7:52 PM · Baloo
bruns closed D29181: Use KFileMetaData for XAttr support instead of private reimplementation.
Apr 25 2020, 7:16 PM · Baloo, Frameworks
apol accepted D29181: Use KFileMetaData for XAttr support instead of private reimplementation.
Apr 25 2020, 5:54 PM · Baloo, Frameworks
bruns requested review of D29181: Use KFileMetaData for XAttr support instead of private reimplementation.
Apr 25 2020, 5:22 PM · Baloo, Frameworks
bruns closed D28980: Revert "add Baloo DBus signals for moved or removed files".
Apr 25 2020, 4:31 PM · Baloo, Frameworks
bruns closed D28956: [QML Monitor] Show remaining time as soon as possible.
Apr 25 2020, 4:03 PM · Baloo, Frameworks
bruns added a comment to D28932: Store filename terms just once.

I'll get around to reviewing this soon. I'm trying to figure out of I think the loss is acceptable.

Apr 25 2020, 3:05 PM · Baloo, Frameworks
ngraham accepted D28956: [QML Monitor] Show remaining time as soon as possible.
Apr 25 2020, 2:43 PM · Baloo, Frameworks
ngraham added a comment to D28932: Store filename terms just once.

I'll get around to reviewing this soon. I'm trying to figure out of I think the loss is acceptable.

Apr 25 2020, 1:57 PM · Baloo, Frameworks
bruns added a comment to D28932: Store filename terms just once.

Ping!

Apr 25 2020, 1:36 PM · Baloo, Frameworks
bruns added a comment to D28956: [QML Monitor] Show remaining time as soon as possible.

Ping!

Apr 25 2020, 1:36 PM · Baloo, Frameworks

Apr 21 2020

rjvbb added a comment to D20739: Handle multiple entries in map.
Instead of adding Windows support where the platform *is* different, you introduce additional differences.
Apr 21 2020, 4:44 PM · Baloo
bruns added a comment to D20739: Handle multiple entries in map.

any bug reports for the Windows platform will be rejected immediately then.

Because they aren't already given that baloo only works on Linux and *BSD?

This is the sort of attitude that always makes my eyes roll whenever I see a reference to the idea of support in most KDE software.

Apr 21 2020, 2:30 PM · Baloo
rjvbb added a comment to D20739: Handle multiple entries in map.

any bug reports for the Windows platform will be rejected immediately then.

Apr 21 2020, 1:46 PM · Baloo
bruns added a comment to D20739: Handle multiple entries in map.
Qt 5.10. is required since KF 5.55: https://kde.org/announcements/kde-frameworks-5.55.0.php.

True, but not relevant here because the issue is not with KF5 APIs but with QMap. The frameworks relevant for baloo all build against Qt 5.9 either without or with minimal patching (which in essence reintroduce removed code).

Apr 21 2020, 12:50 PM · Baloo
rjvbb added a comment to D20739: Handle multiple entries in map.

Ultimately this wasn't difficult, so apologies for the noise!

Apr 21 2020, 12:39 PM · Baloo