Add more file and directories to exclude filters
Needs RevisionPublic

Authored by ognarb on Thu, Oct 3, 3:18 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Test Plan

None for the moment

Diff Detail

Repository
R293 Baloo
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17295
Build 17313: arc lint + arc unit
ognarb created this revision.Thu, Oct 3, 3:18 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptThu, Oct 3, 3:18 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
ognarb requested review of this revision.Thu, Oct 3, 3:18 PM
ognarb added a reviewer: Baloo.Thu, Oct 3, 3:19 PM
ngraham requested changes to this revision.Thu, Oct 3, 3:49 PM
ngraham added a subscriber: ngraham.
ngraham added inline comments.
src/file/fileexcludefilters.cpp
109

Gotta bump this number whenever you change s_defaultFileExcludeFilters

137

This one makes me a little nervous since it's a not-very-uncommon English word, not something implicitly technical that we can be safe excluding.

Is there any other way we could exclude the contents of these folders? Maybe by filename, mimetype, or the naming of sub-folders?

147

Gotta bump this number whenever you change s_defaultFolderExcludeFilters

This revision now requires changes to proceed.Thu, Oct 3, 3:49 PM
ognarb added inline comments.Thu, Oct 3, 3:52 PM
src/file/fileexcludefilters.cpp
137

This directory contains only pure PHP code, so not possible by filename or minetype. Maybe we could use the fact that a composer.json is always included in the same directory?

ngraham added inline comments.Thu, Oct 3, 6:01 PM
src/file/fileexcludefilters.cpp
137

PHP source code files are already supposed to be getting excluded though (search for application/x-php in this file). Are the PHP files in question using a different mime type?