carewolf (Allan Sandfeld Jensen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 23 2017, 2:08 PM (47 w, 13 h)
Availability
Available

Recent Activity

Mar 21 2018

carewolf added a reviewer for D11554: Add warnings to why some actions might be invalid: vkrause.
Mar 21 2018, 3:02 PM · Frameworks
carewolf requested review of D11554: Add warnings to why some actions might be invalid.
Mar 21 2018, 3:01 PM · Frameworks

Mar 12 2018

carewolf requested review of D11273: Fix QSqlQuery warnings.
Mar 12 2018, 10:44 PM · KDE PIM

Mar 10 2018

carewolf requested review of D11211: Add missing include.
Mar 10 2018, 2:19 PM · KDE PIM
carewolf committed R459:5d4ddb532ec7: Fix build after deprecated QFontMetrics::width() (authored by carewolf).
Fix build after deprecated QFontMetrics::width()
Mar 10 2018, 11:44 AM
carewolf closed D11113: Fix build after deprecated QFontMetrics::width().
Mar 10 2018, 11:43 AM · KDE PIM
carewolf added a comment to D11113: Fix build after deprecated QFontMetrics::width().

Ah, sorry wrong branch. Didnt notice it had a default upstream set.

Mar 10 2018, 11:41 AM · KDE PIM

Mar 8 2018

carewolf updated the summary of D11113: Fix build after deprecated QFontMetrics::width().
Mar 8 2018, 11:33 AM · KDE PIM
carewolf updated the diff for D11113: Fix build after deprecated QFontMetrics::width().

Updated to not used the depecated API

Mar 8 2018, 11:32 AM · KDE PIM
carewolf committed R91:adb3fe2f7fb6: Fix build after deprecated QFontMetrics::width() (authored by carewolf).
Fix build after deprecated QFontMetrics::width()
Mar 8 2018, 9:05 AM
carewolf closed D11117: Fix build after deprecated QFontMetrics::width().
Mar 8 2018, 9:05 AM · KDE PIM

Mar 7 2018

carewolf added a comment to D11120: Fix missing includes.

No sorry, I just pushed them to stable. I wasn't aware it was in freeze. Since this is for Qt 5.11 support it is not urgent.

Mar 7 2018, 5:20 PM · KDE PIM
carewolf updated the summary of D11117: Fix build after deprecated QFontMetrics::width().
Mar 7 2018, 5:03 PM · KDE PIM
carewolf updated the diff for D11117: Fix build after deprecated QFontMetrics::width().

Based on review feedback

Mar 7 2018, 5:02 PM · KDE PIM
carewolf committed R94:38d832306273: Fix webenginemessageviewer with Qt 5.11 (authored by carewolf).
Fix webenginemessageviewer with Qt 5.11
Mar 7 2018, 4:42 PM
carewolf closed D11122: Fix webenginemessageviewer with Qt 5.11.
Mar 7 2018, 4:42 PM · KDE PIM
carewolf committed R206:7e762f09805c: Fix missing includes (authored by carewolf).
Fix missing includes
Mar 7 2018, 4:41 PM
carewolf closed D11120: Fix missing includes.
Mar 7 2018, 4:41 PM · KDE PIM
carewolf added a comment to D11117: Fix build after deprecated QFontMetrics::width().

Why not both? I just did the change to the define because it was less work and still fixing something wrong.

Mar 7 2018, 4:40 PM · KDE PIM
carewolf requested review of D11122: Fix webenginemessageviewer with Qt 5.11.
Mar 7 2018, 1:29 PM · KDE PIM
carewolf added a comment to D11117: Fix build after deprecated QFontMetrics::width().

No it is just QFontMetrics::width() is marked deprecated, and that doesn't change the Qt API and wouldn't be a problem if it wasn't that you are telling Qt to omit all deprecated API also things deprecated in the future, which is a bad idea.

Mar 7 2018, 12:24 PM · KDE PIM
carewolf closed D11119: Fix build with Qt 5.11.
Mar 7 2018, 12:23 PM · KDE PIM
carewolf requested review of D11120: Fix missing includes.
Mar 7 2018, 12:21 PM · KDE PIM
carewolf committed R44:e9ac8786c926: Fix build with Qt 5.11 (authored by carewolf).
Fix build with Qt 5.11
Mar 7 2018, 12:07 PM
carewolf committed R44:ab492f88732c: Fix build with Qt 5.11 (authored by carewolf).
Fix build with Qt 5.11
Mar 7 2018, 12:07 PM
carewolf requested review of D11119: Fix build with Qt 5.11.
Mar 7 2018, 12:06 PM · KDE PIM
carewolf committed R94:9e008c1c4e0c: Fix build with Qt 5.11 (authored by carewolf).
Fix build with Qt 5.11
Mar 7 2018, 12:04 PM
carewolf closed D11116: Fix build with Qt 5.11.
Mar 7 2018, 12:04 PM · KDE PIM
carewolf closed D11115: Fix build with Qt 5.11.
Mar 7 2018, 12:02 PM · KDE PIM
carewolf requested review of D11117: Fix build after deprecated QFontMetrics::width().
Mar 7 2018, 11:20 AM · KDE PIM
carewolf requested review of D11116: Fix build with Qt 5.11.
Mar 7 2018, 11:17 AM · KDE PIM
carewolf requested review of D11115: Fix build with Qt 5.11.
Mar 7 2018, 11:14 AM · KDE PIM
carewolf requested review of D11113: Fix build after deprecated QFontMetrics::width().
Mar 7 2018, 11:01 AM · KDE PIM

Oct 31 2017

carewolf added a comment to D8560: Sort files "latin first" .

Languages with the same alphabets do NOT sort the same way. Forcing the wrong locale will sort incorrectly. There are all kinds of quirks between languages. For instance ä is close to last in the alphabet in Swedish, but sorted together with a in German.

Oct 31 2017, 9:36 AM · Dolphin

Oct 23 2017

carewolf added a comment to D7033: Port ki18n from QtScript to QtQml.

No, but I will see if I can find some. Otherwise feel free to take over an fix the remaining issues.

Oct 23 2017, 7:20 AM · Frameworks

Aug 16 2017

carewolf added a comment to D7337: Port rest of scripting API to QJSValue-based solution.

A few of the cursor/range functions are used, but not all of them. You could probably rewrite the places using them to use line+col instead.

Aug 16 2017, 9:20 AM · Frameworks

Aug 15 2017

carewolf accepted D7337: Port rest of scripting API to QJSValue-based solution.

Looks good to me

Aug 15 2017, 8:12 PM · Frameworks

Aug 13 2017

carewolf committed R39:878797830dbd: Switch from QtScript to QtQml (authored by carewolf).
Switch from QtScript to QtQml
Aug 13 2017, 7:30 AM
carewolf closed D6914: Switch from QtScript to QtQml by committing R39:878797830dbd: Switch from QtScript to QtQml.
Aug 13 2017, 7:30 AM · Frameworks
carewolf updated the diff for D6914: Switch from QtScript to QtQml.

Minor cleanups

Aug 13 2017, 7:22 AM · Frameworks
carewolf added a comment to D6914: Switch from QtScript to QtQml.

Actually I wanted to clean a few minor things first. I will update it.

Aug 13 2017, 7:11 AM · Frameworks

Aug 6 2017

carewolf committed R111:b6ed1afd8a8a: libksysguard does not appear to use QtScript, but just includes it. (authored by carewolf).
libksysguard does not appear to use QtScript, but just includes it.
Aug 6 2017, 11:20 PM
carewolf closed D7036: Remove fake dependency on QtScript by committing R111:b6ed1afd8a8a: libksysguard does not appear to use QtScript, but just includes it..
Aug 6 2017, 11:20 PM · Plasma
carewolf closed D6895: Handle fine-grained wheel event in zoomin.

Already landed

Aug 6 2017, 10:29 PM · Frameworks

Aug 1 2017

carewolf added reviewers for D7036: Remove fake dependency on QtScript: sandsmark, jriddell.
Aug 1 2017, 1:41 PM · Plasma
carewolf added a reviewer for D7037: Remove fake dependency on QtScript: hindenburg.
Aug 1 2017, 1:40 PM · Konsole
carewolf created D7037: Remove fake dependency on QtScript.
Aug 1 2017, 1:39 PM · Konsole
carewolf updated the diff for D7036: Remove fake dependency on QtScript.
Aug 1 2017, 1:35 PM · Plasma
carewolf created D7036: Remove fake dependency on QtScript.
Aug 1 2017, 1:34 PM · Plasma
carewolf created D7033: Port ki18n from QtScript to QtQml.
Aug 1 2017, 12:56 PM · Frameworks

Jul 27 2017

carewolf updated the diff for D6914: Switch from QtScript to QtQml.

Fixed ruby tests

Jul 27 2017, 10:44 AM · Frameworks
carewolf committed R39:56d09b4b33fe: Handle fine-grained wheel event in zooming (authored by carewolf).
Handle fine-grained wheel event in zooming
Jul 27 2017, 9:01 AM

Jul 26 2017

carewolf updated the diff for D6914: Switch from QtScript to QtQml.

Forgot to add the new private headers.

Jul 26 2017, 10:25 AM · Frameworks
carewolf updated the diff for D6914: Switch from QtScript to QtQml.
Jul 26 2017, 10:19 AM · Frameworks
carewolf added a comment to D6914: Switch from QtScript to QtQml.

As I said it has some instrumentation and dead-code. I will clean it up a bit. I was just hoping for a bit of help on why the ruby indent tests are being weird.

Jul 26 2017, 9:55 AM · Frameworks
carewolf added a comment to D6914: Switch from QtScript to QtQml.

Note all of the helper functions are now single argument, but no script we have use more. It does however remove templating in the i18n functions.

Jul 26 2017, 9:28 AM · Frameworks
carewolf added a comment to D6914: Switch from QtScript to QtQml.

Actually the Q_GADGET part is not needed. I have commented out the code that registers the qmetaobject, so at this point those changes are no longer needed. I needed to do manual conversion anyway. The conversion functions doesn't need to be in public headers. But they are needed in several places, so at least in a private header.

Jul 26 2017, 9:26 AM · Frameworks
carewolf created D6914: Switch from QtScript to QtQml.
Jul 26 2017, 9:07 AM · Frameworks

Jul 25 2017

carewolf added a comment to D6895: Handle fine-grained wheel event in zoomin.

DefaultDeltasPerStep is always exactly 120 :D

Jul 25 2017, 10:22 PM · Frameworks
carewolf updated the diff for D6895: Handle fine-grained wheel event in zoomin.

Fix smoothness of zooming down

Jul 25 2017, 11:34 AM · Frameworks
carewolf added a reviewer for D6895: Handle fine-grained wheel event in zoomin: cullmann.
Jul 25 2017, 11:22 AM · Frameworks
carewolf created D6895: Handle fine-grained wheel event in zoomin.
Jul 25 2017, 11:21 AM · Frameworks