carewolf (Allan Sandfeld Jensen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 23 2017, 2:08 PM (165 w, 16 h)
Availability
Available

Recent Activity

Aug 18 2020

carewolf added a comment to D24826: Enforce 100 chars line width.

I agree. A limit of 100 is arbitrary and harmful. Unfortunately clang-format doesn't seem to have a way to make lines over a certain length less desirably, but still allowed if the break would be ugly, so it is better to just allow long lines.

Aug 18 2020, 7:49 PM · Build System, Frameworks

Aug 2 2020

carewolf added a reviewer for D29873: Close windows when saving session data: wbauer.
Aug 2 2020, 11:03 AM
carewolf added a reviewer for D29873: Close windows when saving session data: kossebau.
Aug 2 2020, 10:59 AM
carewolf requested review of D29873: Close windows when saving session data.
Aug 2 2020, 10:56 AM

May 5 2020

carewolf added a comment to D29007: Make wheel-event fixup version dependent.

I for some reason can't land this change. It says "hook declined". Feel free to land it for me.

May 5 2020, 11:28 AM · Falkon

Apr 20 2020

carewolf added a reviewer for D29007: Make wheel-event fixup version dependent: drosca.
Apr 20 2020, 9:58 AM · Falkon
carewolf requested review of D29007: Make wheel-event fixup version dependent.
Apr 20 2020, 9:57 AM · Falkon

Mar 17 2020

carewolf abandoned D28008: Don't use deprecated QList::toSet.

Done in separate change

Mar 17 2020, 10:04 AM · KDE PIM

Mar 16 2020

carewolf closed D28059: Be more accurate in reporting the x86 CPU features solid detects.
Mar 16 2020, 12:33 PM · Plasma
carewolf committed R102:53ff92062221: Be more accurate in reporting the x86 CPU features solid detects (authored by carewolf).
Be more accurate in reporting the x86 CPU features solid detects
Mar 16 2020, 12:33 PM

Mar 15 2020

carewolf added reviewers for D28059: Be more accurate in reporting the x86 CPU features solid detects: sitter, Plasma.
Mar 15 2020, 3:32 PM · Plasma
carewolf requested review of D28059: Be more accurate in reporting the x86 CPU features solid detects.
Mar 15 2020, 3:31 PM · Plasma

Mar 14 2020

carewolf committed R177:126fc4e64ccf: Don't use deprecated QSet::toList() (authored by carewolf).
Don't use deprecated QSet::toList()
Mar 14 2020, 8:07 AM
carewolf closed D28009: Don't use deprecated QSet::toList().
Mar 14 2020, 8:07 AM · KDE PIM

Mar 13 2020

carewolf committed R84:9265e46139d8: Fix build with 5.14.2 and 5.15 beta2 (authored by carewolf).
Fix build with 5.14.2 and 5.15 beta2
Mar 13 2020, 9:59 PM
carewolf closed D28011: Fix build with 5.14.2 and 5.15 beta2.
Mar 13 2020, 9:59 PM · KDE PIM
carewolf updated the diff for D28009: Don't use deprecated QSet::toList().

Build with <5.14 too

Mar 13 2020, 3:31 PM · KDE PIM
carewolf abandoned D21604: Fix building with Qt 5.13.

Done independently

Mar 13 2020, 3:28 PM · Baloo, Frameworks
carewolf updated the diff for D28011: Fix build with 5.14.2 and 5.15 beta2.

Update to also build with <5.14

Mar 13 2020, 3:27 PM · KDE PIM
carewolf committed R120:ce69fc4ea914: Fix systemtray configuration (authored by carewolf).
Fix systemtray configuration
Mar 13 2020, 3:23 PM
carewolf closed D26923: Fix systemtray configuration.
Mar 13 2020, 3:22 PM · Plasma
carewolf committed R478:d2b9d21d2d5b: Fix build with Qt 5.15 beta2 (authored by carewolf).
Fix build with Qt 5.15 beta2
Mar 13 2020, 3:21 PM
carewolf closed D28012: Fix build with Qt 5.15 beta2.
Mar 13 2020, 3:21 PM
carewolf committed R477:6d26db709347: Undo switch to networkError() getter (authored by carewolf).
Undo switch to networkError() getter
Mar 13 2020, 3:19 PM
carewolf committed R76:3a1917d4cee4: Fix build with Qt 5.15 beta2 (authored by carewolf).
Fix build with Qt 5.15 beta2
Mar 13 2020, 3:19 PM
carewolf closed D28013: Fix build with Qt 5.15 beta2.
Mar 13 2020, 3:19 PM · KDE PIM
carewolf closed D28010: Undo switch to networkError() getter.
Mar 13 2020, 3:17 PM · KDE PIM

Mar 12 2020

carewolf updated the diff for D28010: Undo switch to networkError() getter.

update

Mar 12 2020, 1:33 PM · KDE PIM
carewolf updated the diff for D28008: Don't use deprecated QList::toSet.

Build with <5.14

Mar 12 2020, 1:23 PM · KDE PIM
carewolf requested review of D28013: Fix build with Qt 5.15 beta2.
Mar 12 2020, 12:22 PM · KDE PIM
carewolf added a reviewer for D28012: Fix build with Qt 5.15 beta2: danders.
Mar 12 2020, 12:20 PM
carewolf requested review of D28012: Fix build with Qt 5.15 beta2.
Mar 12 2020, 12:20 PM
carewolf added a reviewer for D28011: Fix build with 5.14.2 and 5.15 beta2: mlaurent.
Mar 12 2020, 12:13 PM · KDE PIM
carewolf requested review of D28011: Fix build with 5.14.2 and 5.15 beta2.
Mar 12 2020, 12:13 PM · KDE PIM
carewolf added a reviewer for D28010: Undo switch to networkError() getter: mlaurent.
Mar 12 2020, 12:06 PM · KDE PIM
carewolf requested review of D28010: Undo switch to networkError() getter.
Mar 12 2020, 12:06 PM · KDE PIM
carewolf added a reviewer for D28009: Don't use deprecated QSet::toList(): mlaurent.
Mar 12 2020, 12:02 PM · KDE PIM
carewolf requested review of D28009: Don't use deprecated QSet::toList().
Mar 12 2020, 12:02 PM · KDE PIM
carewolf added reviewers for D28008: Don't use deprecated QList::toSet: mlaurent, vkrause.
Mar 12 2020, 11:59 AM · KDE PIM
carewolf requested review of D28008: Don't use deprecated QList::toSet.
Mar 12 2020, 11:58 AM · KDE PIM
carewolf added reviewers for D28006: Fix build with Qt 5.15 beta2: Konsole, hindenburg.
Mar 12 2020, 11:53 AM · Konsole
carewolf requested review of D28006: Fix build with Qt 5.15 beta2.
Mar 12 2020, 11:51 AM · Konsole

Feb 21 2020

carewolf added a comment to F8118083: Screenshot_20200221_071838.png.

Text is a bit on the small side. It should be 40% of the clock text height.

Feb 21 2020, 3:48 PM
carewolf updated the diff for D27522: Fix date-label size in vertical layout.

Fixing also for short data and very long dates

Feb 21 2020, 11:30 AM · Plasma

Feb 20 2020

carewolf added a comment to D27522: Fix date-label size in vertical layout.

In my case the text was too small.

Feb 20 2020, 9:05 PM · Plasma
carewolf added a comment to D27522: Fix date-label size in vertical layout.

It only affects vertical panels, it is in the vertical panel configuration.

Feb 20 2020, 4:17 PM · Plasma
carewolf added a reviewer for D27522: Fix date-label size in vertical layout: ngraham.
Feb 20 2020, 3:42 PM · Plasma
carewolf added a reviewer for D27522: Fix date-label size in vertical layout: ndavis.
Feb 20 2020, 3:40 PM · Plasma
carewolf updated the diff for D27522: Fix date-label size in vertical layout.

Fix the logic to what was probably originally meant.

Feb 20 2020, 3:39 PM · Plasma
carewolf requested review of D27522: Fix date-label size in vertical layout.
Feb 20 2020, 3:37 PM · Plasma

Jan 26 2020

carewolf updated the diff for D26923: Fix systemtray configuration.

Changed name of property instead

Jan 26 2020, 10:04 AM · Plasma
carewolf added a comment to D26586: [SystemTray] Rework system tray settings.

This change break settings for me due to currentValue in ConfigEntries.qml conflicting. It works if I rename the variable to something else

Are you using Qt 5.14?

Jan 26 2020, 9:49 AM · Plasma
carewolf requested review of D26923: Fix systemtray configuration.
Jan 26 2020, 9:46 AM · Plasma
carewolf added a comment to D26586: [SystemTray] Rework system tray settings.

This change break settings for me due to currentValue in ConfigEntries.qml conflicting. It works if I rename the variable to something else

Jan 26 2020, 9:39 AM · Plasma

Oct 31 2019

carewolf added inline comments to D23801: Port kpac from QtScript.
Oct 31 2019, 5:19 PM · Frameworks
carewolf added inline comments to D23801: Port kpac from QtScript.
Oct 31 2019, 8:03 AM · Frameworks
carewolf added inline comments to D23801: Port kpac from QtScript.
Oct 31 2019, 12:13 AM · Frameworks

Sep 10 2019

carewolf added a comment to T9228: Port KWin scripts from QtScript.

Are you sure QML can't handle QList<QObjectDerived*>. kwineffects.h only forward declares EffectWindow so Qt/QML might not be able to tell it is QObject derived, and EffectWindow, EffectWindow* and QList<EffectWindow*> are also not registered as a metatypes (though QVector<EffectWindow*> is)

Sep 10 2019, 3:39 PM · Plasma
carewolf closed D23833: Fix port to QJS.
Sep 10 2019, 2:51 PM · Frameworks
carewolf committed R241:9e1220bf76ad: Fix port to QJS (authored by carewolf).
Fix port to QJS
Sep 10 2019, 2:51 PM
carewolf added a comment to D23833: Fix port to QJS.

It was already described in the two tests included kpactest.pac and kpactest2.pac

Sep 10 2019, 2:50 PM · Frameworks
carewolf requested review of D23833: Fix port to QJS.
Sep 10 2019, 1:34 PM · Frameworks
carewolf committed R241:4ad1902278f0: Port kpac from QtScript (authored by carewolf).
Port kpac from QtScript
Sep 10 2019, 12:06 PM
carewolf closed D23801: Port kpac from QtScript.
Sep 10 2019, 12:06 PM · Frameworks

Sep 9 2019

carewolf requested review of D23801: Port kpac from QtScript.
Sep 9 2019, 4:18 PM · Frameworks

Sep 7 2019

carewolf abandoned D16532: Avoid deadlocking Akonadi on duplicates during merge.
Sep 7 2019, 1:03 PM · KDE PIM
carewolf abandoned D14948: Port scriptabletags to QJSEngine.
Sep 7 2019, 1:03 PM

Jun 7 2019

carewolf added a reviewer for D21649: Fix poppler builds for kitinerary: mpyne.
Jun 7 2019, 12:58 PM
carewolf requested review of D21649: Fix poppler builds for kitinerary.
Jun 7 2019, 12:57 PM

Jun 5 2019

carewolf added inline comments to D21604: Fix building with Qt 5.13.
Jun 5 2019, 3:39 PM · Baloo, Frameworks
carewolf added reviewers for D21604: Fix building with Qt 5.13: bruns, ngraham.
Jun 5 2019, 2:58 PM · Baloo, Frameworks
carewolf requested review of D21604: Fix building with Qt 5.13.
Jun 5 2019, 2:57 PM · Baloo, Frameworks

Feb 4 2019

carewolf created P298 qtwebengine-icu.diff in the S1 KDE Community space.
Feb 4 2019, 12:00 PM

Jan 5 2019

carewolf accepted D17984: Fix emmet script by using HEX instead of OCT numbers in strings.

Looks good to me

Jan 5 2019, 10:48 AM · Frameworks, Kate
carewolf added inline comments to D17970: Fix broken Emmet.
Jan 5 2019, 9:55 AM · Frameworks, Kate

Nov 9 2018

carewolf closed D16493: Fix crash in failing GMail resource.

Couldn't get arcanist to do anything sane, so landed manually
https://commits.kde.org/kdepim-runtime/a4316a290e243fd71a565a9b936012d27f116029

Nov 9 2018, 12:16 PM · KDE PIM
carewolf committed R44:a4316a290e24: Fix crash in failing GMail resource (authored by carewolf).
Fix crash in failing GMail resource
Nov 9 2018, 12:16 PM

Nov 4 2018

carewolf added a comment to D16532: Avoid deadlocking Akonadi on duplicates during merge.

As for ignoring cases where size doesn't match... Then what? Akonadi would still be completely frozen if chose to fail here, and would need to have the cache cleared to do anything. This is a hard error state, akonadi stops working if we don't do finish the merge, failing leads to a brick state for most users.

Nov 4 2018, 10:51 AM · KDE PIM
carewolf added a comment to D16532: Avoid deadlocking Akonadi on duplicates during merge.

The problem is, in this case, with the existing code, the only way to get akonadi working again would be dropping the cache in akonadiconsole, and then redownloading everything from the server, which means we would only have one of the RIDs. If we could make sure than excess RIDs are removed during normal syncs, that would work too as syncs are automatically triggered if there is a duplicate like this because the number of messages doesn't match. This change just makes things keep working until such a correction is made.

Nov 4 2018, 10:47 AM · KDE PIM

Oct 30 2018

carewolf added a reviewer for D16532: Avoid deadlocking Akonadi on duplicates during merge: dvratil.
Oct 30 2018, 7:18 PM · KDE PIM
carewolf requested review of D16532: Avoid deadlocking Akonadi on duplicates during merge.
Oct 30 2018, 7:17 PM · KDE PIM

Oct 28 2018

carewolf updated the summary of D16493: Fix crash in failing GMail resource.
Oct 28 2018, 7:55 PM · KDE PIM
carewolf requested review of D16493: Fix crash in failing GMail resource.
Oct 28 2018, 7:53 PM · KDE PIM

Oct 25 2018

carewolf added a comment to D14948: Port scriptabletags to QJSEngine.

See https://github.com/steveire/grantlee/pull/44

Oct 25 2018, 11:21 AM

Oct 20 2018

carewolf added a comment to D14948: Port scriptabletags to QJSEngine.

Yes, he promised to look at it later, but he never got back to me. Maybe I should poke him

Oct 20 2018, 8:52 PM

Aug 24 2018

carewolf added a comment to D14948: Port scriptabletags to QJSEngine.

Yes it is for grantlee

Aug 24 2018, 8:57 AM

Aug 22 2018

carewolf updated subscribers of D14948: Port scriptabletags to QJSEngine.
Aug 22 2018, 1:40 PM

Aug 20 2018

carewolf requested review of D14948: Port scriptabletags to QJSEngine.
Aug 20 2018, 11:35 AM
carewolf abandoned D14944: Remove wrong Qt5Script dependency.

Nevermind.. This wasn't the right approach.

Aug 20 2018, 8:42 AM
carewolf updated the diff for D14944: Remove wrong Qt5Script dependency.

Comment out subdir

Aug 20 2018, 8:31 AM
carewolf added a reviewer for D14944: Remove wrong Qt5Script dependency: skelly.
Aug 20 2018, 8:27 AM
carewolf requested review of D14944: Remove wrong Qt5Script dependency.
Aug 20 2018, 8:26 AM

Aug 13 2018

carewolf committed R249:9040bff75a5d: Port ki18n from QtScript to QtQml (authored by carewolf).
Port ki18n from QtScript to QtQml
Aug 13 2018, 6:57 PM
carewolf closed D7033: Port ki18n from QtScript to QtQml.
Aug 13 2018, 6:57 PM · Frameworks

Aug 12 2018

carewolf abandoned D14769: Port ki18n from QtScript to QtQml.
Aug 12 2018, 2:54 PM · Frameworks
carewolf updated the diff for D7033: Port ki18n from QtScript to QtQml.

Fixed acall using a pure javascript bridge

Aug 12 2018, 2:53 PM · Frameworks
carewolf added a comment to D7033: Port ki18n from QtScript to QtQml.

I solved the Ts.acall. Unfortunately I forgot how arc works, so it became a new entry https://phabricator.kde.org/D14769

Aug 12 2018, 2:46 PM · Frameworks
carewolf added a reviewer for D14769: Port ki18n from QtScript to QtQml: ilic.
Aug 12 2018, 2:45 PM · Frameworks
carewolf requested review of D14769: Port ki18n from QtScript to QtQml.
Aug 12 2018, 2:44 PM · Frameworks
carewolf added a comment to D7033: Port ki18n from QtScript to QtQml.

Note the latest patch still has a maximum number of arguments for acall. I checked all the usages, and the only place that uses acall with a variable set of arguments is the sr (Serbian) translation. Since supporting a variable number of arguments would require changes to QtDeclarative and thus mean we would need to support both models until KDE depends on Qt 5.13, perhaps it would be easier to just rewrite the serbian translations apply_to_word function?

Aug 12 2018, 11:45 AM · Frameworks