- User Since
- Jul 23 2017, 2:08 PM (165 w, 16 h)
Aug 18 2020
I agree. A limit of 100 is arbitrary and harmful. Unfortunately clang-format doesn't seem to have a way to make lines over a certain length less desirably, but still allowed if the break would be ugly, so it is better to just allow long lines.
Aug 2 2020
May 5 2020
I for some reason can't land this change. It says "hook declined". Feel free to land it for me.
Apr 20 2020
Mar 17 2020
Done in separate change
Mar 16 2020
Mar 15 2020
Mar 14 2020
Mar 13 2020
Build with <5.14 too
Update to also build with <5.14
Mar 12 2020
Build with <5.14
Feb 21 2020
Text is a bit on the small side. It should be 40% of the clock text height.
Fixing also for short data and very long dates
Feb 20 2020
In my case the text was too small.
It only affects vertical panels, it is in the vertical panel configuration.
Fix the logic to what was probably originally meant.
Jan 26 2020
Changed name of property instead
This change break settings for me due to currentValue in ConfigEntries.qml conflicting. It works if I rename the variable to something else
Oct 31 2019
Sep 10 2019
Are you sure QML can't handle QList<QObjectDerived*>. kwineffects.h only forward declares EffectWindow so Qt/QML might not be able to tell it is QObject derived, and EffectWindow, EffectWindow* and QList<EffectWindow*> are also not registered as a metatypes (though QVector<EffectWindow*> is)
It was already described in the two tests included kpactest.pac and kpactest2.pac
Sep 9 2019
Sep 7 2019
Jun 7 2019
Jun 5 2019
Feb 4 2019
Jan 5 2019
Looks good to me
Nov 9 2018
Couldn't get arcanist to do anything sane, so landed manually
Nov 4 2018
As for ignoring cases where size doesn't match... Then what? Akonadi would still be completely frozen if chose to fail here, and would need to have the cache cleared to do anything. This is a hard error state, akonadi stops working if we don't do finish the merge, failing leads to a brick state for most users.
The problem is, in this case, with the existing code, the only way to get akonadi working again would be dropping the cache in akonadiconsole, and then redownloading everything from the server, which means we would only have one of the RIDs. If we could make sure than excess RIDs are removed during normal syncs, that would work too as syncs are automatically triggered if there is a duplicate like this because the number of messages doesn't match. This change just makes things keep working until such a correction is made.
Oct 30 2018
Oct 28 2018
Oct 25 2018
Oct 20 2018
Yes, he promised to look at it later, but he never got back to me. Maybe I should poke him
Aug 24 2018
Yes it is for grantlee
Aug 22 2018
Aug 20 2018
Nevermind.. This wasn't the right approach.
Comment out subdir
Aug 13 2018
Aug 12 2018
I solved the Ts.acall. Unfortunately I forgot how arc works, so it became a new entry https://phabricator.kde.org/D14769
Note the latest patch still has a maximum number of arguments for acall. I checked all the usages, and the only place that uses acall with a variable set of arguments is the sr (Serbian) translation. Since supporting a variable number of arguments would require changes to QtDeclarative and thus mean we would need to support both models until KDE depends on Qt 5.13, perhaps it would be easier to just rewrite the serbian translations apply_to_word function?