Differential D27766

[ModifiedFileIndexer] Omit BasicIndexingJob run when not required
ClosedPublic
Actions

Authored by bruns on Mar 1 2020, 4:58 PM.

Details

Reviewers
ngraham
astippich
Group Reviewers
Baloo
Commits
R293:55a43cf13514: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required
Summary

In case only the mtime has changed (i.e. only contents), only the times
and the content indexing flag have to be updated in the DB. The times
are already available from the fileinfo, so no need to create a
BasicIndexingJob.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Mar 1 2020, 4:58 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 1 2020, 4:58 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Mar 1 2020, 4:58 PM
anthonyfieroni added a subscriber: anthonyfieroni.Mar 1 2020, 5:07 PM
anthonyfieroni added inline comments.
src/file/modifiedfileindexer.cpp
118

This check is redundant now, we here only when cTimeChanged is true.

anthonyfieroni added inline comments.Mar 1 2020, 5:09 PM
src/file/modifiedfileindexer.cpp
118

I saw it in other patch, i does not need change.

astippich accepted this revision.Mar 3 2020, 6:56 PM
This revision is now accepted and ready to land.Mar 3 2020, 6:56 PM
Closed by commit R293:55a43cf13514: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required (authored by bruns). · Explain WhyMar 3 2020, 10:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/modifiedfileindexer.cpp (17 lines)

Diff 76891

View Options

src/file/modifiedfileindexer.cpp

Loading...