Differential D25421

[kio_tags] improve log message when the database can't be opened
Needs ReviewPublic
Actions

Authored by ahmadsamir on Nov 20 2019, 12:32 PM.

Details

Reviewers
astippich
ngraham
bruns
Group Reviewers
Baloo
Summary

When the database can't be opened, hint to the user that baloo may need
to be enabled.

Bug: 407786

Diff Detail

Repository
R293 Baloo
Branch
l-log-messages (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18989
Build 19007: arc lint + arc unit
ahmadsamir created this revision.Nov 20 2019, 12:32 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 20 2019, 12:32 PM
ahmadsamir requested review of this revision.Nov 20 2019, 12:32 PM
ngraham accepted this revision.Nov 20 2019, 2:36 PM
This revision is now accepted and ready to land.Nov 20 2019, 2:36 PM
bruns requested changes to this revision.Nov 20 2019, 3:42 PM
bruns added a subscriber: bruns.

This is obviously the wrong line of code for the referenced bug report.

This revision now requires changes to proceed.Nov 20 2019, 3:42 PM
ahmadsamir added a comment.Nov 20 2019, 4:34 PM
In D25421#565217, @bruns wrote:

This is obviously the wrong line of code for the referenced bug report.

Well, it's obvious now. :)

(I should have tested, but now that I try to test, I can't reproduce the same behaviour from the report, but I think I got it with the updated diff; but the logging category should have been a clue :/).

Will update the diff shortly.

ahmadsamir updated this revision to Diff 70062.Nov 20 2019, 4:57 PM
ahmadsamir retitled this revision from [file_extractor] improve log message when the database can't be opened to [kio_tags] improve log message when the database can't be opened.
ahmadsamir edited the summary of this revision. (Show Details)
ahmadsamir removed a subscriber: bruns.

Change the the message that is actually mentioned in the bug report

ngraham accepted this revision.Mar 16 2020, 4:03 PM

Revision Contents
Changeset List

PathPackages
Msrc/lib/taglistjob.cpp (2 lines)

Diff 70062

View Options

src/lib/taglistjob.cpp

Loading...