[ModifiedFileIndexer] Correct time checks for new files
ClosedPublic

Authored by bruns on Sun, Mar 1, 5:00 PM.

Details

Summary

In case baloo has just started, a new and immediately modified file can
end up in the ModifiedFileIndexer. In this case, the timestamps default
to 0. As a 0 timestamp also occasionally appears e.g. for files from
archives (tar, zip ...) these would be treated as unchanged and not be
added to the index.

Depends on D27766

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Sun, Mar 1, 5:00 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSun, Mar 1, 5:00 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Sun, Mar 1, 5:00 PM
astippich added inline comments.
src/file/modifiedfileindexer.cpp
74

const?

bruns marked an inline comment as done.Sun, Mar 1, 11:47 PM
bruns edited the summary of this revision. (Show Details)
astippich accepted this revision.Tue, Mar 3, 6:59 PM
This revision is now accepted and ready to land.Tue, Mar 3, 6:59 PM

I would like to request a clear answer for https://phabricator.kde.org/D25517 once again

This revision was automatically updated to reflect the committed changes.