Only extract lyrics when the plain text flag is set
Needs ReviewPublic

Authored by astippich on Mon, Nov 25, 10:45 AM.

Details

Reviewers
bruns
mgallien
ngraham
Group Reviewers
Baloo
Summary

One can argue that lyrics are not really metadata, but
actually the content and a large chunk of text.
Since the default flag is ExtractEverything, nothing will
change for the default case.

Diff Detail

Repository
R286 KFileMetaData
Branch
lyricsExtraction
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19133
Build 19151: arc lint + arc unit
astippich created this revision.Mon, Nov 25, 10:45 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMon, Nov 25, 10:45 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Mon, Nov 25, 10:45 AM

The dolphin temp extractor uses KFileMetaData::ExtractionResult::ExtractMetaData explicitly.

Though in general I agree (and "PlainText" should be better named "FullText").

For baloo-widgets, the display of the lyrics tag is disabled anyways. Displaying a large chunk of text does not really look good in the information panel...