Change style for Breeze and Breeze Dark

We did agree to have Qt and GTK settings separate in T8871

BTW, when you change a file into a symlink or vice versa, can you delete the icon you're changing in a separate commit and then add the new version of the icon? arc patch doesn't work when a file has been changed from or to a symlink in one step. You can do that by undoing the latest commit with git reset HEAD~.

I don't think the light/dark window background looks good. It also gives the wrong message because the Colors KCM is what controls the window background color. The Window Decoration KCM icon has the same issue, but that already exists. Perhaps you should put buttons or sliders on the icon instead of using alternating background. That, or you could stick to keeping the Qt and GTK widget style KCMs separate and use symbolism for Qt/KDE and GTK/GNOME on 2 different icons.

Increase spacing between outside rotation marks and screen for 32px version

Where is this icon seen? What sizes are needed?

Would it make sense to have 3 icons for auto-rotate, locked to portrait and locked to landscape?

@guoyunhe Do you mind if I commandeer this?

In D18358#429972, @aacid wrote:

How does it look when you don't have latest breeze?

• Add window-shade/unshade

Lower down arrow on expand-all

In D19605#429711, @ngraham wrote:

I think I agree that it's much better to improve things universally if we can. But if we can't, then improving things for the default settings is good too.

@ndavis, how well tested is this? We can't land this if it causes any regressions. I didn't spot any with a few font & size combinations but let's make sure we test extensively.

Also, I'd like some comments added to the code to indicate why we're using floating-point values for these.

Though the icons are indeed pretty, and the problem with small monochrome icons has been resolved, the information density is now quite low.

@zzag Is there anything you want me to change?

@trickyricky26 do you mind if I commandeer this so I can get it finished today?

window-shade can be added in a later patch so that this one isn't unnecessarily held back

Can it have the same default width as the toolbar text location comboboxes?

Is that "Application style" combobox long enough to accommodate longer strings like "MS Windows 9x"?

• Add window-unpin-symbolic

I vote for Ion as well. It just sounds cool and it kind of make sense since plasma is ionized gas.

• Add window-unpin

Rebase on master

Rebase on master

Rebase on master

In D19633#427913, @ngraham wrote:

Neat! Very helpful, thanks.

While you're at it, do you think you could add a window-unpin icon too? https://bugs.kde.org/show_bug.cgi?id=405195

Could you align the top of the down arrow in expand-all to the pixel grid and move it down by 1px? Like so:

Rename window-maximized to window-restore for better 3rd party compatibility

+1

Yes, I think this is better and it's good to be consistent.

Use these, they're more similar to the titlebar shade button, but aligned to the pixel grid better. I will change the go-* icons in another patch.

In D19605#427037, @zzag wrote:

This patch makes buttons sharp only for one particular button size and font size.

I like it overall, but some of those icons need changing. Not just here, but in breeze-icons as well.

Fix formatting on line parameters for Shade button

I just noticed, there is already a go-top icon that looks just like collapse-all. That's a problem. "Collapse all" is different enough from "Go to top" that they shouldn't be the same icon.

The symlinks in the symbolic folder should end with -symbolic (e.g., expand-all-symbolic.svg)

In D19575#426762, @ngraham wrote:

Could we get symlinks for these that point to window-keep-above and window-keep-below too?

Horizontal menus are fast, but unusable or hard to read if they get too large. Scrollable menus with the arrows that you hover over are annoyingly slow if you don't use a scroll wheel to scroll, but don't block the entire screen if you have a large number of items. In both cases, the best solution from the user's end is to make more folders so that the list doesn't overflow.

In D19230#422088, @ngraham wrote:

We could, but is that really necessary? In general we try to avoid having UI elements dynamically show and hide themselves outside of the narrowly-defined exception of when a UI element is inapplicable to the currently active hardware. That condition doesn't apply here, so what we would do instead is enable and disable the button, which I think would be a bit weird.

Can you hide the button to open the Formats KCM when "Use Region Defaults" is not selected?

I think so

In D19230#421924, @ngraham wrote:

I mean, what do you think about the specific string "Use region's default setting". Too wordy? Just right?

In D19392#421903, @ngraham wrote:

Actually we're discussing in VDG-land whether or not this is something we should do anyway, because right now we have no way of forcing the use of a monochrome icon for a >22px size when a larger colorful version exists. Using -symbolic to suffix the monochrome versions would allow us to do this. Adding some VDG folks for comment.

One last thing, you need to use your real name as your Git user name in order for this patch to pass an automated audit.

In D19324#421552, @axionl wrote:

This is my first time to contribute plasma/kde project, I feel sorry for my mistakes and thanks for your help.

In T10537#177388, @GB_2 wrote:

In T10537#177385, @ndavis wrote:

This already exists in the form of Look and Feel packs. It may not have support for all of those settings right now, but it would be better to extend Look and Feel than create a new type of theme pack.

Agree, we should improve Look and Feel packs.
I think we should also have a way to apply only the layout without applying the theme.

This already exists in the form of Look and Feel packs. It may not have support for all of those settings right now, but it would be better to extend Look and Feel than create a new type of theme pack.

In D19230#421215, @abetts wrote:

Do you think that "locale" is a very specific term? Could it be different?

This is a much more usable design and more in line with our HIG.

Great. Now you just need to get rid of the invisible rectangle. You can do that quickly with sed -i 's|<rect x="9.5367e-8" y="284.3" width="12.7" height="12.7" fill="none" opacity=".35"/>||' code.svg. After you've done that, I can accept and land this.

In D19379#421001, @rooty wrote:

Center how? Vertically?
Where would the elements be placed (with respect to the Clock / user names/avatars / action buttons)?

I don't think it looks very nice. If you're worried about those UI elements not being visible, wouldn't it be better to move them towards the center? Then, if it's necessary, you can add a background to all the floating UI elements so that they're all visible.

In D19324#420982, @axionl wrote:

Just I like it as a modern design style and also avoiding some problems for the similarity of official icon, but if you mind that I can remove it.

You also need to optimize the icon. You can do that by using one of the three SVG optimizers on this page: https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow#svg-optimization