down
ClosedPublic
Actions

Authored by ndavis on Mar 9 2019, 5:18 PM.

Details

Reviewers

ngraham

Group Reviewers

VDG

Commits

Summary

go-up/down is more appropriate because go-top/bottom is supposed to be for skipping to the top or bottom.

Test Plan

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ndavis requested review of this revision.Mar 9 2019, 5:18 PM

ndavis edited the test plan for this revision. (Show Details)Mar 9 2019, 5:46 PM

This revision is now accepted and ready to land.Mar 10 2019, 4:54 AM

Rebase on master

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			icons-dark/actions/16/go-down-search.svg (2 lines)
M			icons-dark/actions/16/go-up-search.svg (2 lines)
M			icons-dark/actions/22/go-down-search.svg (2 lines)
M			icons-dark/actions/22/go-up-search.svg (2 lines)
M			icons-dark/actions/24/go-down-search.svg (2 lines)
M			icons-dark/actions/24/go-up-search.svg (2 lines)
M			icons/actions/16/go-down-search.svg (2 lines)
M			icons/actions/16/go-up-search.svg (2 lines)
M			icons/actions/22/go-down-search.svg (2 lines)
M			icons/actions/22/go-up-search.svg (2 lines)
M			icons/actions/24/go-down-search.svg (2 lines)
M			icons/actions/24/go-up-search.svg (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53531	7080d72		Mar 9 2019, 5:18 PM	★	★
Diff 2	53560	612a013	Rebase on master	Mar 10 2019, 6:34 AM	★	★
Diff 3	53562	612a013	R266:f2509047d4372f1a59d8f8b5ff009146f1a6adcb	Mar 10 2019, 6:34 AM	★	★