Differential D19620

Use a searchbar similar to the one in okular
AbandonedPublic
Actions

Authored by ognarb on Mar 8 2019, 6:25 PM.

Details

Reviewers
ndavis
ngraham
Group Reviewers
VDG
Frameworks
Summary

Improve consistency between different KDE apps.

It's not perfect (close button isn't aligned).

Old:


New:

Test Plan

Build and tested with konqueror master

Diff Detail

Repository
R313 KHtml
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9605
Build 9623: arc lint + arc unit
ognarb created this revision.Mar 8 2019, 6:25 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 8 2019, 6:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ognarb requested review of this revision.Mar 8 2019, 6:25 PM
ognarb edited the summary of this revision. (Show Details)Mar 8 2019, 6:28 PM
ognarb added reviewers: VDG, Frameworks.
ognarb retitled this revision from Use a searchbar similar to the one from okular to Use a searchbar similar to the one in okular.Mar 8 2019, 8:30 PM
ndavis accepted this revision.Mar 8 2019, 8:45 PM
ndavis added a subscriber: ndavis.

Yes, I think this is better and it's good to be consistent.

This revision is now accepted and ready to land.Mar 8 2019, 8:45 PM
ognarb planned changes to this revision.Mar 8 2019, 9:39 PM

Need to remove label and add a placeholder text and clearButton

ognarb updated this revision to Diff 53488.Mar 8 2019, 11:25 PM
ognarb edited the summary of this revision. (Show Details)

Use placeholder text and clearButton

This revision is now accepted and ready to land.Mar 8 2019, 11:25 PM
ognarb edited the summary of this revision. (Show Details)Mar 8 2019, 11:27 PM
ngraham accepted this revision.Mar 9 2019, 12:20 AM
ngraham added a subscriber: ngraham.

Nice work!

ognarb updated this revision to Diff 53505.Mar 9 2019, 11:21 AM

Add icons

ognarb edited the summary of this revision. (Show Details)Mar 9 2019, 11:22 AM
ognarb edited the summary of this revision. (Show Details)Mar 14 2019, 1:31 PM
ognarb updated this revision to Diff 53906.Mar 14 2019, 6:39 PM

Remove icon to option button

ognarb edited the summary of this revision. (Show Details)Mar 14 2019, 6:39 PM
ognarb edited the summary of this revision. (Show Details)
ognarb edited the summary of this revision. (Show Details)Mar 14 2019, 7:22 PM
ognarb updated this revision to Diff 53928.Mar 14 2019, 10:15 PM

Use Unicode ellipsis

GB_2 added a subscriber: GB_2.Aug 16 2019, 8:18 AM

Don't use the unicode ellipsis. We use three dots everywhere.

dhaumann added a subscriber: dhaumann.Aug 17 2019, 6:47 AM
In D19620#512883, @GB_2 wrote:

Don't use the unicode ellipsis. We use three dots everywhere.

Interesting. @ngraham didn't you suggest to use the ellipsis recently?

GB_2 added a comment.EditedAug 17 2019, 8:50 AM

See https://phabricator.kde.org/D19774#inline-110882
For now we should keep it consistent. If you want unicode ellipsis everywhere then make a task.

ngraham added a comment.Sep 21 2019, 2:56 PM

Isn't KHTML deprecated at this point? Does this actually need to happen?

ognarb abandoned this revision.Sep 21 2019, 4:06 PM

I completly forgot about this patch and since KHTML is dead and is getting removed from most of our apps, it doesn't makes sence to land this patch.

Revision Contents
Changeset List

Diff 53928

View Options

src/ui/findbar/khtmlfindbar.cpp

Loading...
View Options

src/ui/findbar/khtmlfindbar_base.ui

Loading...