I don't think the light/dark window background looks good. It also gives the wrong message because the Colors KCM is what controls the window background color. The Window Decoration KCM icon has the same issue, but that already exists. Perhaps you should put buttons or sliders on the icon instead of using alternating background. That, or you could stick to keeping the Qt and GTK widget style KCMs separate and use symbolism for Qt/KDE and GTK/GNOME on 2 different icons.

BTW, when you change a file into a symlink or vice versa, can you delete the icon you're changing in a separate commit and then add the new version of the icon? arc patch doesn't work when a file has been changed from or to a symlink in one step. You can do that by undoing the latest commit with git reset HEAD~.

In D19733#430500, @ndavis wrote:

I don't think the light/dark window background looks good. It also gives the wrong message because the Colors KCM is what controls the window background color. The Window Decoration KCM icon has the same issue, but that already exists. Perhaps you should put buttons or sliders on the icon instead of using alternating background. That, or you could stick to keeping the Qt and GTK widget style KCMs separate and use symbolism for Qt/KDE and GTK/GNOME on 2 different icons.

I would tend to agree.

We did agree to have Qt and GTK settings separate in T8871

I think preferences-desktop-theme-applications is fine, but preferences-desktop-theme-windowdecorations looks odd with that border.

In D19733#431139, @ndavis wrote:

I think preferences-desktop-theme-applications is fine, but preferences-desktop-theme-windowdecorations looks odd with that border.

Well, what do you suggest? This is the most accurate design.

In D19733#431237, @GB_2 wrote:

In D19733#431139, @ndavis wrote:

I think preferences-desktop-theme-applications is fine, but preferences-desktop-theme-windowdecorations looks odd with that border.

Well, what do you suggest? This is the most accurate design.

I think making it the same as the current preferences-desktop-theme is fine. Then preferences-desktop-theme can become a symlink to preferences-desktop-theme-applications.

So now this happens:

Does the category Icon in System Settings itself need to be updated too?

In D19733#431693, @ngraham wrote:

So now this happens:

Does the category Icon in System Settings itself need to be updated too?

Did you clear your cache?

Yep, I always do.

This change appears to have broken Windows builds (when using the QRC bundles anyway, which it seems regular Windows CI builds don't enable)

See https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20kf5-qt5%20WindowsMSVCQt5.11/lastFailedBuild/consoleText

In D19733#432498, @bcooksley wrote:

This change appears to have broken Windows builds (when using the QRC bundles anyway, which it seems regular Windows CI builds don't enable)

See https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20kf5-qt5%20WindowsMSVCQt5.11/lastFailedBuild/consoleText

That build was before this patch landed. The error was caused by https://phabricator.kde.org/R266:3bd19e01b91338d9b9f0fd4f646f814ccdc30928, which I had to make in preparation for this patch to land, because of an arc/Phabricator bug.
So it should already be fixed now, since this patch has already been landed.

I see. If possible please do try to batch the commits together into a single push to avoid such breakages in the future.

We actually could not for technical reasons due to the following Phabricator bug: https://secure.phabricator.com/T1022