Add window-keep-above/below
Add window-maximize/restore/minimize
Change window-pin to titlebar button style
Make window-close more consistent
FEATURE: 405195
FIXED-IN: 5.57
ngraham |
VDG |
Add window-keep-above/below
Add window-maximize/restore/minimize
Change window-pin to titlebar button style
Make window-close more consistent
FEATURE: 405195
FIXED-IN: 5.57
Breeze:
Breeze Dark:
Breeze:
Breeze Dark:
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Neat! Very helpful, thanks.
While you're at it, do you think you could add a window-unpin icon too? https://bugs.kde.org/show_bug.cgi?id=405195
Yes, but I'm not sure if it should copy the style of the unpin button from the tilebar or if it should have a line through it like you suggested. I feel like the line is more clear, but less consistent. Maybe it's the titlebar button unpin that should be changed?
Yeah, I kinda think the titlebar icon should look more like a toggle action such that a pinned window just gets a background circle and the symbol inverts. Regardless, we'd need a different style anyway for the proposed window-unpin icon since it's going to be used for a menu action where the title literally is "Unpin from Task Manager."
window-shade can be added in a later patch so that this one isn't unnecessarily held back